Received-SPF: pass (google.com: domain of linux-kernel+bounces-8163-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <b60e39ce-04bf-4ff9-8879-d9e0cf5d84bd@oracle.com>
Date: Thu, 21 Dec 2023 09:49:35 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 00/16] block atomic writes
To: Christoph Hellwig <hch@lst.de>
Cc: "Darrick J. Wong" <djwong@kernel.org>, axboe@kernel.dk, kbusch@kernel.org,
        sagi@grimberg.me, jejb@linux.ibm.com, martin.petersen@oracle.com,
        viro@zeniv.linux.org.uk, brauner@kernel.org, dchinner@redhat.com,
        jack@suse.cz, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
        linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        tytso@mit.edu, jbongio@google.com, linux-scsi@vger.kernel.org,
        ming.lei@redhat.com, jaswin@linux.ibm.com, bvanassche@acm.org
References: <20231212110844.19698-1-john.g.garry@oracle.com>
 <20231212163246.GA24594@lst.de>
 <b8b0a9d7-88d2-45a9-877a-ecc5e0f1e645@oracle.com>
 <20231213154409.GA7724@lst.de>
 <c729b03c-b1d1-4458-9983-113f8cd752cd@oracle.com>
 <20231219051456.GB3964019@frogsfrogsfrogs> <20231219052121.GA338@lst.de>
 <76c85021-dd9e-49e3-80e3-25a17c7ca455@oracle.com>
 <20231219151759.GA4468@lst.de>
 <fff50006-ccd2-4944-ba32-84cbb2dbd1f4@oracle.com>
 <20231221065031.GA25778@lst.de>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20231221065031.GA25778@lst.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?VlVGS1FQa0t1VUZUSUNoV09UREZDNGlHOThUbzEzZG50YmJiVUNXSXB6eDZX?=
 =?utf-8?B?dms1SjlWN2FwWm9vKzJaRmhSWFlaSGVPNkhjdzVGYWtYRlFMNlI2Wm1NU0h2?=
 =?utf-8?B?U2FXbElEZlNQb1QwQWNxZzRHcXdkalYrL3FsU2FNektOWXNEN0h6anc2R1d4?=
 =?utf-8?B?aDVQb0xPQXZnc2o2K1JZSXdrUXk0MUJWSGlBOTViYTRDTUZvVzlvNHJnUGRE?=
 =?utf-8?B?M0JyVEJLb1czRUNIeGJGblRpNzBYVE5HZC93T281ZDFjL1dZOEtWTU41ZFBQ?=
 =?utf-8?B?WGp5c2wvOEFFd3dxL2RlQ0tGWVpiaFhPY1BaUS9QSUswd1VVUHdnSU1VcnRM?=
 =?utf-8?B?b0hDUThCWHc3TkdCaU9paER5cWRZVU8vTldkQmdBcUFKaWhVclVjMytoREFF?=
 =?utf-8?B?dytBekR2NXFwVHQxT01YQzV5Rmk4dVZCMzFsRzVUREhiWmlxNWpWQWgrR0hI?=
 =?utf-8?B?QXcxSjY2Yk1Nand2RkVFNzdVY0ZRSXRxOGtXRSsvSFdNN1lYTVE1TDA5WkJu?=
 =?utf-8?B?SFFhRlFjY0R4aUtrNlVHalNMQmZreVpweHpJbXJOcG1UV2cxL1ZQc2tUaWFq?=
 =?utf-8?B?eWVRcWlmdDBHcFlMVlk0V0xFT3lJSmFmbGs3NjlkOWNFR2lzeG9XSWx1QlVh?=
 =?utf-8?B?RUF0WE5HT05ZM25NZGNVaEJTcnNYTTBIbFVnRXRVc0tEaUliMlRwVFF3Y0N0?=
 =?utf-8?B?UE1lSTlxWmRZNzVSWE1IenpPanF0QnBpR3RkRlVHVVhTZFhsdnU2VG1nSTFQ?=
 =?utf-8?B?U3VBZ2lWNWIxWnFmRlVhUnNXZlBEbWFDSjRsS0tDdFR6M3k2UHYxOFVjVTJB?=
 =?utf-8?B?SWhIWW9VTUVXNkRrNnU3eUgwOVQrVjhreW9SQ2w3L1ZYV3VLZ3F4N2ViRU9a?=
 =?utf-8?B?UVRqeG40enZtUHhOUVRSdGdrNW9aN1N5WER5S0FkMi9vbmtpTm1iTm51RVJP?=
 =?utf-8?B?cHZWbzc5dnRieDh4RjJZSU85bmFoM1JvNkdma2pIRVN3UWJVdms1SFczdDVM?=
 =?utf-8?B?MncwU3U3RjJKSVBUNmZLZjB3NEIyMHZLRWJEQUMxWDhvZFRzbEFzRnlTTTc0?=
 =?utf-8?B?SUdTaUxsZGVlMTJMWWJ6VlJUMUlmMVVVcGRqaDJUMGw0dWVsemgzUGllQ3BK?=
 =?utf-8?B?WWpsNWZSbHBZRks3QWx3UE13eHpmRU83VTdrY1QvSTRzL1VZemI5ZmY2dEZ3?=
 =?utf-8?B?YU1adXhpaXJ1cnhySVpwNXkxTU1DcGJNVXh6THBrbG92eURJRllkbkpJUjlh?=
 =?utf-8?B?L3pkc1ZIRHhSUjlYa2x1Y2dRekxNV2ZrRlQ1Q0poU0Q5VW5FWisycEVtWmFN?=
 =?utf-8?B?WUdZV0Z5a093SmxmTVBQb0lhcXRNMXJIci82MUJyWnZ2Uys1STBkaUR2VFZt?=
 =?utf-8?B?QjQ5UERKQWlPT2xXaG1tOTVHek5ZRk9iQjdwMEgvQTJBK2xsY3JMKzExUjQw?=
 =?utf-8?B?NzFoeWhaWEw3VmlOYkJ5OUI1dTNxU0tvZzBBbkdwVlBQQnZXc0NnRC93ejVl?=
 =?utf-8?B?eE16SlFCYUx2OFdSWnQ0cGtPWVYrb3RQMnB6Nm5iVzIzMzZvQmp6N1hiNHh3?=
 =?utf-8?B?R1Ura2Vsdk8xeFV3czJBZDQzUjhXZmVySzBBcWZYMUhnM1htdlBDQ1EyR2hJ?=
 =?utf-8?B?ajB3b3FETFo4MG9vTGFJTjJPaHJtRUEvWnZIelBoMlhkUU9KenlFZ3hPNUgv?=
 =?utf-8?B?MFYzM2JnUlJxV05hODdyRnRsVnVlcTFHNFBtS3V3VUN0Q3pzc0xzaTl4cTg0?=
 =?utf-8?B?bUwvSG9LU1lMVFFsK3Z3OUUxazBtY1NVOEZ4MlJPQWJJN05DQWN5azlGR2hl?=
 =?utf-8?B?OWFhL2FmVjB6RUVqNjBWRy9TSTh2Rm10Q2dyVWhJYUNFSTRJU2MzNEFmcnc3?=
 =?utf-8?B?YnZCT1hoVGFHMXh6SStwdWJjOHFncnNTNFNodmxZbVVGYjRSeEVHU0lkZkFi?=
 =?utf-8?B?S2svN2FRdGNUZWdSZ044ZU1RaGYzM25tWmVUMVVLZkxaT0JYLzloTzhHUXFC?=
 =?utf-8?B?YlBnTFlCVllaaGN6TXRCaEVxTTErbGlFWFBNSFFSYndPb0Mza2dpMi9ra1gx?=
 =?utf-8?B?SHhDVkNsbU8wcmMrdlRqeGU0bXV5bytrdVhBQTM4TFhrdnQwR3NBZHBlS0tl?=
 =?utf-8?B?TnJLQkRQeUxOd1hCRDBsbGRGNG1ieVgyejNnVmp6cE81dm5GaFk5QVBHNUgw?=
 =?utf-8?B?aFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ow3Kmq0itvG7h0J5BfhilxSy1dpQenIMnBEGPsv5yKcPVKTWpn/uDiCNPPScC6bknXpTrkNkelcKRpTyDcW155iNf9906/DDxYWlo0TmWSy21BQVs4cSsIuxFQ/CCPKMK3v9dR+WOsU7pUPikboJ14hxuUgzyr5llRBPxcMQFovTqy9NCRsjmfuUAfvzFmCBWSYWwb5+E7+xBJIFDR8J4Xw/a9cIO/U87ame/pb01kzRsRJ3pW68fqUi3KDTfEs9wjCjUWO3n0lhrO+8nOZgS+xO35idejufNmnf+/EyU/7W4bDAyhssm92aYZU7h1tOssnuq9oGG4EMbZiSiarvqg+WfdvEbjcqVrkeDf87UNuvGBLSaVIYvCP+KrVLLDmo/f0txOz3tmLiK1hC4QB6iX+sSOMTqHiGfmGDheop9NYzHoJv1Vqf32yu8mgfFpAlUTpvyVpQ9w2WU7micyaBmpc6aSv3/9fUmm/yAP/BAIlChPsHdrzZ8uRvLM3MvHUI3ojKETLDRwVrjArbSOgNaAAbqeqHhvv/iHTb8nVxlkj57qSzfrz47sccGvMz+8xAtrdUpn+CAUwZcs9Y+ofu70kwqQfa1581N7vmMRzLy6Q=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ac26714-acbf-4434-3381-08dc020a26ae
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 09:49:40.3927
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ahgBWTO2+HNeWRaO3Pl6TDUFnURzBiPgwhCF0jLpIchxjy/AfWPAf3X9rX6uTYSZf5vCUBiiCInX4nT3Tifg7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4173
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-21_04,2023-12-20_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 malwarescore=0 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2312210072
X-Proofpoint-GUID: QVICMD2iccCAiUtrI2VB04jtiWqEpfZy
X-Proofpoint-ORIG-GUID: QVICMD2iccCAiUtrI2VB04jtiWqEpfZy

On 21/12/2023 06:50, Christoph Hellwig wrote:
> On Tue, Dec 19, 2023 at 04:53:27PM +0000, John Garry wrote:
>> On 19/12/2023 15:17, Christoph Hellwig wrote:
>>> On Tue, Dec 19, 2023 at 12:41:37PM +0000, John Garry wrote:
>>>> How about something based on fcntl, like below? We will prob also require
>>>> some per-FS flag for enabling atomic writes without HW support. That flag
>>>> might be also useful for XFS for differentiating forcealign for atomic
>>>> writes with just forcealign.
>>> I would have just exposed it through a user visible flag instead of
>>> adding yet another ioctl/fcntl opcode and yet another method.
>>>
>>
>> Any specific type of flag?
>>
>> I would suggest a file attribute which we can set via chattr, but that is
>> still using an ioctl and would require a new inode flag; but at least there
>> is standard userspace support.
> 
> I'd be fine with that, but we're kinda running out of flag there.

Yeah, in looking at e2fsprogs they are all used.

> That's why I suggested the FS_XFLAG_ instead, which basically works
> the same.
> 

ok, fine, we can try that out.

On another topic, maybe you can advise..

I noticed the NVMe patch to stop always setting virt boundary (thanks), 
but I am struggling for the wording for iovecs rules. I'd like to reuse 
iov_iter_is_aligned() to enforce any such rule.

I am thinking:
- ubuf / iovecs need to be PAGE-aligned
- each iovec needs to be length of multiple of PAGE_SIZE

But that does not work for total length < PAGE_SIZE.

So then we could have:
- ubuf / iovecs need to be PAGE-aligned
- each iovec needs to be length of multiple of atomic_write_unit_min. If 
total length > PAGE_SIZE, each iovec also needs to be a multiple of 
PAGE_SIZE.

I'd rather something simpler. Maybe it's ok.

Thanks,
John