Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp64529rdb; Thu, 21 Dec 2023 03:00:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IGK1yKn4fTf5hYAObbuu6s7BEW7xPS+Xi0rLKQYdm9XnGeZMaetT9m5Pexb6gao+nHaZZnN X-Received: by 2002:a17:906:1c51:b0:a23:35f9:82d8 with SMTP id l17-20020a1709061c5100b00a2335f982d8mr4077971ejg.59.1703156413790; Thu, 21 Dec 2023 03:00:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703156413; cv=none; d=google.com; s=arc-20160816; b=rnqayoUWLZgRXbaGWUUzy/hAc8pqdOkdO9RimEJAKrE0N3wuFK0H4BQDa2NPJ0AezT RThbvd5BdxqmOSYlIzmEFfcWHKkSAWLLuxX90xvxJ4UdI+NcbU0jF3OWrt8yp5epZF4K UZcZNNK7ZUrSMQbXOExfgryypsnJntPUhx7M0dfL/DMO/UF2pwuII8P+V1HLNb2ZzM5j 9XmqD1NE9oJkztOluoUjkOsXNVjU8SYdty8yanjxzzZxBqZBiIN74OTBAAuhwHqPjjzK D9qjtKftIA+sZwVzstViYaMTeWMmUFuFS2MmTjcRSOU5nyRwR7QhbbZoBQPAQIMyvj2Q uRVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature:dkim-signature:dkim-signature :dkim-signature; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; fh=i6rGHk/clC1f9Y4mpJyYVOWW6p98QflrI/jjeassMJc=; b=0HDWKnLOrfBMXiORylAr2WiIeQslxrE+oQd9t2f6x64v/EOAmaKHbNEjomjspxJgfU xBepPji+BT0DOjNjiv9HbgmOrHbOfQXhgsdJBH611O/5ZEFk230GN9mUWHzJWvmVe/Ph S95EMqAR9PLyr6NI2Y+0C0s+KJlzcO1PiECIrgc4rlpAQ3eiGevR6g3QN5TeKpMJ6lU/ oooUZkUvi8o0AA6DV8F7KxyXHgi2CGEDjfltOkgixKmlM4ODV9Y4G84H4xpc5cImo8KX BGpn/LR9MY7g6q2gZzkllw3LbEfQZwrFj/+wXMN/2U36RLxSe+hdcS4AeJc7MJ71kZFg ee8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=KOX9jgSm; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=KOX9jgSm; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=a5SMVjtV; spf=pass (google.com: domain of linux-kernel+bounces-8256-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8256-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id wi21-20020a170906fd5500b00a26ab41d1c0si197321ejb.59.2023.12.21.03.00.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 03:00:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8256-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=KOX9jgSm; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=KOX9jgSm; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=a5SMVjtV; spf=pass (google.com: domain of linux-kernel+bounces-8256-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8256-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 886451F24806 for ; Thu, 21 Dec 2023 11:00:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B334D6ABAB; Thu, 21 Dec 2023 11:00:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="KOX9jgSm"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="a5SMVjtV"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="KOX9jgSm"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="a5SMVjtV" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 598126A02D; Thu, 21 Dec 2023 10:59:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6E4B91FB42; Thu, 21 Dec 2023 10:59:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703156397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=KOX9jgSmKdCXnbQ05qeZeEyD/jTUeiSMMXmb78ldAvYlyvqNxabY3TB6ALwaCCgEyDa3n8 EQBTpLoWyijBPOZDfC7W01R28BIHiyE+Ib/rJ+U27Bc44UXCjZagaGjB0rz+mDtleJUkuA MTvZYEbT7KizaGn9vezvjOCPie+ZLSc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703156397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=a5SMVjtV5OgcuJnDegg+TTnF73BGoJXfTmVoKqFOhRO7o8ahluGCw/YOn/2FC3YHdka5M8 jkBuR0SECJwCKcAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1703156397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=KOX9jgSmKdCXnbQ05qeZeEyD/jTUeiSMMXmb78ldAvYlyvqNxabY3TB6ALwaCCgEyDa3n8 EQBTpLoWyijBPOZDfC7W01R28BIHiyE+Ib/rJ+U27Bc44UXCjZagaGjB0rz+mDtleJUkuA MTvZYEbT7KizaGn9vezvjOCPie+ZLSc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1703156397; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=npajW/mlWHrdK3reJzYC8iKJhiyMeovPiW3SxiW3PpU=; b=a5SMVjtV5OgcuJnDegg+TTnF73BGoJXfTmVoKqFOhRO7o8ahluGCw/YOn/2FC3YHdka5M8 jkBuR0SECJwCKcAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 59D5213725; Thu, 21 Dec 2023 10:59:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GXLsFa0ahGVRUQAAD6G6ig (envelope-from ); Thu, 21 Dec 2023 10:59:57 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 22EBAA07E3; Thu, 21 Dec 2023 11:59:57 +0100 (CET) Date: Thu, 21 Dec 2023 11:59:57 +0100 From: Jan Kara To: Christoph Hellwig Cc: linux-mm@kvack.org, "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 05/17] writeback: remove a duplicate prototype for tag_pages_for_writeback Message-ID: <20231221105957.havwaqt4ijlu6l65@quack3> References: <20231218153553.807799-1-hch@lst.de> <20231218153553.807799-6-hch@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218153553.807799-6-hch@lst.de> X-Spam-Level: Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -0.80 X-Spamd-Result: default: False [-0.80 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.998]; RCPT_COUNT_SEVEN(0.00)[8]; DBL_BLOCKED_OPENRESOLVER(0.00)[lst.de:email,suse.com:email,infradead.org:email,suse.cz:email]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.00)[28.53%] X-Spam-Flag: NO On Mon 18-12-23 16:35:41, Christoph Hellwig wrote: > From: "Matthew Wilcox (Oracle)" > > Signed-off-by: Christoph Hellwig > [hch: split from a larger patch] > Signed-off-by: Matthew Wilcox (Oracle) Sure. Feel free to add: Reviewed-by: Jan Kara Honza > --- > include/linux/writeback.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/writeback.h b/include/linux/writeback.h > index 083387c00f0c8b..833ec38fc3e0c9 100644 > --- a/include/linux/writeback.h > +++ b/include/linux/writeback.h > @@ -364,8 +364,6 @@ bool wb_over_bg_thresh(struct bdi_writeback *wb); > typedef int (*writepage_t)(struct folio *folio, struct writeback_control *wbc, > void *data); > > -void tag_pages_for_writeback(struct address_space *mapping, > - pgoff_t start, pgoff_t end); > int write_cache_pages(struct address_space *mapping, > struct writeback_control *wbc, writepage_t writepage, > void *data); > -- > 2.39.2 > -- Jan Kara SUSE Labs, CR