Received-SPF: pass (google.com: domain of linux-kernel+bounces-8262-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20231221055144.24862-1-rdunlap@infradead.org>
In-Reply-To: <20231221055144.24862-1-rdunlap@infradead.org>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 21 Dec 2023 12:06:48 +0100
Message-ID: <CAJZ5v0j5mcxRMQR3T+tmuL89Y+GjrWYwK_hj+fYikczp=Ey3Fw@mail.gmail.com>
Subject: Re: [PATCH] thermal: cpuidle_cooling: fix kernel-doc warning and a spello
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Amit Daniel Kachhap <amit.kachhap@gmail.com>, 
	Daniel Lezcano <daniel.lezcano@linaro.org>, Viresh Kumar <viresh.kumar@linaro.org>, 
	Lukasz Luba <lukasz.luba@arm.com>, "Rafael J . Wysocki" <rafael@kernel.org>, Zhang Rui <rui.zhang@intel.com>, 
	linux-pm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 21, 2023 at 6:51=E2=80=AFAM Randy Dunlap <rdunlap@infradead.org=
> wrote:
>
> Correct one misuse of kernel-doc notation and one spelling error as
> reported by codespell.
>
> cpuidle_cooling.c:152: warning: cannot understand function prototype: 'st=
ruct thermal_cooling_device_ops cpuidle_cooling_ops =3D '
>
> For the kernel-doc warning, don't use "/**" for a comment on data.
> kernel-doc can be used for structure declarations but not definitions.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Amit Daniel Kachhap <amit.kachhap@gmail.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Lukasz Luba <lukasz.luba@arm.com>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> ---
>  drivers/thermal/cpuidle_cooling.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_coo=
ling.c
> --- a/drivers/thermal/cpuidle_cooling.c
> +++ b/drivers/thermal/cpuidle_cooling.c
> @@ -66,7 +66,7 @@ static unsigned int cpuidle_cooling_runt
>   * @state : a pointer to the state variable to be filled
>   *
>   * The function always returns 100 as the injection ratio. It is
> - * percentile based for consistency accross different platforms.
> + * percentile based for consistency across different platforms.
>   *
>   * Return: The function can not fail, it is always zero
>   */
> @@ -146,7 +146,7 @@ static int cpuidle_cooling_set_cur_state
>         return 0;
>  }
>
> -/**
> +/*
>   * cpuidle_cooling_ops - thermal cooling device ops
>   */
>  static struct thermal_cooling_device_ops cpuidle_cooling_ops =3D {

Applied as 6.8 material, thanks!