Received-SPF: pass (google.com: domain of linux-kernel+bounces-8349-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 21 Dec 2023 13:31:49 +0100
From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>, linux-mm@kvack.org,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Jan Kara <jack@suse.com>, David Howells <dhowells@redhat.com>,
	Brian Foster <bfoster@redhat.com>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/17] writeback: Factor writeback_get_folio() out of
 write_cache_pages()
Message-ID: <20231221123149.liaii5ziwyvb3rmx@quack3>
References: <20231218153553.807799-1-hch@lst.de>
 <20231218153553.807799-14-hch@lst.de>
 <20231221114153.2ktiwixqedsk5adw@quack3>
 <20231221122535.GE17956@lst.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231221122535.GE17956@lst.de>

On Thu 21-12-23 13:25:35, Christoph Hellwig wrote:
> On Thu, Dec 21, 2023 at 12:41:53PM +0100, Jan Kara wrote:
> > But I'd note that the call stack depth of similarly called helper functions
> > (with more to come later in the series) is getting a bit confusing. Maybe
> > we should inline writeback_get_next() into its single caller
> > writeback_get_folio() to reduce confusion a bit...
> 
> I just hacked that up based on the fully applied series and that looks
> good to me.

Yeah, cleanup on top works for me so that you don't have to rebase.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR