Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp120449rdb; Thu, 21 Dec 2023 04:46:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+6GguUfxYkqHJMhj1gqEniTsqKA1vqInb2ayZvKBbZl+ERzJ6K0gMD/1cVAKJtnXzpMp1 X-Received: by 2002:a05:6a20:7f9a:b0:190:35f4:c515 with SMTP id d26-20020a056a207f9a00b0019035f4c515mr1411629pzj.12.1703162805032; Thu, 21 Dec 2023 04:46:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703162805; cv=none; d=google.com; s=arc-20160816; b=GiBxO2IHeSTlvfPa1x+IyzoAWtd14Iv22V6GM6AiwBoUrx9pafdDJJc19Nw14rywBu 3h4CTmmDEAg5XfATrIeVA9SMpbRlZ+aA2POybF/N3CxkqdjCkHyx62dILhVEMn4dps8k EpLk5H5b+NT1kB27ivzPy4OhjSK6n+PbhoaJDWk6xcVzDO7WLalBcutN7Wyny7LkHTzZ 0230EVcpJHbo1u20Z9Ot9hkb6AwMl/AXLSXgTXDPYYbU6JJB0S+VUSWjmw5RLaPxG3LQ brWLXvPcZNqa/VOwqA+Xa9wpcboUY1wUhPEUj7usH8C2ajpYEk1s4c9eU/lkyCsGW/Yv AYog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=trMApxBJHsiL7TNNR7WKp9y2PA/QdJ8KBShic7YDXpQ=; fh=pYdDu9DD54qrsLRm35nTzkDxj2UcmzzCVGHnKe6mJSc=; b=AXez2aRku4KAX6dArOt4vhwZ5rFjlHM4RVte4LO67v8d8c6mk/Yso0PM8TARVu0Yzp re7DbV3nDQOpdQtYWgEER6yo02sIH0zyWniwKnv2mY7ATlaNRK8Jp6hkbN5k/wsQGVlk wAqjWLf8N7tIHux0mPjGMi8hOotAOQ0fcuxXaNCMVTGvaYZEfAe1fsMN5O9LteMKggeD IR0/KIrVcQCKIMKS5XB8gLoCSWZrR7yd8z1XWopPN88877WWX2XtJ1oe1putyzRRgl8E 76qFJC33nVcsSFC/9KzM7OMzSOlBfLmW5dRS7u2dtPxB9vIIDh9cd67TLzqV9INAG+bf Zr1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XZkV1rhn; spf=pass (google.com: domain of linux-kernel+bounces-8364-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8364-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id k16-20020a6568d0000000b005cd7fc2c658si1474458pgt.260.2023.12.21.04.46.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 04:46:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8364-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XZkV1rhn; spf=pass (google.com: domain of linux-kernel+bounces-8364-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8364-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DAF7BB20D83 for ; Thu, 21 Dec 2023 12:46:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BEEDD73179; Thu, 21 Dec 2023 12:46:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XZkV1rhn" X-Original-To: linux-kernel@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0E706EB63 for ; Thu, 21 Dec 2023 12:46:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703162775; x=1734698775; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ueOxSUYUNpzkAbxZtMHnsRkshPGRS5UFRpg4fa2vTlM=; b=XZkV1rhnx+337L80J5RBC+KWavF9/kwpPA97MtqEnwzKUhF+mnbZqasX Zo+QsjxPeqiiY/W66W6f3tfrNAyNsi6j2HUkcduevqxlSvvUgxJkBXIXg X5jNh5mjLEFIzrjPAGCvpgr6QcCC6JVLZTV6BLkkpH4KHoq08cIpWlrsT PxBNELmItX4/6G41z3eaNcmSFwxRq20wvbG3I572e1TZfRcO3M2FBnAxD LXgNPeAbZMzW5OB1rz7g9rKUDDdrsajpLuZiXP0fIVn6myLt0Qxs7hVaA uaQJeygbcDPQiRYv/rC9LiYzCwMHRuZ08vw+aD9DYqCr5dqPw3XMnMgZX A==; X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="394860766" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="394860766" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 04:46:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="867295521" X-IronPort-AV: E=Sophos;i="6.04,293,1695711600"; d="scan'208";a="867295521" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2023 04:46:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rGIRH-00000007qw9-0k6r; Thu, 21 Dec 2023 14:46:11 +0200 Date: Thu, 21 Dec 2023 14:46:10 +0200 From: Andy Shevchenko To: Aleksandrs Vinarskis Cc: hdegoede@redhat.com, lee@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] mfd: intel-lpss: Switch to generalized quirk table Message-ID: References: <20231220073148.19402-1-alex.vinarskis@gmail.com> <20231220205621.8575-1-alex.vinarskis@gmail.com> <20231220205621.8575-2-alex.vinarskis@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Dec 21, 2023 at 02:41:28PM +0200, Andy Shevchenko wrote: > On Wed, Dec 20, 2023 at 09:56:20PM +0100, Aleksandrs Vinarskis wrote: ... > Also I'm not sure about "}, {" style. Lee as the maintainer can clarify > on this. JFYI: $ git grep '^[[:space:]]\+}, {$' -- drivers/mfd/ | wc 250 750 8008 $ git grep '^[[:space:]]\+},$' -- drivers/mfd/ | wc 1898 3796 55230 -- With Best Regards, Andy Shevchenko