Received-SPF: pass (google.com: domain of linux-kernel+bounces-8399-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 21 Dec 2023 13:49:36 +0100
From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jan Kara <jack@suse.cz>, linux-mm@kvack.org,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Jan Kara <jack@suse.com>, David Howells <dhowells@redhat.com>,
	Brian Foster <bfoster@redhat.com>, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/17] writeback: Add for_each_writeback_folio()
Message-ID: <20231221124936.vmm2tjujoy6roxs4@quack3>
References: <20231218153553.807799-1-hch@lst.de>
 <20231218153553.807799-16-hch@lst.de>
 <20231221115149.ke74ddapwb7q6fdz@quack3>
 <20231221122910.GF17956@lst.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231221122910.GF17956@lst.de>

On Thu 21-12-23 13:29:10, Christoph Hellwig wrote:
> On Thu, Dec 21, 2023 at 12:51:49PM +0100, Jan Kara wrote:
> > On Mon 18-12-23 16:35:51, Christoph Hellwig wrote:
> > > From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
> > > 
> > > Wrap up the iterator with a nice bit of syntactic sugar.  Now the
> > > caller doesn't need to know about wbc->err and can just return error,
> > > not knowing that the iterator took care of storing errors correctly.
> > > 
> > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > 
> > Not sure if the trick with 'error' variable isn't a bit too clever for us
> > ;) We'll see how many bugs it will cause in the future...
> 
> It's a bit too much syntactic sugar for my taste, but if we want a magic
> for macro I can't really see a good way around it.  I personally wouldn't

Agreed. The macro is kind of neat but a magic like this tends to bite us in
surprising ways. E.g. if someone breaks out of the loop, things will go
really wrong (missing writeback_finish() call). That would be actually a
good usecase for the cleanup handlers PeterZ has been promoting - we could
make sure writeback_finish() is called whenever we exit the loop block.

> mind a version where the writeback_get_folio moves out of
> writeback_iter_init and the pattern would look more like:
> 
> 	writeback_iter_init(mapping, wbc);
> 	while ((folio = writeback_iter_next(mapping, wbc, folio))) {
> 		wbc->err = <do something>
> 	}
> 
> 	return wbc->err;

That would work for me as well. But I don't feel to strongly about this
either way.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR