Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp127160rdb; Thu, 21 Dec 2023 05:00:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWxBb8yRGnrCHTPNXzHnb053cpBs+/KXMIGNqrn25NP2J1JbOJnQFAU71utifo3j33H1va X-Received: by 2002:a05:622a:1309:b0:423:9887:cd3e with SMTP id v9-20020a05622a130900b004239887cd3emr26366793qtk.32.1703163633706; Thu, 21 Dec 2023 05:00:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703163633; cv=none; d=google.com; s=arc-20160816; b=d6hNqIxGeCR8qYs/g5kGoXopjQ9g7yRjT/r3CH2rf/L2qpJMtaiDmlSq87Ns/hDTgI pl2yhx3uj+5f/lUahzpfLPcYFkGQvIy9Yd3/cZuuPcTk9cCIO7k0OZh1kkDEeOpWD1q5 99uFFN0JOsT6Qu2kVIBhCeY/7VL24eQugGqOHtCVaXFpMgCq+ccLY3qoc0p2nsCwn39f bDA4e2HJdxicmN8gzXhtwk+cgGo5ohCCtMxfc11+LeOCSrYa8h9AgubuVs2YqV42ocRy Nu64DIycY2n2/IDMPacuOmrw0FoP/W4Zgpe8sbwuQ5OztRFLp1yWM0LJ1IrqXYnbL0Rl ul2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=HFlPPfg8cA1xOCP5eOPhA5ZCkRLVOTxfUnQokrhOXT8=; fh=zdMr/JGDhgzK+k7V59P20Xxt8ALvSLVjUpvyDVQGaxM=; b=Ue91PiMAPJIhZoW5LeGFfWch1ulCdfYzqMjVYgRvgDq40q2VFvqG1EpAXGapWSMfE5 BrQIQbBje4X3erSdCZfrYrmy4YhGHFcIIkuN0UwmoOjqC1ZgI92KSDXVpop/3ei4lTIo 7qn+7DgI1dQ3/EH4ont8iqkJ4kKGqWPlNr5tGHmEro3xPGxDYXDTET6blmu88IcV3Q2/ YIkfiZyHfudZ4NGJOeFf5IHh6tr+RQHQlNTNy6vYGw6LgcfxCt3JwaxbLGX5k5SsmZQY 5m/0nmUls4QSk2b7d6P5QTUh9clWXZlT1kH+iFRWqHhriMSs0ox0k7ELRMjC/0Wzf8OM sO7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZCslwi3G; spf=pass (google.com: domain of linux-kernel+bounces-8411-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8411-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id x19-20020ac85f13000000b00425497dcb86si2089159qta.387.2023.12.21.05.00.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 05:00:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8411-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZCslwi3G; spf=pass (google.com: domain of linux-kernel+bounces-8411-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8411-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 74B851C22747 for ; Thu, 21 Dec 2023 13:00:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 055DA7997A; Thu, 21 Dec 2023 12:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZCslwi3G" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2899F7995C; Thu, 21 Dec 2023 12:55:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EE2EC433C8; Thu, 21 Dec 2023 12:55:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703163337; bh=7NxpxM1STCMZ8Ns3Axc00mUiFhhRBcEYLIvZ8mqgJ+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZCslwi3GvMMaQxEaTeZGHOEFbcCU6AuRFQJ6RYpGW7hpi4KDBbZV1pstpAf7wWHPY BM93nHNrkUIbxrxzLhthSeAmQX0xtBS2lbwxbrZ6pUiOF9RWzStLIwtlXkgPrQ5rWf IKElmG672O0pocCtANJbDKH4LRMUqItWQTD0maTOUxwstEz086HmwJAJi/i+9HHyqV tUy0+MFsRc8gfK8RXjhUY7fz6qq5FXTYINDrvPWchVcIOCgP+nVrFe00yWDB/LRfZQ 9tyCeM9FEmAIpXDsDCUnQ1DbdUAdayojwaveqMrlTN92+AvhW8q6BO2Rr8jeEOHvVK UeKaRuO9sAaFA== Date: Thu, 21 Dec 2023 12:55:31 +0000 From: Mark Brown To: Xingyu Wu Cc: Liam Girdwood , Claudiu Beznea , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Walker Chen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org Subject: Re: [PATCH v1 2/2] ASoC: starfive: Add drivers of Cadence Multi-Channel I2S Controller Message-ID: <861f9b28-863d-48b0-8491-add4a286597e@sirena.org.uk> References: <20231221033223.73201-1-xingyu.wu@starfivetech.com> <20231221033223.73201-3-xingyu.wu@starfivetech.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qiI6QTJLu38XlrMO" Content-Disposition: inline In-Reply-To: <20231221033223.73201-3-xingyu.wu@starfivetech.com> X-Cookie: Results are not typical. --qiI6QTJLu38XlrMO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 21, 2023 at 11:32:23AM +0800, Xingyu Wu wrote: > sound/soc/starfive/cdns-jh8100-i2s-pcm.c | 262 ++++++++ > sound/soc/starfive/cdns-jh8100-i2s.c | 727 +++++++++++++++++++++++ > sound/soc/starfive/cdns-jh8100-i2s.h | 171 ++++++ If this is a Cadence IP why is the entire driver SoC specific? --qiI6QTJLu38XlrMO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWENcMACgkQJNaLcl1U h9DmxQf/VKWNR8MkKD1nBaJ7Yag16lGPPoUKjVEA2U9WJHxwlAJ3QXQ5lsrIBeg4 yhP0BWeL9nEb5kF6zN02LHhXrsRxU7li5HUT0hS0CArT8uQjR/g2DEr5iIfNiBmb +6gKFGsbitTZCdp4VYcmNjUYGOz/5Zl4ZzmXYxBtiZLoCaJgcSLEDJI6BOK8vNJb /4fyTPW81F5T1Ww2lW9xSEW4sPaQCDYR1+SDNLd+tMZodWgOwLZ+QTUvdGEisUbk QvjM9CcrWIs79/sCqHq052zO4bWnEL4w1lTcz+oojP8kEinpg9O7nQl3TMkh2OeV ep3TrAzJvm3x176m5cODPhAJLYVlbg== =xQrw -----END PGP SIGNATURE----- --qiI6QTJLu38XlrMO--