Received-SPF: pass (google.com: domain of linux-kernel+bounces-8545-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 21 Dec 2023 13:58:33 +0000
From: Mark Brown <broonie@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Xingyu Wu <xingyu.wu@starfivetech.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Claudiu Beznea <Claudiu.Beznea@microchip.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	Walker Chen <walker.chen@starfivetech.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: ASoC: Add Cadence I2S controller for
 StarFive JH8100 SoC
Message-ID: <f1210b31-25af-4cbd-b73e-2a72aa6c41bf@sirena.org.uk>
References: <20231221033223.73201-1-xingyu.wu@starfivetech.com>
 <20231221033223.73201-2-xingyu.wu@starfivetech.com>
 <20231221-saddlebag-tricolor-d02a17d66795@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Je10eHLduGuAy2yb"
Content-Disposition: inline
In-Reply-To: <20231221-saddlebag-tricolor-d02a17d66795@spud>


--Je10eHLduGuAy2yb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Dec 21, 2023 at 01:53:00PM +0000, Conor Dooley wrote:
> On Thu, Dec 21, 2023 at 11:32:22AM +0800, Xingyu Wu wrote:

> > +  cdns,i2s-max-channels:
> > +    description: |
> > +      Number of I2S max stereo channels supported by the hardware.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    minimum: 1
> > +    maximum: 8

> Mark, is there no common property for this kind of thing? That said,
> there's one device here so the number is known at present.
> Another note, this property is not required, so it should have a
> default.

I wouldn't expect this to be a property in the first place, as currently
presented this is specific to a single instance of the IP in a single
SoC.  In general this is something that is obvious from the compatible
and doesn't need a property, it's only plausibly useful for Cadence and
Designware which is a very short list of vendors.

--Je10eHLduGuAy2yb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWERIkACgkQJNaLcl1U
h9BcGQgAheM9EAPMjgBTsuBAaQIPvCR4hci5mQpv4BAqe9xyf3i1kt8jh0saB1Ml
+ziuaF1AQrBoBkJSd3RSSfTgeOCplifgqtoVthIhI4LUyIYK13WCbvhVG92shYYv
ASQfO03KLvk559mAIHA/oW62eF/YzEpTHJsorSHUHeWoqAltTitK/51n8QAHfeJP
sukuTUG9MgYX+t5mA+qVKl6NRLvcFaw9hosbXSqaTXPwSAHDn/8LHMiTcsFu3BBE
XvmoBdRS0hYA6Ek5er3o22Td8pNjS9/uWyO/ZYYdURpPx6/foStm12WLQcsneEEN
B8egzLRTfz4+EzLBIJw5q1Um04byyg==
=bQAA
-----END PGP SIGNATURE-----

--Je10eHLduGuAy2yb--