Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp190848rdb; Thu, 21 Dec 2023 06:41:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHSO9DMs1FYn3q6bMRt0y+5qG3aeC/GUTkFUKJhLsLJFhZupzJ7JtIZ0R79Qz8HTyOLsfdS X-Received: by 2002:aa7:8d43:0:b0:6d9:415c:5591 with SMTP id s3-20020aa78d43000000b006d9415c5591mr2681721pfe.3.1703169663020; Thu, 21 Dec 2023 06:41:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703169663; cv=none; d=google.com; s=arc-20160816; b=yEWBB561iqmIIwxIcJnlVgtiAw66NovNIlqVXcif+9PENlwzi+p28To+6XpOOo6UdF wtxSDkRJQ1p/dWP8sdtBSqyhquA+odacxYEIFNWqxdL7xLOKAKM19c1vZUix6yp/GBjn SJNHdeRmA7hplZ6KVLn4a6uPQdcEoGm6yi0N5JZGL5YE4nBg4coWGPRj4NkqTKJJB3qj tnRkYs3IAwODDqt87Yp9Mypq1/NoZeOxTcWaDLXr1S7CZy5k7td25c3PBski5KgUv61r esRaUNLQ9fQdZD9shbb9hYpYW35AOr6ObfWsiRC2qFdej9zIO6aVD0A/Ggh+UcjXZ5Si Wi2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=aEyhzKiAGUtdwUEctDvCtbfA4or0lnGt3RiG4jCeWzw=; fh=shW9TcfXb0IK08iauxBt/2uU45gyWVfR4XQSkISyaWs=; b=Rv5bRfrF1HKKYfwEPtbroK6ku720C9RqWoaoRUsYIb3PeNTCe+P9gZj+nRnfHwxoxy Ws9LIpyqf8u58qZp6nz20ogbTwtDdOeHXycbmnEffTQEveuQdHg6BocQ5kr1wlMAdlVJ OFjjBg3MOOtl8wlWR4mEQvIl/2dR0bOXy0Mm+cOeuDWYsT2j7wjOtNyz0qy0rRKgYzxR SCnYakfIZ1PezUyFIFz1hFujyfvG9YE27y1i02HYwC6onuxg8I74QbTWDKqowfw62bbR oTM5Q6F6tKL/m4F/NQjL8mb/Cf9/bgNk2iETv64R8k0v4q9wzDg3dBwfOyjiN026D9rl WZgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jTINVrUo; spf=pass (google.com: domain of linux-kernel+bounces-8580-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8580-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id bn14-20020a056a02030e00b005bd70a177a3si1722140pgb.876.2023.12.21.06.41.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 06:41:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8580-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jTINVrUo; spf=pass (google.com: domain of linux-kernel+bounces-8580-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8580-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 892C928593F for ; Thu, 21 Dec 2023 14:41:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F9BF360A5; Thu, 21 Dec 2023 14:40:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jTINVrUo" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 893B71D6A9; Thu, 21 Dec 2023 14:40:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6A74C433C9; Thu, 21 Dec 2023 14:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703169652; bh=ri5KEEnsiQYrzG321GXsHIE5EoVCZaliNnZtZXHZhxY=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=jTINVrUoxf0xMKKDKtGckqKXUM6nl+CkqezQpPY3seXQlzd/MDpf4SYcNsQmaEBAL caKLw4FjqDCaxl2x4U2VbAVoyQDlo7q8E3JCAzl8TIcSQNwhI8txmuzrcbJ6AnwFKE 6BP0IUy/vqT015XN/BnrQdBiGPSzIRuc3qv/fehgvGpsoLFy/tHNp35rP6qgwv58fZ XmGTnNV6vYPDlh7KP3aPCDo/zAnytA77aVVzm9sLr0Sjv/2NjiSNcVbM9//85exDdi 4P9v6RNLAMTpiYkAgfTPUBYdOj7JRmih5kCcasYLkhLTE/U4wEaj+/PST1o4OkdyJ0 PxaqfSZacuXxQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH wireless-next 01/11] wifi: rtlwifi: add calculate_bit_shift() From: Kalle Valo In-Reply-To: <20231219065739.1895666-2-suhui@nfschina.com> References: <20231219065739.1895666-2-suhui@nfschina.com> To: Su Hui Cc: pkshih@realtek.com, Su Hui , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170316964846.1243375.3938053797242635689.kvalo@kernel.org> Date: Thu, 21 Dec 2023 14:40:50 +0000 (UTC) Su Hui wrote: > There are many same functions like _rtl88e_phy_calculate_bit_shift(), > _rtl92c_phy_calculate_bit_shift() and so on. And these functions can > cause undefined bitwise shift behavior. Add calculate_bit_shift() to > replace them and fix undefined behavior in subsequent patches. > > Signed-off-by: Su Hui > Acked-by: Ping-Ke Shih 11 patches applied to wireless-next.git, thanks. 52221dfddbbf wifi: rtlwifi: add calculate_bit_shift() acefef7a7e7a wifi: rtlwifi: rtl8821ae: phy: using calculate_bit_shift() 969bc926f04b wifi: rtlwifi: rtl8188ee: phy: using calculate_bit_shift() 1dedc3a6699d wifi: rtlwifi: rtl8192c: using calculate_bit_shift() f4088c8fcbab wifi: rtlwifi: rtl8192cu: using calculate_bit_shift() 3d03e8231031 wifi: rtlwifi: rtl8192ce: using calculate_bit_shift() b8b2baad2e65 wifi: rtlwifi: rtl8192de: using calculate_bit_shift() 63526897fc0d wifi: rtlwifi: rtl8192ee: using calculate_bit_shift() ac32b9317063 wifi: rtlwifi: rtl8192se: using calculate_bit_shift() 98d9c7731dbb wifi: rtlwifi: rtl8723_common: using calculate_bit_shift() 5c16618bc06a wifi: rtlwifi: rtl8723{be,ae}: using calculate_bit_shift() -- https://patchwork.kernel.org/project/linux-wireless/patch/20231219065739.1895666-2-suhui@nfschina.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches