Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp197706rdb; Thu, 21 Dec 2023 06:53:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHX6SoB0bJzDC3raR7K03iUDtJplbmseFwSEq5DZfLVoeJVmW5cwQjGDyDD4cxhm56jIKXp X-Received: by 2002:a17:907:a197:b0:a22:e827:fb7b with SMTP id om23-20020a170907a19700b00a22e827fb7bmr860195ejc.23.1703170433022; Thu, 21 Dec 2023 06:53:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703170433; cv=none; d=google.com; s=arc-20160816; b=pkcuwTdwWYSwU6PYJfjMqZXQqOGA5F03J6RhcyABSuSjlUrQGO7h5IjtTiXWybrvUI KTiGGpwS4cp/PY1s2cOdmW+BdEzOM7Bo3bfG9lyLx9gJpT5s59nwwD840BMv03MAn6eB MgmD+a/V6yjdkVEWvsEBsr5wOlLDAzEfu0+gGAmB/xU7BI5dEmX690RkCV3+v8ZajQzr 8zuObrb3o0ZIU71KB0IFtqAp3tO7KLz1iECr2LznWoX1E1o+Uf8rT3Zu5lg2GW03Bm+C +crp5Koq6roYYs0Xcu0IiVZcD8qH18HzHXsys7UC+NvkL6j1L1oANEyHbSER3cJ7knBf o8Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:dkim-signature:message-id; bh=9DWCbTtactyPz1Ws+U8aJ3Iw5YuEjx40PPU3oVvJZrA=; fh=Faqqo5FCrNJlgJus6y7odaXTkoXWw1VVK1ZjdsjuRmw=; b=nQa4BlCYJlS7YE5DS4lfPe35uRGKPQpFVUNI3DpfHuOd7TlGubI+PryS2gKiZDX5bQ o/XRMPfnC2EiWlS3Sxea61CTJ7Yc+0nKT2iE7gYvI6L2EKazISTtnhwWu0gKwUOXK1av sFmo3chtMLbPFS0S2PLdulVPysJBllo7Z3o5dAtH38XiMgk9/B/MwhlRJ8PPKThBrYuq JKyi4VNAf8IuUrpYq4pP2aygoMnU8SdkHDgwz6hHpFWHgMowq5oSuimSxi5m/Abm8mZQ H4ZgOqk+fI7SmzFdRcbLf96NXQzgqvAapKqb/xS/PQ18ly6hTBlSUW0FMvHfsMovklOR AHjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=xCoT8n1O; spf=pass (google.com: domain of linux-kernel+bounces-8592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8592-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id q16-20020a170906145000b00a26a9598e8esi499867ejc.9.2023.12.21.06.53.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 06:53:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=xCoT8n1O; spf=pass (google.com: domain of linux-kernel+bounces-8592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8592-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C07551F23559 for ; Thu, 21 Dec 2023 14:53:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 13424360AD; Thu, 21 Dec 2023 14:53:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="xCoT8n1O" X-Original-To: linux-kernel@vger.kernel.org Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB42536086 for ; Thu, 21 Dec 2023 14:53:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1703170421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9DWCbTtactyPz1Ws+U8aJ3Iw5YuEjx40PPU3oVvJZrA=; b=xCoT8n1ObOYoSEUUPhIGGLeX4YPTL/MN07zCk5cwewehpLQMiprAiSqmiJUrYxg+tvgz1x cttuLlvMIbfbw1qezKnOW6X8vD8SyK+owcw+MwgYR9nJveI3rxseT2wm1g3kGs0obJobCJ teGbrbyyerrrO2NcVfKtF1jkHyqU5Lc= Date: Thu, 21 Dec 2023 22:53:26 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [v5,43/44] drm/sun4i: hdmi: Consolidate atomic_check and mode_valid Content-Language: en-US To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Emma Anholt , Jonathan Corbet , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans Verkuil , linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org References: <20231207-kms-hdmi-connector-state-v5-43-6538e19d634d@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20231207-kms-hdmi-connector-state-v5-43-6538e19d634d@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Hi, On 2023/12/7 23:50, Maxime Ripard wrote: > atomic_check and mode_valid do not check for the same things which can > lead to surprising result if the userspace commits a mode that didn't go > through mode_valid. Let's merge the two implementations into a function > called by both. > > Signed-off-by: Maxime Ripard Acked-by: Sui Jingfeng