Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp217433rdb; Thu, 21 Dec 2023 07:19:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHTsF1AkMq0rq9CGnArTMhohcZPI4+oYs+eeSqPcuSiB11vihJa0VN1RvcHVnOBJtR7wBvb X-Received: by 2002:a50:f690:0:b0:554:4277:b67d with SMTP id d16-20020a50f690000000b005544277b67dmr55060edn.21.1703171993042; Thu, 21 Dec 2023 07:19:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703171993; cv=none; d=google.com; s=arc-20160816; b=sTtqp+2ugyJDpSVby3y5RKm+o6b3OZR7+keU/6zTtKSd5E+VR7F6C6jcylm3vWYV9l dUgrIC34MsdrA4UDt9bBDHUAoXyMxrX5mY7o3UfcxgfOZZbSU26SWdeb4NyLjPa6Y6bq tm3x6wyy7nwUc/q1CtRj4+Pz1jJ/6u1V46/G4ZxtsdNBUIwymKDn6kLPzGaLzXf0EMbk dvoqFhhVlej1u5cF9ohwRI6wghdZa1jfBboJocNn5qrpCCs+z0NFQnPY8nsRcMjGTrlx HBKf1j5tn/lV1dbCSNCP9GKnqd7/GFS1yOEeptEKzy9mz2to0L+U0rPM3k0l2k1DoBi9 MVkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9rSYUPWFd3klvqcN9tsQ5q3ttNMC9wGhszoiFZQdcno=; fh=gOsf/C9oGsx8mW0RFdSWIOnFVVE9a2kx3u0KdziicVw=; b=Ii6p/KqmHyoTVV96HsmhV89v9xOGh0otpR86hESDnwP6EIVJ8JOaReI+owiaMCVjs2 DN6jxVNzxgLlyJlNKeEnqli2y7F3Yc1JinYUmRbicOkMEE0VxmQrFX18YfHGkxruodaB AhkuV8IHhKACU3LWwfgjQFYoQvmXkmWPpZx2NGDV72t5hAlFuv1DEOHjBNKJCYK8lfrI yu1Fn2lHpGz+PX+FNxHuPCsnaUMk02g2XGEecnI46TtAXpSRH1CJ7xpyAAAZLt4bNqnn 6vInK8DzNnYLmuBQ//u5BpqRYKY+P37lgs3yAt8ojEdBsHRIOyh30USRcouGLv+VfhAZ p4ag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hik6TYts; spf=pass (google.com: domain of linux-kernel+bounces-8634-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8634-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id m21-20020a50d7d5000000b00550e4e75bf5si939776edj.34.2023.12.21.07.19.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 07:19:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8634-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hik6TYts; spf=pass (google.com: domain of linux-kernel+bounces-8634-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8634-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C8D391F24927 for ; Thu, 21 Dec 2023 15:19:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 86B28539E2; Thu, 21 Dec 2023 15:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hik6TYts" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF5D44B13B for ; Thu, 21 Dec 2023 15:19:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC7DBC433C9; Thu, 21 Dec 2023 15:19:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703171984; bh=zRI4Rvo9WIuXe2q5wsHOUMVgxO0MDYOlConkXgZxsnM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hik6TYtsssdYrcLPuMSZUOK0NE4Vh0G4KrgupuFFJKJ22egvWhh1NYBDGGnZVKupR zyA3RgtULU7msHs1fDFGQ/70uT/OztnnyQ9U1VftKMAh/Yr2Kk86Eg43iUHDcIXJmz n7DIPZyfiO6W9ghMaYKE8FINpTAAFXeedIx5B0XrWN+vb1Uk1Cmd25HGyzJnhtMiTF N+xzurPGBrVKacTwvse6zyW2J5TG6A8CnBSVpJRlKwYR+Nuj8jN9jdyKkiYgtVZJxq 8kg3o/0QZ4dHn97VBtsVGMghmLL/thkrbYwmFKeE9ggQ8HwsTuEIEIzly3obcrfm9k ccG1U2XUJ4p2w== Date: Thu, 21 Dec 2023 16:19:41 +0100 From: Frederic Weisbecker To: Peng Liu Cc: tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, liupeng17@lenovo.com Subject: Re: [PATCH v3 1/2] tick/nohz: Remove duplicate between tick_nohz_switch_to_nohz() and tick_setup_sched_timer() Message-ID: References: <20231128092354.160263-1-pngliu@hotmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Le Wed, Nov 29, 2023 at 06:35:18PM +0800, Peng Liu a ?crit : > From: Peng Liu > > The ts->sched_timer initialization work of tick_nohz_switch_to_nohz() > is almost the same as that of tick_setup_sched_timer(), so adjust the > latter to get it reused by tick_nohz_switch_to_nohz(). > > This also makes low-res mode sched_timer benefit from the tick skew > boot option. > > Signed-off-by: Peng Liu Very nice! Thank you! I'm queuing those two patches along with further cleanups.