Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp222267rdb; Thu, 21 Dec 2023 07:27:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4fyVV3/FBKa4+YWp0WI6c8SaO1k7eOVFX+UxR/GMPt+DD1iFeSiUdfvDyOiGNme8edDLS X-Received: by 2002:a05:6512:3b92:b0:50e:4b7e:37aa with SMTP id g18-20020a0565123b9200b0050e4b7e37aamr3063485lfv.28.1703172463824; Thu, 21 Dec 2023 07:27:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703172463; cv=none; d=google.com; s=arc-20160816; b=vc3YEKSuCerc+VhLq9+blEcd0JLK/1syZwia9/bC8XKhfGbiVbi6Y10MYcHyFuRAx4 Oa2vGQe6pL67wVepleG7SYnas1vvFOEIHC5d01aAHWTKSvKOmikMz/hJABfExTkcGTBO G2nSyyc9lrD5sRotzQLiKk9mRSkLTyx76RnRv0eSc0oLTD8alA+AUexiUip6n174JUIR Bh3a6i/sQKrmZGWTeU971OfiDAlHbUn/3owy04N5JFHTHCcIAujzsP2X407doX51vwhh 7hZ6iGp5D2AYBESTLyReTH7xT6hMz2ATryc2Ksr3Ts8fxKkYIYitpMqIiXvkkRW0+pim bF9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BTobk5r2Ir/Ig9wwEwNL5FNgaVfc1rr3z5z2fFWa61w=; fh=ocjhkwLP4czt4TLIIu498djIkJTI41WLB38MZBhzhOM=; b=xhm8vS7+yIiir5wBPAYwnEY5xeYt6Z0C/snady80JXYcB4mQCkH9vgzg0qZrr1Mdsm danFnpu3eCbChfR92ZOwdA/kgcjzA3McdJZ/6t/+pHyNqAfFeYkgStN74JZ8FPYj54Cy 4D1hUmrtE/j50lTyQqlI+46cEyji254KZm9sIPgiQDQzthYeflArh/vE+ZI8bcDr/tJd xqmxiGlSL0bdfm59qy5II0hm8cMIb2gOAt0ad5RQAKr57Emvy3wfP7mO5FpT1om0Ipz+ V3dnztI+9wXUQCxix6GMAjiMdZMOJ5kx3aLqpr0a/OZdNh6B8J4tcrb5ouI8kF7k2skU bG2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="bp/howPs"; spf=pass (google.com: domain of linux-kernel+bounces-8657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8657-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id n21-20020a170906119500b00a2349f5f97csi938310eja.648.2023.12.21.07.27.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 07:27:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="bp/howPs"; spf=pass (google.com: domain of linux-kernel+bounces-8657-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8657-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8E8DB1F2525B for ; Thu, 21 Dec 2023 15:27:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A636F59917; Thu, 21 Dec 2023 15:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bp/howPs" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8B3958229; Thu, 21 Dec 2023 15:25:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE8F8C433C8; Thu, 21 Dec 2023 15:25:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703172359; bh=bOn20U9lRPRlbVYe+5E72j85AFisfz3+P+95H5MAc04=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bp/howPs7iub2Al7Z8sBtYS3cyJPnK2yVP+txsU/o6SIivy282qZpAPrDGcOphc72 16ak6461Hb3ipSsrOAjaf0XT+43Ehjo2gFPAF2rRaszCPJJt29Pr5e5Lg/0a9SrE/9 X51lMzhzuIdG7ju29EbQbyo4l2qE2mvOaCBXk6/qjeTguM3BRhHp4KSIZWPCxNb9lG /fk1XgqbfLz0Scyae+akKN8YM3fjBCxQanDDhMiqXy9QPM0rUKEbQoz0W1/xuNsOsR N0+iIwdY4A640o4oHqjmmAuhPqjCHFFRjXmwmfN74omuD7QecQvUiZILLw5yxCk5qH VKchfyUFwZ8LQ== Date: Thu, 21 Dec 2023 15:25:53 +0000 From: Lee Jones To: Andre Przywara Cc: fuyao , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Maxime Ripard , maijianzhang Subject: Re: [PATCH RESEND] iio: adc: sun4i-gpadc-iio: adaptation interrupt number Message-ID: <20231221152553.GM10102@google.com> References: <20231220115412.65bbc8c7@donnerap.manchester.arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231220115412.65bbc8c7@donnerap.manchester.arm.com> On Wed, 20 Dec 2023, Andre Przywara wrote: > On Wed, 20 Dec 2023 15:23:17 +0800 > fuyao wrote: > > Hi, > > > __platform_get_irq_byname determinies whether the interrupt > > number is 0 and returns EINVAL. > > can you please say what this fixes, exactly? Is something not working at > the moment? Can you please provide parts of the error message? > > And maybe expand the explanation a bit more? For instance mention that the > identifiers are used as IRQ resource numbers, where 0 is treated specially. > > Cheers, > Andre > > > > > Signed-off-by: fuyao You have to use your full real name as well. > > Acked-by: Jernej Skrabec > > --- > > include/linux/mfd/sun4i-gpadc.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h > > index ea0ccf33a459..021f820f9d52 100644 > > --- a/include/linux/mfd/sun4i-gpadc.h > > +++ b/include/linux/mfd/sun4i-gpadc.h > > @@ -81,8 +81,8 @@ > > #define SUN4I_GPADC_TEMP_DATA 0x20 > > #define SUN4I_GPADC_DATA 0x24 > > > > -#define SUN4I_GPADC_IRQ_FIFO_DATA 0 > > -#define SUN4I_GPADC_IRQ_TEMP_DATA 1 > > +#define SUN4I_GPADC_IRQ_FIFO_DATA 1 > > +#define SUN4I_GPADC_IRQ_TEMP_DATA 2 > > > > /* 10s delay before suspending the IP */ > > #define SUN4I_GPADC_AUTOSUSPEND_DELAY 10000 > -- Lee Jones [李琼斯]