Received-SPF: pass (google.com: domain of linux-kernel+bounces-8715-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 21 Dec 2023 17:54:35 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: broonie@kernel.org, conor+dt@kernel.org, krzysztof.kozlowski@linaro.org,
	robh+dt@kernel.org, kevin-lu@ti.com, baojun.xu@ti.com,
	devicetree@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz,
	pierre-louis.bossart@linux.intel.com, 13916275206@139.com,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	liam.r.girdwood@intel.com, soyer@irl.hu, tiwai@suse.de,
	peeyush@ti.com, navada@ti.com
Subject: Re: [PATCH v2 4/5] ASoC: tas2781: Add tas2563 into driver
Message-ID: <ZYRfu7RjUNpLZCSB@smile.fi.intel.com>
References: <20231221101346.429-1-shenghao-ding@ti.com>
 <20231221101346.429-4-shenghao-ding@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231221101346.429-4-shenghao-ding@ti.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Dec 21, 2023 at 06:13:44PM +0800, Shenghao Ding wrote:
> Add tas2563 to better support dsp mode.

DSP

...

> +// The TAS2781/TAS2563 driver implements a flexible and configurable

Ordered?

...

> +// TAS2781/TAS2563 chips.

Ditto.

...

>  static const struct i2c_device_id tasdevice_id[] = {
>  	{ "tas2781", TAS2781 },
> +	{ "tas2563", TAS2563 },

Ditto

>  	{}
>  };

...

>  static const struct of_device_id tasdevice_of_match[] = {
>  	{ .compatible = "ti,tas2781" },
> +	{ .compatible = "ti,tas2563" },

Ditto.

>  	{},
>  };

-- 
With Best Regards,
Andy Shevchenko