Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp248811rdb; Thu, 21 Dec 2023 08:08:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFKG65MVAOUbEFVp4muDLA7NroEck1px9UaaBYvoH7RvtZAMVOF2w0j7JqbDbeJi74etWVZ X-Received: by 2002:a05:6a20:2593:b0:194:f631:e31a with SMTP id k19-20020a056a20259300b00194f631e31amr1217458pzd.9.1703174879781; Thu, 21 Dec 2023 08:07:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703174879; cv=none; d=google.com; s=arc-20160816; b=nIh1dk61idowHIi5yh/dyw2urXIP3ln6rKPcjYlEne1aF6k/KvhWm/Dq5a+7Ahd0CF YXewPPffu/0aMC31nTABVUf2EnfzvErmItjpRy+rwd7ZUTiCvi4mXQj6U379svMQfDf8 wqjh65N/BNAeLY0x2P9bDutb+XhZiC1MaRIaq8ICPmleruZ7Jeda59j9pRAPBaS3fFHf Z6rWsrGZ8GI6HYEiZnDPvGxJeUo7oRNoEuymfUV9sVBGu3CCq+9WcDNK12oHb+QSh32m PYOpxh31HlMts3TrtMwTEvK7SKQCelcnMBWpzE/4Ke+Ft2BUVB3xqtnDVTuJ5Wyuaqpz Lkow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=RW+aituytgnCG5vsvH8iyQf8oNlLjNY2vCWaBlZ39k8=; fh=SV4spfG/gmrimUrwc6LSX6hcsfRy7Y5GkrCgwseXSIs=; b=VxyJqk8Rq25IyEl8FLag81tF9q0AcTfOSbfI3bmzpL4cNVo0UTRVpJ/SiLRdq4H7Pi mh6JIRBXI1xqB3b7vjy1U6YaFJ4q2QwTmHQGUE9T1FcuY5G14xULBlIDV3P2XX1ifF4B 8M9bPhFrkU9bGHwLZUcZoOlakBUNFrhJFtgQ6wAvLdVjHZfFYpgjMofJQ+Da4AIZrI5G YdBr7/qf9fwtD3cn+7r33dI5kXNNlzZ0wLmdZtGuyvWHS0I0Ex28GS1k0T6Ae89cVmPz wmIoyVlu/cntYc0bywxEFPCdrwCBIItHVlRsObicso5upA/TgRviODxlu8dT7weDHmGO lvCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="bHfuF/Xq"; spf=pass (google.com: domain of linux-kernel+bounces-8722-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8722-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d21-20020a637355000000b005cd6062a50esi1766380pgn.823.2023.12.21.08.07.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 08:07:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8722-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="bHfuF/Xq"; spf=pass (google.com: domain of linux-kernel+bounces-8722-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8722-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AB1DBB22A7D for ; Thu, 21 Dec 2023 16:07:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0EBB255E5B; Thu, 21 Dec 2023 16:07:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bHfuF/Xq" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBB8C53A17 for ; Thu, 21 Dec 2023 16:07:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-50e51a7545dso1178438e87.2 for ; Thu, 21 Dec 2023 08:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703174830; x=1703779630; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RW+aituytgnCG5vsvH8iyQf8oNlLjNY2vCWaBlZ39k8=; b=bHfuF/Xq/3RI0bAPRcGF7t0hLzt5Kt5G/J5QV41Jiz9jKlMy5mquPnIpfcjeF4qC7G DveI2e5tNcxHUP8PHQuTYqRxcOxyjfnsE7WgU3h2xe63gDHVcEY5YKWjSCWF7ETT54Cm loi4ZFkBrJbi0cORv6B7JFubpvpsVl43gP/xE8dSd+mHD6RMfwpfGwjXm069s+Vd4iMp 7VpAk5sEMXeM3mOSA/2DQ3oMvRAgDTQYqIuTpVkOL0w4ZEhE+jalmmnk6m8xeVEHOc5M 7ftQ3e2Qm/JnFYEe9Le8k1vJ7iy+cKfYHyNnKiT45fZx4z5SV5002efkRJdg+rJFFSCv uWlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703174830; x=1703779630; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RW+aituytgnCG5vsvH8iyQf8oNlLjNY2vCWaBlZ39k8=; b=WywU0yN9kzrV73D7O4ueloiXAeQMwPg9EjXtpT1chLnW2pdr3NWlYFn5vdKxITbTbB gY/K7nfS4Lo41g7TVfv9CFJleHjZHpSrET9HC6Xyd3vORnV5RqMUYunv5NotYqbmRz8g +/glnR5hPOIeFEQeHKTTcUJhAw/3enx0ogXshf2D7GOPL9NjX0V1k2cniHooDYjQBGi/ W6TnJROZQrRbn26G3xji9gLe5hUMq3RFaHSUGHdNtUN020RgL994++lNTxNjnM/LZjv/ 9vJUFcsqgbSEfEovJwMr92LEGx/bCyl/O/xia9YHIvcOk9DF9Q1NBX9HtoBSUykG+eNu BqFA== X-Gm-Message-State: AOJu0YzpB9M4j0PlufRnyLnhbLupQiWcHsG7Ih2QfNYe8wA8vX3vWbp/ bO6aTv23XFjLXR6uCAdcHt1dsA== X-Received: by 2002:a05:6512:1329:b0:50d:f93b:97a9 with SMTP id x41-20020a056512132900b0050df93b97a9mr2923505lfu.1.1703174829787; Thu, 21 Dec 2023 08:07:09 -0800 (PST) Received: from [192.168.0.22] ([78.10.206.178]) by smtp.gmail.com with ESMTPSA id wl1-20020a170907310100b00a233515c39esm1096071ejb.67.2023.12.21.08.07.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Dec 2023 08:07:09 -0800 (PST) Message-ID: <2e74c513-40de-41b7-ba86-c5b345344ce4@linaro.org> Date: Thu, 21 Dec 2023 17:07:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: ASoC: Add Cadence I2S controller for StarFive JH8100 SoC Content-Language: en-US To: Xingyu Wu , Liam Girdwood , Mark Brown , Claudiu Beznea , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Walker Chen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org References: <20231221033223.73201-1-xingyu.wu@starfivetech.com> <20231221033223.73201-2-xingyu.wu@starfivetech.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231221033223.73201-2-xingyu.wu@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/12/2023 04:32, Xingyu Wu wrote: > + dma-names: > + items: > + - const: tx > + - const: rx > + minItems: 1 > + > + cdns,i2s-max-channels: Custom properties after generic, so after sound-dai-cells. The coding style now mentions this. > + description: | > + Number of I2S max stereo channels supported by the hardware. > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 8 > + > + "#sound-dai-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + > +oneOf: > + - required: > + - dmas > + - dma-names > + - required: > + - interrupts > + > +unevaluatedProperties: false This is not correct without allOf: which should point you to missing $ref to dai-common. Best regards, Krzysztof