Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp292693rdb; Thu, 21 Dec 2023 09:13:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0Kt7tBEujGYoV9G2fG6YQe/9nqJiyDN2LXjYltgB/72VHuLWXP8vPAzPvKsYJF/6hwZCI X-Received: by 2002:aa7:8d8d:0:b0:6d8:9220:758a with SMTP id i13-20020aa78d8d000000b006d89220758amr5531682pfr.69.1703178813238; Thu, 21 Dec 2023 09:13:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703178813; cv=none; d=google.com; s=arc-20160816; b=lEJ+OFyGjogkW6JF/zWvf2NmEqXZEAttROMLlgMeHCmhXYI8UkAjH0mrQIe3uUTGKi frSfEbZjI7Szc7aS48PD52DuLJ364awGA0esLNEuay+Ig5Cg0gqyYkbaQCTttAVVr7uV gO+9P1VHM/8johqawak9iyPvlGe7WEFwiodqw0mrMSy84kRGE4086326eO17bgdqpqzI M9JNu4JIC0MsqWGTN/76lboAefJnDhoBePGHWZED2c1bzmpmikndh4vLv0K1Db3z/jZu yEOuapnPo29/lZePjZMAN6lxa3+r1NIZHtVAIoPauMho5mC0SlYwjiI2uGbGNrEUTasV CkZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=pZQU9AvQ4Xf5jG6lVCaCsvJ4r7eRyPktl11GS+VKbi0=; fh=c0Ot37klKxp4Przplm9csdEIIibHggmFz6bNAbWZLRk=; b=tfNmkcOSUqn/7JFjS+O/ROe/zI7l0fB1MXbAiC81Dtrzlxwh1w03ArZ1hhlzpG6cIH /gXU2ftas/IeYAlmZVbtiZFOfaJetsoQMtX4pf9OM8kdUQCz/SX2QsQE3D8EEwjfRcjK eG4WWQ86RzhxkSfT5rVdx4P/ZrRXg4TurFPfLv7h6Ca8F9B39VwTCOyqVG9ktIi7Sl39 sUDWzqINgBtmm3BddiEHiBU1n8HDvcdGGaVJasL9gF3gCIwkOdb2ruosqt/QJZgzIkoJ am4Vp/HS6MLqhpJug2X1Qe+YJ7NyzFT/76q2y2ZHYgU/quWwaQq5MIANjbnr8VWgB85A c+0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ejtRGhxj; spf=pass (google.com: domain of linux-kernel+bounces-8821-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8821-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id u11-20020a65670b000000b005cd920effd5si1849432pgf.472.2023.12.21.09.13.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 09:13:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8821-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ejtRGhxj; spf=pass (google.com: domain of linux-kernel+bounces-8821-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8821-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9681BB21E31 for ; Thu, 21 Dec 2023 17:13:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D495359924; Thu, 21 Dec 2023 17:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ejtRGhxj" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11A3358221; Thu, 21 Dec 2023 17:13:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0D60C433C7; Thu, 21 Dec 2023 17:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703178794; bh=nAyiX2jVa47VcjFldc2L8bwP0OG/80C5+x4N04/VWn0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ejtRGhxj7cS86pXS2KzLKKAJLerUlW6+M4wQzjlIRnyiP9lgkl9MC3SHQ91dc6igr VJV3uq+wzBBLwagh48AOWkoTR5/nZ52RUXfZYb2WH2qfjMH10CTn1i/QGgcA4Zl4Ks 3YZkXhWhsMC1vjaeUCzV8kS4Wm0iKkwgdxLXOv/Joqm9GpLLBX0+9pOXsedkxGZYSP 4eGIByOofhN2AD9DCJpp72YMNGWwY16z7GSw4g+sUnt/50LhUMCFxYp4emIOC2xg3g q782ViZF4N3XFY73gV+oHnpfcLmPLzuPxio69tjaqz9Yum5sEOInfX2BgLuwf+tYps nKYXZS74e7JXA== Date: Thu, 21 Dec 2023 22:43:09 +0530 From: Vinod Koul To: Can Guo Cc: bvanassche@acm.org, mani@kernel.org, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Dmitry Baryshkov , Abel Vesa , Johan Hovold , "open list:GENERIC PHY FRAMEWORK" , open list Subject: Re: [PATCH v8 09/10] phy: qualcomm: phy-qcom-qmp-ufs: Rectify SM8550 UFS HS-G4 PHY Settings Message-ID: References: <1701520577-31163-1-git-send-email-quic_cang@quicinc.com> <1701520577-31163-10-git-send-email-quic_cang@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1701520577-31163-10-git-send-email-quic_cang@quicinc.com> On 02-12-23, 04:36, Can Guo wrote: > The registers, which are being touched in current SM8550 UFS PHY settings, > and the values being programmed are mainly the ones working for HS-G4 mode, > meanwhile, there are also a few ones somehow taken from HS-G5 PHY settings. > However, even consider HS-G4 mode only, some of them are incorrect and some > are missing. Rectify the HS-G4 PHY settings by strictly aligning with the > SM8550 UFS PHY Hardware Programming Guide suggested HS-G4 PHY settings. This fails for me, as I have picked Abels offset series, can you please rebase these two patches and send -- ~Vinod