Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp338592rdb; Thu, 21 Dec 2023 10:30:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfjoAmVAGstFOFIFrr3Db021je23UtUli9LGucxz5ETWguYgttYzzd0VY2tEy/eQBFxnhi X-Received: by 2002:a17:906:7151:b0:a26:983a:af7a with SMTP id z17-20020a170906715100b00a26983aaf7amr130379ejj.31.1703183410056; Thu, 21 Dec 2023 10:30:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703183410; cv=none; d=google.com; s=arc-20160816; b=dw9QG9af+BhqK372UxQ0/Y0o3I4PHfYexx0AT95YPkIPz/iBirjHxrK/zKdgwp+P0n RPlOk3Oo3QjCREBCAljXoewJB2gTa3jwYSQkyzcMtv0FZ+su/UmzS+SagHeeJ9F0JcZi i1EWppad4kZVttSET7agil843fRP7eZF3rnJHgk7HoRT/aFPKuM8R6zf/pBiIyDSRGao fNAATP0DMCvvfSo9rFGob/URICAcNiNB2TyYMhy+pU1IpPabqZLR2U2ffElL9pDSiqpB J+UIT5srNFFZJjcC3pyuEBaBnSXv5fATw/fW7BAAZWUcxO3WP5Q7RnleE75dPU8+004q a7Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=L6oljuqvAIy93N8zvm81RWXYplalK2qFGzuO99N/A1A=; fh=kyZd1qaMvKcd6CaFr4kzb2cS1NAzAQ77fHlJGtwKKZU=; b=eAUz2v3G6IXmTmtMBbGE0p8z+Ro/2JBbrwXNMGJvmJwkLBKoF5TlLftw0WWUcR7HXr 2N/A1dh+o146+W7iXUgId4Pm+XO1sCtGG/LroRpwXpm4yid/Wsy/mTs7wcMomBSuHb4D yXDYOSoFk8gZOCgjz86tKcaW2uYCv28ouvcpzeY753EIPpb4CEcd0UtadoZ+Cl1llXkf PNsZm4LJj7Cr7+exyKsXnT6O1yMh+ncCRATaXsF6p0jxmPHlZ4xe+TQXdLU/PN7cvEy6 252MwKhetpQaOgVHwL/DHfmk865yK6rlanxHcm505ny8jqMIIyvKloSYGfHZJ5BsRz9z AOFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Y6lVslGM; spf=pass (google.com: domain of linux-kernel+bounces-8925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8925-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u5-20020a1709060b0500b00a235eb079b9si1127729ejg.633.2023.12.21.10.30.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 10:30:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Y6lVslGM; spf=pass (google.com: domain of linux-kernel+bounces-8925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8925-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C5B2A1F235CF for ; Thu, 21 Dec 2023 18:30:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CDDFC64A98; Thu, 21 Dec 2023 18:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Y6lVslGM" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C02E464A86 for ; Thu, 21 Dec 2023 18:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-5e784ce9bb8so9510307b3.0 for ; Thu, 21 Dec 2023 10:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703183399; x=1703788199; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L6oljuqvAIy93N8zvm81RWXYplalK2qFGzuO99N/A1A=; b=Y6lVslGMQ3kuZvcMYNeIChpChmcHjmi8JBtjCzjZEFZC7Yq0CvVAlrTsW0s0rKEXRw xwWqa8NV1xqOTKi/94GM5irZTKLP4JOVOTpi3FaiU82QQvh7hDSZFLXD/xe6WQM9A1r0 x2y9l6bVTUNavwKQrrD9qXlRRchzBnOulbDDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703183399; x=1703788199; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L6oljuqvAIy93N8zvm81RWXYplalK2qFGzuO99N/A1A=; b=ohuzRiETqxGUy1asGoOXsa7ZnSrHgBPt3r28UNJtojOFcJ+ru3JU/DjMwKAshql7DS RlIoFkSF29hif9foYxp78Bsxw7k3qksvg8+SPBKHWuGXmAVAeYmcmQzNO6+ufq7IU4wF aLDSf7sUKzPXOfVuw1LzzmisnQ4b0o7KmsgrzWeTCv7ZbIR8LGBjERBY/Stuu1q2X5xM TvDXSgJfFs3lcnEkVWPmmDWGK/TBj0l/mmks6fP6lr3VBnwdEp6lDGjVOcZaF0E9vfbY OP8jA638hjfhLvUguThwnmwvc3S8Jn1GSZB288J/EK72hEddBXAnovEGO5OmW1f+gagc Vl7A== X-Gm-Message-State: AOJu0YzIucEfA5B0tpaFCC2XwI6ahT69vwJTNGiGSlB2yiBofiwTn/Ul xOeBfak+Sv/SM6/ITQtbABRani5tqE15xR/p5aaX1+2+gh1K X-Received: by 2002:a0d:d403:0:b0:5d7:5bef:e6e6 with SMTP id w3-20020a0dd403000000b005d75befe6e6mr818315ywd.31.1703183398828; Thu, 21 Dec 2023 10:29:58 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231220235459.2965548-1-markhas@chromium.org> <20231220165423.v2.6.I06b059021de1bf6103e60a73211f078f2af75d17@changeid> <7199b7b7-238e-45de-96f1-0f04d0fa718d@linaro.org> In-Reply-To: <7199b7b7-238e-45de-96f1-0f04d0fa718d@linaro.org> From: Mark Hasemeyer Date: Thu, 21 Dec 2023 11:29:47 -0700 Message-ID: Subject: Re: [PATCH v2 06/22] ARM: dts: samsung: exynos5420: Enable cros-ec-spi as wake source To: Krzysztof Kozlowski Cc: LKML , AngeloGioacchino Del Regno , Tzung-Bi Shih , Raul Rangel , Konrad Dybcio , Andy Shevchenko , Rob Herring , Sudeep Holla , Alim Akhtar , Conor Dooley , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" > You do not need this property, if driver assumes that. Just enable it > unconditionally. The goal of this patch series is to change exactly that: to prevent the driver from unconditionally enabling the irq for wake. The driver works across numerous buses (spi, uart, i2c, lpc) and supports DT and ACPI. SPI+DT systems all happen to need irq wake enabled. > I don't think anything from previous discussion was > resolved. Which previous discussion do you mean? In v1 it was suggested to split up the DTS changes by arch/soc and add a cover letter (which I did). Wrt to the binding discussion, Sudeep said the new documentation wording looked good to him [1]. [1]: https://lore.kernel.org/all/ZYAjxxHcCOgDVMTQ@bogus/