Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp341303rdb; Thu, 21 Dec 2023 10:34:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHc6q/GL00rAGNcz8Fkx1encsM8nW+Wvft+Ddbywjrln/rjEF87ajAwyQVxSnWmIaunpQJO X-Received: by 2002:a05:6e02:174e:b0:35f:c7c2:5151 with SMTP id y14-20020a056e02174e00b0035fc7c25151mr75385ill.7.1703183682056; Thu, 21 Dec 2023 10:34:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703183682; cv=none; d=google.com; s=arc-20160816; b=hR7b4hQMiG/b4ACXU3rcDrsdPWW8H1RivPxWJjBIoXGsvS+r1MJb6RfhSrZfz1XyQq 6ryyK4QylLkeDBeVEq4+SSSgaZs9xUSJJHcg6WTwhuOdQ4YWDHdGLTLFlwSr7R3gfV9G R4DuD0DD1HbFvL+gjqT3I1olLm/UVY5NvJAddaRjpOabYdFYv3z+DyFBNWwWxB+5R7eD 8StLTst5oJV1Oq2Y/yTFmJtMWty04ABjE+2jy0Y50pqdv7lbRRhgMIul0175wojleMOi FOzRPRBNw4go3Y0AFSvGwD/Tvgad7Sc6WOUZ8JzUSPgVRjG205w+8n2kKwacc0m98Sjn UjTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=3sFuxos3oBr0zNH2sCa/nhgb/CzikC8gebG/g8guKn4=; fh=GobySjluzopSzl9a5d4Wdz8OqeadwMBlLiVv+/s61qs=; b=GtbmdXP76smSVHx4Ysuma9ac7NG51XOqmQcnU4Wk/IkQuXmIydnXbofGbFehCC66I5 mdYcnAkllqaObjyxixGtfouCjLkvtQzUmIJvzYrSL/GDgpzLcEcsDkyuuZ+77AtQTdJb 4F3UHMv2dFmAiMAxQQA0o7sDl8Vwlds4xtfUdJI2VkICLs9E94QJGTDiJiwYp5yoHVRO 4dKpkR7mId/weEmfac0xmsGTuf24bzMOXbW5cBf/y1sDgGN9WgGqv0OC10zu2uOqc+mc VMHTk0QZEobvzBdMlIwp92POkAiYypqO52zuEfQQ/pHaYTIN0QzEY9E2UGqwcQYW6Q16 VdLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=0wdOol3n; spf=pass (google.com: domain of linux-kernel+bounces-8922-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8922-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id v67-20020a632f46000000b005cda6105077si1933247pgv.299.2023.12.21.10.34.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 10:34:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8922-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=0wdOol3n; spf=pass (google.com: domain of linux-kernel+bounces-8922-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8922-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 45AC728995D for ; Thu, 21 Dec 2023 18:28:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2EEA16518E; Thu, 21 Dec 2023 18:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="0wdOol3n" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B59DF64AB2; Thu, 21 Dec 2023 18:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=3sFuxos3oBr0zNH2sCa/nhgb/CzikC8gebG/g8guKn4=; b=0wdOol3nQtp3YM0d5pl61KAaPs WyRGtiQws8YcXcD/r+ECzzSt4LiQz6RRwKFprTN+wnS6ovcGByN6Amh2uDH4EDPq6s/dKzBzX5Iuq lV2McFiMCtS5ChPCZ0AZAxzTKtO/VHO9XjTGHCXo/RLwTlCbnU3KgxXOyVBH0u3chXD8C7O2m94zs +tOiapezwtkvtItSTR3JAKeZ0ohkbywvHC1WDx9/+OmSheSiHL3R3godXdz+MHJwv+PpHQo+2LEL2 M5tHvJ2H54bkV836wl19XI1uhui3eXlG3XA77VhQRVJ5DucFU4ZSgRp08amK7Z9909GW07MJnTC59 QNlF0FGg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rGNkg-003nNk-2b; Thu, 21 Dec 2023 18:26:34 +0000 Date: Thu, 21 Dec 2023 10:26:34 -0800 From: Luis Chamberlain To: Marco Pagani Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel/module: improve documentation for try_module_get() Message-ID: References: <20231221165848.150041-1-marpagan@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221165848.150041-1-marpagan@redhat.com> Sender: Luis Chamberlain On Thu, Dec 21, 2023 at 05:58:47PM +0100, Marco Pagani wrote: > The sentence "this call will fail if the module is already being > removed" is potentially confusing and may contradict the rest of the > documentation. If one tries to get a module that has already been > removed using a stale pointer, the kernel will crash. > > Signed-off-by: Marco Pagani Thanks, patch applied! Luis