Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp362176rdb; Thu, 21 Dec 2023 11:12:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnGwwmznHrROB7ylUjEgwOMGg0vpxXmBIEs6XrHrDwVyrq5CdorgTYuYAe3vmKYuDy4vRq X-Received: by 2002:a17:906:3f07:b0:a23:6249:ee99 with SMTP id c7-20020a1709063f0700b00a236249ee99mr183139ejj.11.1703185970745; Thu, 21 Dec 2023 11:12:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703185970; cv=none; d=google.com; s=arc-20160816; b=fcO1kaituhm7RA1Y0pFU6/WwAOK1zqImANw7HVw069/hHozEEMvNJOQHBJqaORs8Iq ZRn/6ewQI8VgN5hVHluYaZ9TFyWLFrCehGzv836e4vfmdbhACVcgH4D+VpZ1BgojJwjk Rqs0tkmfEP4MpxZmN0wkDCg9mBKqQysXTcthUC1vGNLrldejq+vsOaO05x4UryHrnLuE hOea8NtB1zGjXLvvvkusIl9hfbipoPjrKsyzl6k0xzg7dJeS63sIag7DTQkiO//nopdz BEnBsfz8VRafMbLO7iXJBdOuOidc4gTqdn/7zWC9AOpLJLaYTniXWDrs7a+DxYd6jznB iNFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=n1l5xZhbao6yyLMAHMlDGMBOyE+StA4U3ea1c7HAYjQ=; fh=1ZbOLymucMpHPgAW6Ec0PFi2ApL0mTrRg5dRvTVPo8g=; b=W8rU2edD9bxAmKj2BdKS+2QFI1r7Xh+egpPoamwRExp0AiDFKoq90rCe3qSWyGfWYi Iug/ExC7lrqBiMfG3xIdqIUjaqmc95QU1IlUvejTs4wpeFhtzCg5xvWaMYkSY9ma/yEP X8SrN4CJWWZiWGtxOxP7Cnc5OfuHrGC3Jp647mWpjtvxZ1fwxJU8TUnqwYIdEUr3aArm cOIuQGra3rR5sparr2fYimioKUy0fzlxmk1iYG6Rpn7VejChQmziU2CtDI3YdEpUe71C hnI55dImk/yiSJPKJzan1l+QbSfd8WnDhZMs5Q8zD6KDMXoz7Rgv7OrIPuiA7waZXrRL C95Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cCNfxIPG; spf=pass (google.com: domain of linux-kernel+bounces-8985-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8985-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id b16-20020a1709062b5000b00a1f7f1231fcsi1086478ejg.469.2023.12.21.11.12.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 11:12:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8985-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cCNfxIPG; spf=pass (google.com: domain of linux-kernel+bounces-8985-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8985-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5638A1F25656 for ; Thu, 21 Dec 2023 19:12:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0872777653; Thu, 21 Dec 2023 19:11:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cCNfxIPG" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1A82651BB for ; Thu, 21 Dec 2023 19:11:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703185866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n1l5xZhbao6yyLMAHMlDGMBOyE+StA4U3ea1c7HAYjQ=; b=cCNfxIPG/IIKkaPjEZu/pQqCgH6l5us8P2bfuuTBZJg09XmYWthH06sVbZYMmmx1ZXSDsT lrUvd3Qac1cdpOyTvYKy6gFwwm0Hgs1MJYeAYxDBo2BJhr9wpjUvHMoKxNwduJIcIvndBw K8wPZteN9ZJMVv6iM2nokpKoD7Ebocs= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-p7CO16_yMb-bn8DaF0X76A-1; Thu, 21 Dec 2023 14:11:04 -0500 X-MC-Unique: p7CO16_yMb-bn8DaF0X76A-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-77f54424077so142099185a.3 for ; Thu, 21 Dec 2023 11:11:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703185840; x=1703790640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n1l5xZhbao6yyLMAHMlDGMBOyE+StA4U3ea1c7HAYjQ=; b=HwL7xJhkokIEsGBPIOz0UkDZmzDs8lrQaFfQ3k2WHt+w5FFBH5Q3m7bccvypv3PLuG Vbq8FVrnyNCaOdzrrhK80bs8nAsqoy873KY3JyYFidG9dbjCrEWuK3kHRoPbN0I7Aa7N er2EixKkhuBGCUjfoMeKkkjf/ZXDc5M0BK3XfcW6rNNGlGix0JitW1M+CUvC/0p8OloC InQbYwdmfD+F9+DMQVZdSpCDI56vnK9+jV2XHf+aJOZzXertXF3SUxP85T7waDq77uN1 01vBHfT8/zh3RWVxJj3/nb8KipuS3aKkm+vsVWdyJnWyv1gpQZbShXXRNDqa76MkazN9 vakg== X-Gm-Message-State: AOJu0YzJlmECZiFdZ2ITnSLbeaORu7XM52XC26Z7i08DeEO+YtkbqBYh VtnT6SgAGNG61XMddiSUQ7wzDk3fytW0RrxyWcwt6+DNZteJOIDxAypE7PXiO6fhAiWNZSsW+ts Noq5A/05aYT2yPq59iymjj16qWnXkbN29 X-Received: by 2002:a05:620a:4892:b0:77f:3d4a:6dcc with SMTP id ea18-20020a05620a489200b0077f3d4a6dccmr391380qkb.8.1703185839990; Thu, 21 Dec 2023 11:10:39 -0800 (PST) X-Received: by 2002:a05:620a:4892:b0:77f:3d4a:6dcc with SMTP id ea18-20020a05620a489200b0077f3d4a6dccmr391370qkb.8.1703185839745; Thu, 21 Dec 2023 11:10:39 -0800 (PST) Received: from fedora.redhat.com ([2600:1700:1ff0:d0e0::37]) by smtp.gmail.com with ESMTPSA id 25-20020a05620a04d900b0077f0a4bd3c6sm846370qks.77.2023.12.21.11.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 11:10:37 -0800 (PST) From: Andrew Halaney To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Janek Kotas , Alim Akhtar , Avri Altman , Bart Van Assche , Can Guo Cc: Andrew Halaney , Will Deacon , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC v3 03/11] scsi: ufs: qcom: Perform read back after writing testbus config Date: Thu, 21 Dec 2023 13:09:49 -0600 Message-ID: <20231221-ufs-reset-ensure-effect-before-delay-v3-3-2195a1b66d2e@redhat.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221-ufs-reset-ensure-effect-before-delay-v3-0-2195a1b66d2e@redhat.com> References: <20231221-ufs-reset-ensure-effect-before-delay-v3-0-2195a1b66d2e@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.3 Content-Transfer-Encoding: 8bit Currently, the testbus configuration is written and completed with an mb(). mb() ensure that the write completes, but completion doesn't mean that it isn't stored in a buffer somewhere. The recommendation for ensuring this bit has taken effect on the device is to perform a read back to force it to make it all the way to the device. This is documented in device-io.rst and a talk by Will Deacon on this can be seen over here: https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 Let's do that to ensure the bit hits the device. Because the mb()'s purpose wasn't to add extra ordering (on top of the ordering guaranteed by writel()/readl()), it can safely be removed. Fixes: 9c46b8676271 ("scsi: ufs-qcom: dump additional testbus registers") Signed-off-by: Andrew Halaney --- drivers/ufs/host/ufs-qcom.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c index 4c15c8a1d058..6df2ab3b6f23 100644 --- a/drivers/ufs/host/ufs-qcom.c +++ b/drivers/ufs/host/ufs-qcom.c @@ -1332,6 +1332,9 @@ static void ufs_qcom_enable_test_bus(struct ufs_qcom_host *host) ufshcd_rmwl(host->hba, UFS_REG_TEST_BUS_EN, UFS_REG_TEST_BUS_EN, REG_UFS_CFG1); ufshcd_rmwl(host->hba, TEST_BUS_EN, TEST_BUS_EN, REG_UFS_CFG1); + + /* dummy read to ensure this has been enabled prior to returning */ + ufshcd_readl(host->hba, REG_UFS_CFG1); } static void ufs_qcom_get_default_testbus_cfg(struct ufs_qcom_host *host) @@ -1429,11 +1432,6 @@ int ufs_qcom_testbus_config(struct ufs_qcom_host *host) (u32)host->testbus.select_minor << offset, reg); ufs_qcom_enable_test_bus(host); - /* - * Make sure the test bus configuration is - * committed before returning. - */ - mb(); return 0; } -- 2.43.0