Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp362453rdb; Thu, 21 Dec 2023 11:13:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IFvIQ6fzyaxOeuQWE939x4Y116DtA14CBv6e+3IC1vYVXCET5PKITi253FXcTT3gZSiO/+V X-Received: by 2002:a37:e30c:0:b0:781:26d8:9554 with SMTP id y12-20020a37e30c000000b0078126d89554mr287263qki.103.1703185997475; Thu, 21 Dec 2023 11:13:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703185997; cv=none; d=google.com; s=arc-20160816; b=eGMSDrCZSiUpqKpAZOCd1GUUvcm8Thi7L+SuTSGb9NDRO/tgFPzjNaiKxewsSltWD2 NKDlwuRbcM+9Y3vfn4r/lEapSvryKvXjw4UTCGolv8O96ve3+/dpw9KPJbmQ93EQ1ccN GTlfbCaUoKvJYYX9gTwd/ReMyMJhowA/rQ+d1DgadshKE93HBf/wCRBnktsUl8r+8S3b uBMum8fnuWN5fOcx2TTExCxYxRVhAi7AK7SBqMpZV4LXQaGtNLmtCpwMnt/70c6PNMO+ rUkgAsBwDgYFnHYwa6SSbFOtPQohsYDGbKMnWpu2m700UBcqL7KYcwJvUXJhWnFCK/kr nskQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=4md7/lhuz61o/OLaxynlTwcjr95vaOPE75vAR/46vcY=; fh=1ZbOLymucMpHPgAW6Ec0PFi2ApL0mTrRg5dRvTVPo8g=; b=r2EBllgWa29CiO2Evr9p57C6lJA2wwQ11w56ta/DpR5jn6wHuEehAKPtx0DTe5sGQu 5OECl9z7+yNV2hIwTBOCzbe7EWrvornSvA2ZBkgz+MLacZIyhb0g4daFix7Uc//ANdSZ 8TN871C1TbgeFnqw8Z8DuJ2cjFqexFNpqHCxvKiU2BDJqk4epnu8tZ75D5PX7krQTy5s 5sGrTUbLgmkjrz3TkmG7X3ZYGWSzaz0MP9OBTBWyexwncGn5Yt6OM5D7lITt8cDoRGux P3tiPwum/digvtw6CPMnaJays7Fuj6jfhoT09jSIFg64KLbTTZoCddPGbJylYNi6sT+4 clbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cLplHAme; spf=pass (google.com: domain of linux-kernel+bounces-8986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8986-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s28-20020a05620a031c00b0077d7b25d9e2si2617873qkm.677.2023.12.21.11.13.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 11:13:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-8986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cLplHAme; spf=pass (google.com: domain of linux-kernel+bounces-8986-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-8986-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3B0AB1C242E3 for ; Thu, 21 Dec 2023 19:13:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 13C9377F1F; Thu, 21 Dec 2023 19:11:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cLplHAme" X-Original-To: linux-kernel@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A63577F11 for ; Thu, 21 Dec 2023 19:11:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703185870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4md7/lhuz61o/OLaxynlTwcjr95vaOPE75vAR/46vcY=; b=cLplHAme+7gr7Wx9qwJy48Btj1dy1ZFa+k4nAOllFqr8d5KUAkD4rryKL0hnWWuURNJEqC riB7TMqMMFXvm5PSc2xrwf1IJFNyEA5UumIqcQwjavfydtnFPo7yqsOog8r382oGRwo8WP bX+KWNaclt/ifKf90FlOKIK2Xn/3IUU= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-c58E-_A4Mge6UtiJVW9rGA-1; Thu, 21 Dec 2023 14:11:08 -0500 X-MC-Unique: c58E-_A4Mge6UtiJVW9rGA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-781168a5772so101018985a.0 for ; Thu, 21 Dec 2023 11:11:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703185865; x=1703790665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4md7/lhuz61o/OLaxynlTwcjr95vaOPE75vAR/46vcY=; b=F7+/7KkXVZiYA5YExaIe2tq1Ta7MFftF4XIE4SqpNLM+kdf47UKja4XYd9TFcdYVSq ExgU0uCM6LOnOTUBBipDfS8FFCXby+pezgbmCFi0EnyM1fTth3Ca9RrbonBzbdeP5CNz BS6njLPNCvlG2AcQHo13RG9h++6M9d5fxjOjMEQLirKi6GiINIMtfRKun7n/+f/l8yL6 9ZgkUwZnCe72cG7/y75LPlI0vwLm0SnQBa6TLdCHp336YGbpJkZxzGESA1DifBl8P32u /9Dulq007Fmy3REScnqbj4EVblfL1ZW4WLvntBY34YyHRY5KGsn9gRb34NmM4pJMaCPC OPSw== X-Gm-Message-State: AOJu0YwHiXdp+XHiejDsrUsKKXH/HeKbGapZTsnGXBTrfnwg+7QBG3AD +dtDll26tWfp0XOnURvoPGWNyiK//iZufb+YS9+/0lQ8+yPHJv0rvY4fauqC2LsqGMQrC7uGRdi 6enSK7DrLIQ1gU1EmqKVUPh7oRuS2RFCZ X-Received: by 2002:a05:620a:5632:b0:77f:983d:9627 with SMTP id vv18-20020a05620a563200b0077f983d9627mr329705qkn.23.1703185864732; Thu, 21 Dec 2023 11:11:04 -0800 (PST) X-Received: by 2002:a05:620a:5632:b0:77f:983d:9627 with SMTP id vv18-20020a05620a563200b0077f983d9627mr329687qkn.23.1703185864363; Thu, 21 Dec 2023 11:11:04 -0800 (PST) Received: from fedora.redhat.com ([2600:1700:1ff0:d0e0::37]) by smtp.gmail.com with ESMTPSA id 25-20020a05620a04d900b0077f0a4bd3c6sm846370qks.77.2023.12.21.11.11.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 11:11:01 -0800 (PST) From: Andrew Halaney To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Janek Kotas , Alim Akhtar , Avri Altman , Bart Van Assche , Can Guo Cc: Andrew Halaney , Will Deacon , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC v3 08/11] scsi: ufs: core: Perform read back after disabling interrupts Date: Thu, 21 Dec 2023 13:09:54 -0600 Message-ID: <20231221-ufs-reset-ensure-effect-before-delay-v3-8-2195a1b66d2e@redhat.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231221-ufs-reset-ensure-effect-before-delay-v3-0-2195a1b66d2e@redhat.com> References: <20231221-ufs-reset-ensure-effect-before-delay-v3-0-2195a1b66d2e@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.3 Content-Transfer-Encoding: 8bit Currently, interrupts are cleared and disabled prior to registering the interrupt. An mb() is used to complete the clear/disable writes before the interrupt is registered. mb() ensure that the write completes, but completion doesn't mean that it isn't stored in a buffer somewhere. The recommendation for ensuring these bits have taken effect on the device is to perform a read back to force it to make it all the way to the device. This is documented in device-io.rst and a talk by Will Deacon on this can be seen over here: https://youtu.be/i6DayghhA8Q?si=MiyxB5cKJXSaoc01&t=1678 Let's do that to ensure these bits hit the device. Because the mb()'s purpose wasn't to add extra ordering (on top of the ordering guaranteed by writel()/readl()), it can safely be removed. Fixes: 199ef13cac7d ("scsi: ufs: avoid spurious UFS host controller interrupts") Signed-off-by: Andrew Halaney --- drivers/ufs/core/ufshcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 7bfb556e5b8e..bb603769b029 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -10568,7 +10568,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq) * Make sure that UFS interrupts are disabled and any pending interrupt * status is cleared before registering UFS interrupt handler. */ - mb(); + ufshcd_readl(hba, REG_INTERRUPT_ENABLE); /* IRQ registration */ err = devm_request_irq(dev, irq, ufshcd_intr, IRQF_SHARED, UFSHCD, hba); -- 2.43.0