Received-SPF: pass (google.com: domain of linux-kernel+bounces-9030-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20231221180637.105098-1-andrey.konovalov@linux.dev>
In-Reply-To: <20231221180637.105098-1-andrey.konovalov@linux.dev>
From: Marco Elver <elver@google.com>
Date: Thu, 21 Dec 2023 21:06:29 +0100
Message-ID: <CANpmjNNY81MMtRVgux5725viFoq2i7PzjVvrnbJmT8ArmTMBUA@mail.gmail.com>
Subject: Re: [PATCH mm] kasan: fix for "kasan: rename and document kasan_(un)poison_object_data"
To: andrey.konovalov@linux.dev
Cc: Andrew Morton <akpm@linux-foundation.org>, Andrey Konovalov <andreyknvl@gmail.com>, 
	Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, 
	Andrey Ryabinin <ryabinin.a.a@gmail.com>, kasan-dev@googlegroups.com, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, Andrey Konovalov <andreyknvl@google.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 21 Dec 2023 at 19:06, <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@google.com>
>
> Update references to renamed functions in comments.
>
> Fixes: ac6b240e1ede ("kasan: rename and document kasan_(un)poison_object_data")
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

Reviewed-by: Marco Elver <elver@google.com>

> ---
>  mm/kasan/shadow.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c
> index d687f09a7ae3..0154d200be40 100644
> --- a/mm/kasan/shadow.c
> +++ b/mm/kasan/shadow.c
> @@ -130,7 +130,7 @@ void kasan_poison(const void *addr, size_t size, u8 value, bool init)
>
>         /*
>          * Perform shadow offset calculation based on untagged address, as
> -        * some of the callers (e.g. kasan_poison_object_data) pass tagged
> +        * some of the callers (e.g. kasan_poison_new_object) pass tagged
>          * addresses to this function.
>          */
>         addr = kasan_reset_tag(addr);
> @@ -170,7 +170,7 @@ void kasan_unpoison(const void *addr, size_t size, bool init)
>
>         /*
>          * Perform shadow offset calculation based on untagged address, as
> -        * some of the callers (e.g. kasan_unpoison_object_data) pass tagged
> +        * some of the callers (e.g. kasan_unpoison_new_object) pass tagged
>          * addresses to this function.
>          */
>         addr = kasan_reset_tag(addr);
> --
> 2.25.1
>