Received-SPF: pass (google.com: domain of linux-kernel+bounces-9066-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 21 Dec 2023 22:55:20 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>, Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-btrfs@vger.kernel.org,
	Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	linux-kernel@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH 1/2] lib/strtox: introduce kstrtoull_suffix() helper
Message-ID: <ZYSmOCcqbBbbFx-s@smile.fi.intel.com>
References: <ZYL5CI4aEyVnabhe@smile.fi.intel.com>
 <15cf089f-be9a-4762-ae6b-4791efca6b44@gmx.com>
 <ZYQo6DB4nQj58iUg@smile.fi.intel.com>
 <cf3808eb-0c8f-4a51-b2b4-14eb33b88992@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cf3808eb-0c8f-4a51-b2b4-14eb33b88992@gmx.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Dec 22, 2023 at 07:07:31AM +1030, Qu Wenruo wrote:
> On 2023/12/21 22:30, Andy Shevchenko wrote:

...

> Then what about going the following path for the whole memparse() rabbit
> hole?
> 
> - Mark the old memparse() deprecated
> - Add a new function memparse_safe() (or rename the older one to
>   __memparse, and let the new one to be named memparse()?)
> - Add unit test for the new memparse_safe() or whatever the name is
> - Try my best to migrate as many call sites as possible
>   Only the two btrfs ones I'm 100% confident for now
> 
> Would that be a sounding plan?

As long as it does not break any ABI (like kernel command line parsing),
sounds good to me.

-- 
With Best Regards,
Andy Shevchenko