Received-SPF: pass (google.com: domain of linux-kernel+bounces-9080-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 21 Dec 2023 13:25:34 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, Dan Williams
	<dan.j.williams@intel.com>
CC: Michal Wilczynski <michal.wilczynski@intel.com>, <nvdimm@lists.linux.dev>,
	<linux-acpi@vger.kernel.org>, <rafael@kernel.org>,
	<vishal.l.verma@intel.com>, <lenb@kernel.org>, <dave.jiang@intel.com>,
	<ira.weiny@intel.com>, <linux-kernel@vger.kernel.org>, Andy Shevchenko
	<andy.shevchenko@gmail.com>
Subject: Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm_*()
Message-ID: <6584ad4df04f1_5580229433@iweiny-mobl.notmuch>
References: <20231017082905.1673316-1-michal.wilczynski@intel.com>
 <652f5eddba760_5c0d29449@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <CAJZ5v0g5buHjd+EqMsHtuN2vcJHSTCd-cCchvo-44iPi1cKk5A@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJZ5v0g5buHjd+EqMsHtuN2vcJHSTCd-cCchvo-44iPi1cKk5A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUNHSlhCRjVYeFhyVGo0N1JBR2lFYVVISVJ6Z0V4bStOWWhMQkk4LzZuZ1hL?=
 =?utf-8?B?MVByNlBpb0IvTEEyeWVkelZ5d3FiZi9zc2tNbThiSXR5My9YcTE2L3JsMk1i?=
 =?utf-8?B?aUVraFR1V2ZBUU1pczlSUEFCcXdlVnUrblJvK1d3aTRsQ0FnaTVRV2c3QjY5?=
 =?utf-8?B?WGpxdkw4VnRvRzAvaUMyQWRkN1dKbTVPaEtaT1RtcG5wREljdFFoTC95WkdY?=
 =?utf-8?B?YnZ4RHdMd0J3VDNkdnQ3b0F6UmZvZ1BPdGxYUEtWQWJqbVNJUks1NGFlR0J6?=
 =?utf-8?B?WU8reFY2QS96RHlWZDJ4TElMRVBJb3pnMEFRODVoVU5MMEJCYkU5Ulk0NlhT?=
 =?utf-8?B?VzVPaFJlN3RDbWVaeDhXMDk3S3FlNUFsSHM2akdac0YzbkwrV0MySVNYbVpQ?=
 =?utf-8?B?eHRNbjI4U2IzYW5iTUIwR2owdUl4R2wwa2lHaUE4UE5MRVpWcGEwWGpwTzVJ?=
 =?utf-8?B?Vlphc0Z6QlVYYjNuOUFiYVE2Z2pZNDRIQkpjYXRCVnBxNXQrWCtBVWhKdmIr?=
 =?utf-8?B?ZWdtT0FsWkxqRFhhajNPeU9pcmM4dE5RWVdYMyt4bUNZS3V6YnF4K0xJTzhy?=
 =?utf-8?B?MVJKRzdiRy9VTHdGM3lMR0lhRDZPcGFSYy9VR1R0VDRuSnJ3M2FLSDZGQmE0?=
 =?utf-8?B?eWVtWWZoNzRXd1kvWVpnaTQwQ0dvU2VEUGUrM1pNNktydis2QkdHS1BWaFN1?=
 =?utf-8?B?Z3ZVdHBwQnVKSWxENGM2M0UrSHRkSDYwZS9PMGQ5ZnRCTkNEeW5BZ015d0dm?=
 =?utf-8?B?UTJDVm9adGpzY2E0N3hJcHcwanBKalUwdGNmd01ScWRZOUNsVEloSFZJbUp2?=
 =?utf-8?B?L1pKa3puMUlWWFpHaGlibFpTcCtadEhaSld1R3ZPUjZTYW50SXhQczhkMERK?=
 =?utf-8?B?MjIwSTNQUVlPZFdadDFKRFJ0T1JZbHMrZ2hHd0ZvV25jK0JNbWJWdnp5QUhZ?=
 =?utf-8?B?ckRBQ3BJenpFekVtdlZrSWF1Nis2clEweUI4T0hVaGwvVDNkYUVaZjhkRUtT?=
 =?utf-8?B?b251d090VmdnbDluNHhId1VTNUlUZTQ5Ujd3K3pyYkd6Y2JOYlB3RHN5K1dq?=
 =?utf-8?B?UWlwbXV6T2NOOEV1ck91L29yYVdaQWV5emVpd0JqNzl2aTlsTDhKQk9iY2hT?=
 =?utf-8?B?TzRCSWtPditua2Y5cFkralViR3dYNzJudkpzVHBZYSttbUdlS1FvNnBSa0tH?=
 =?utf-8?B?K0tORWFRNEtzbTViR2FRUVRhRUNHRWNveDh6ZG0wR2NTYUx0N3Zwb2ZFdURO?=
 =?utf-8?B?UVRJWkEvaUFlRkUwTXp6b3NnMzZib25mY2RKaW5DMm1yTjg1T29zZDQ5RFhG?=
 =?utf-8?B?eVhDVUd2b01GS0VCdDdSTlpUL1E2cTR5ZEhCN0podjVSeTZITTA4YUJ2VHp0?=
 =?utf-8?B?ZEFaWG4wWVIzMDJwWHlhZFUvZ0RTVVorQ08weDJJTFFEVStRbkxyM3BpeTM0?=
 =?utf-8?B?emd3WDc5aEtKaTZiSUJEOGh2M0FWSU16b3g1TklHSVdReWVaL1RQSWdFSENu?=
 =?utf-8?B?NGw2ZDZaQThPMXU4R3NxREhwQXRUNi82dU44L2k5Uk03V3ZEU203UEtkMnBB?=
 =?utf-8?B?TTQ2aUJwME9kNFZiaURkbUFjTlNrSzhHdzVsaUM2cmE2TGtja0kxL3RUSE9B?=
 =?utf-8?B?cjRSRDNlZUJVZ3M0UDZHZzZIdFZRclYyaWRsZjEyejV4WDlad3RKR0luSklL?=
 =?utf-8?B?ZlJWOXZhM0llMXFvTTFYaHVRSG1JUk1lTnNOUUZwaXE4VXl6QVNNWUwza0F6?=
 =?utf-8?B?dm1FMlhsejJLalZsNUg4Yk1kdE9yZ0pkNkpSL0w0NkF5V1R0V3J6UDIvNWx4?=
 =?utf-8?B?czJNRFJuVXJ0MGp5WDh5TDNOWTBPWmFpVGk5UFRSekF5TG5md1NIbUJzYnNp?=
 =?utf-8?B?OGY2aHhUekp0NW9LTDAwUTVCRWpqQnhoK3Z6THNSbmpLcDYyNnFaVDl2NTlV?=
 =?utf-8?B?TFJHaHNYRFBLTzJkSWhwS0hFdktDNkx0THdCQ3dhc0wvdE9zLzlyVHF0Z003?=
 =?utf-8?B?anRPTzdOY3BJMHFYMThBY1NEaUQ2L1FjRlFoRTQzLzdhSFBTbitTbTQ1V3NS?=
 =?utf-8?B?UGJNL2lXRU9QcktPRGhPR3liVzU5T3Z0U3FsZ2YvT0lxejM3cW95d255RXdl?=
 =?utf-8?Q?clQLjuBpW+zAopS95rjihCy/c?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4f65dd-7811-42ad-1061-08dc026b5fc0
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2023 21:25:37.2598
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8GfS/dmCRRC9eQ7vRs4JiSfv1NbuTK4stWvZDuYsg0UuR284i6V3S0QoCHFOOzgxzcwIgxGLPiYfn7B0R2L0cw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4983
X-OriginatorOrg: intel.com

Rafael J. Wysocki wrote:
> On Wed, Oct 18, 2023 at 6:28 AM Dan Williams <dan.j.williams@intel.com> wrote:
> >
> > Michal Wilczynski wrote:
> > > The new cleanup.h facilities that arrived in v6.5-rc1 can replace the
> > > the usage of devm semantics in acpi_nfit_init_interleave_set(). That
> > > routine appears to only be using devm to avoid goto statements. The
> > > new __free() annotation at variable declaration time can achieve the same
> > > effect more efficiently.
> > >
> > > There is no end user visible side effects of this patch, I was
> > > motivated to send this cleanup to practice using the new helpers.
> > >
> > > Suggested-by: Dave Jiang <dave.jiang@intel.com>
> > > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > > Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
> > > ---
> > >
> > > Dan, would you like me to give you credit for the changelog changes
> > > with Co-developed-by tag ?
> >
> > Nope, this looks good to me, thanks for fixing it up.
> >
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> 
> Are you going to apply it too, or should I take it?

I'm prepping the nvdimm tree for 6.8.  I will take it.

Ira