Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp448354rdb; Thu, 21 Dec 2023 14:13:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjYTloCj5F88bqBVHj6gSPG+q+4jbD6yNCvgDlLwZnM2ECBgGx76yu7pVtLzT432U8Vi7A X-Received: by 2002:a05:622a:28a:b0:427:8436:5b4d with SMTP id z10-20020a05622a028a00b0042784365b4dmr484045qtw.23.1703196787099; Thu, 21 Dec 2023 14:13:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703196787; cv=none; d=google.com; s=arc-20160816; b=UG3ZyKUfHWqiaogOj/d3pelyXFrKznLXD1drTpBA49E60Xth0ru1diT2ZL75ar+lkb q51QCB2YQNcOHEEpXiAtgg60vvzkiVkr7dmG3OUu+7VHDElOJV4WQRmnFHN9b/GpZDa+ SgNePKnV27FIoKn8uJRGuVeEGJYodv/fkrZyT7OqWJRuSbq1VRDf8HRw8aCQatWQOXRY tGcxfUtqtiBbX47T/Bd58nVyvV1OzceCzS+LUpx3rmXTnLpCLHzS+JBCs0y8HUvobayg Bw1zPvXAZd1P1KH1gXOhj3K0S3FEJTu66UzVZ+cuLqR+QRbDp14X3A8pPuSPcw+gmfv9 N43Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=a8OCCGU0kIYl+wFHzICuWpygzYZpJkTkeYNPGVQfAog=; fh=8zG/STxDfGeB1imY8gZBU9z/BUJ3QXkD6cpa2npRONI=; b=rc+14ziQBlWadihnkWv+ecKXIgea9YGU0fDF1GH0SLJ0uQF7mqM68Pih+qgHi2xDrH xxm/1hSBzPm7ykubpbxrNK0YA7A72qAmtr0Li2ifNgaLvfSqQTVizPhUbWIXI2dI5n8H 49nmwiMvWrpX/D5l7dhWv8eQwtQ0XuADdw+UAhTmOLUwaUK7/NAR7CuBWAWxBXVYIF/L DAoiWv45ZqCszFILyRsWA2bAo9zoiG5uV76/0eN2n0SvMWnqd77E1Hdh9sN1GifxUFIm ve/EGZhZECOh32FlcBE+o+DQRYOFd5mgODlEvq7MvYiZxa8pD2Ew69OrVisGoelDyBUq h+mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=d3htO9qv; spf=pass (google.com: domain of linux-kernel+bounces-9118-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9118-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id b13-20020ac85bcd000000b00423a2fd5d34si3050367qtb.63.2023.12.21.14.13.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 14:13:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-9118-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=d3htO9qv; spf=pass (google.com: domain of linux-kernel+bounces-9118-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9118-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D83CF1C23611 for ; Thu, 21 Dec 2023 22:13:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DD4F277F14; Thu, 21 Dec 2023 22:13:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="d3htO9qv" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 205D376DD0 for ; Thu, 21 Dec 2023 22:12:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 513D5C433C8; Thu, 21 Dec 2023 22:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1703196779; bh=Xj5b7BBgsG+mfoh/BRfljpTiO2RqoZvx/iiu+mRkX6Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d3htO9qv8US2F2TIt+dvaIcvSjW6dQ1/lZ73niCZsQNsCCoNVU7XucpyPeawILmR/ jagfUKXCEquHbWHNNpOsx8Rn3vbH+FtNvKKKprgHcr7ucZjgc3t5qt9KQhv6vBquGi xYL5WxxtOx/gbSIZXKWhyfTqqqttqEAuwjIG44Qw= Date: Thu, 21 Dec 2023 14:12:58 -0800 From: Andrew Morton To: Yuntao Wang Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Baoquan He , Eric Biederman Subject: Re: [PATCH] kexec_core: fix the assignment to kimage->control_page Message-Id: <20231221141258.7113f9b2599ea6d3b6638e08@linux-foundation.org> In-Reply-To: <20231221042308.11076-1-ytcoode@gmail.com> References: <20231221042308.11076-1-ytcoode@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 Dec 2023 12:23:08 +0800 Yuntao Wang wrote: > image->control_page represents the starting address for allocating the next > control page, while hole_end represents the address of the last valid byte > of the currently allocated control page. > > Therefore, after successfully allocating a control page, image->control_page > should be updated to `hole_end + 1`, rather than hole_end. Thanks. Again, please include a description of the userspace-visible effects of the bug.