Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp448647rdb; Thu, 21 Dec 2023 14:13:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IHT5eVX+NuOot+ZOBL5YX4pXC07DUhlx+QAcHx8JdPa08dhXFTfeDdvsEzdfiK1A7upKUE5 X-Received: by 2002:a05:6359:6f12:b0:172:ccdf:736f with SMTP id tk18-20020a0563596f1200b00172ccdf736fmr389395rwb.35.1703196830942; Thu, 21 Dec 2023 14:13:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703196830; cv=none; d=google.com; s=arc-20160816; b=qv/wjEVWuqeDSYAbsg8SPI5PpJgwNI4YuBnyDqvdjgJ/LVgTpUB2HDGU14O2OT7cpx iTusHP7nJhqv+ByIjRn8tSL3VoWu9/QQJV1/U3qi/3yOheNOO3SDxHKGCLL6ykY7gQ0U XYFcIBlT8vZrWVP+2l5bL0hCPTbfcDhwm2UQQ7cETzZyAfv1dtUavyZgVlT4KWmklmFg Ky7XX65o1JzvGyKQfMUE76qvsnSxenYAlXDKoq99bsHwwBxMD9UZ5AEYK9QqfVQTx26m 2HDKAebC1sxYc1i56TY1iJOkBun4kuxT0qpp+YOg9mgw+ymQI0jYhY+9L0dhUedbqHRW mpEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5jl+j8VoAJ0TH+y6nII30+cXSo3AkwWFgfdB0n28bjc=; fh=o0YSUlIBXASYW9SzC7EJURMBjBf4vnMeeuhLufWGOj0=; b=AjAGwkc2Qqa8hcDHiOPsm3YW9PuiEavGjvZ4dCd/qsHkPtFk0aAV1tLzX0N8I6p+PH 5Z//5JT7yt2dkdBeZYdzIFs/d08Wpyxy+72Rbdu37tmhFFoXcpmrCCXKIduBlauBLmcE +0d1LOtDnJVdsb791lbaHFL1MYn2oKLb3vopQgIZ9ALg0o7eoqyUizNjffdEdK719veS c3SjgbQIEnTT03TWnCU7o7Qiwwj/J5UNLAkpc6+K9pIp7fCaOjOJXwJnb8Fnna47dDok 5GuRre308dnoJagI8i7MH1VK4YuT+X1Tsy0Mkq1GVlnklx8r34vAv8bvQsbLJrGRgz1U VKiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=qYnlUlF9; spf=pass (google.com: domain of linux-kernel+bounces-9119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9119-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h17-20020a17090acf1100b0028aedf48a6fsi5338902pju.174.2023.12.21.14.13.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 14:13:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-9119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=qYnlUlF9; spf=pass (google.com: domain of linux-kernel+bounces-9119-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9119-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 96B9C287D96 for ; Thu, 21 Dec 2023 22:13:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8AF4A77F25; Thu, 21 Dec 2023 22:13:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qYnlUlF9" X-Original-To: linux-kernel@vger.kernel.org Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC06476095; Thu, 21 Dec 2023 22:13:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5jl+j8VoAJ0TH+y6nII30+cXSo3AkwWFgfdB0n28bjc=; b=qYnlUlF9BEORe4ao7JNQ8ooRm/ BYv+/cuY5/1MvnSoiroxHyPmtjI2F7ExzVRIYu7ww7EjxClT8aX+Qj5WDVaNblw1bwNrPMW/FaO1M 24Q5U4h9VsQIvZ4BXfRmFkdI3DfRBzbjqAUf98ykniHwcdaVE1/8E4j0jG/I0qKPBYoiN15aQVdfv tAQcX1rd4eVHcX6e8jpR5gY+eUPFdYG8yiVuIKXfqxgXCVQCmYNSjxSJQKkyamoh36G9LxKrMykZx AUaftO04oM+7cMFrhxxVsvjhGEOFFOMFEJ5EAjVbU/s1/NfjDBMcUEFTCmLnybtiMPPQl2W+lZzSj Zk0R0WWA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rGRIO-006J3l-2k; Thu, 21 Dec 2023 22:13:36 +0000 Date: Thu, 21 Dec 2023 22:13:36 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: Andrew Morton , Oliver Sang , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , linux-kernel@vger.kernel.org Subject: Re: [linux-next:master] [mm] bbcbf2a3f0: kernel_BUG_at_mm/memory.c Message-ID: References: <202312192319.fa8f5709-oliver.sang@intel.com> <20231220141135.cb4241442b657104f0aeae34@linux-foundation.org> <20231221135833.92b8b2a97b28ad0545977f6c@linux-foundation.org> <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com> On Thu, Dec 21, 2023 at 11:07:21PM +0100, David Hildenbrand wrote: > Subject: [PATCH] Fixup: mm: convert ksm_might_need_to_copy() to work on folios > > We must only adjust the page if the folio changed. Otherwise, if we > had a large folio in the swapcache and the folio didn't change, we'd > suddenly change the page to-be-mapped. Heh, I was expecting you to be done for the day ;-)