Received-SPF: pass (google.com: domain of linux-kernel+bounces-9178-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <dad49b21-f7f5-435a-88fd-6505add3acf4@infradead.org>
Date: Thu, 21 Dec 2023 15:26:04 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] nvdimm/namespace: fix kernel-doc for function params
Content-Language: en-US
To: Ira Weiny <ira.weiny@intel.com>, linux-kernel@vger.kernel.org
Cc: Dan Williams <dan.j.williams@intel.com>,
 Vishal Verma <vishal.l.verma@intel.com>, Dave Jiang <dave.jiang@intel.com>,
 nvdimm@lists.linux.dev
References: <20231207210545.24056-1-rdunlap@infradead.org>
 <20231207210545.24056-3-rdunlap@infradead.org>
 <6584bce9d01cc_55802294dc@iweiny-mobl.notmuch>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <6584bce9d01cc_55802294dc@iweiny-mobl.notmuch>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 12/21/23 14:32, Ira Weiny wrote:
> Randy Dunlap wrote:
> 
> [snip]
> 
>> @@ -1656,8 +1664,10 @@ static int select_pmem_id(struct nd_regi
>>  /**
>>   * create_namespace_pmem - validate interleave set labelling, retrieve label0
>>   * @nd_region: region with mappings to validate
>> - * @nspm: target namespace to create
>> + * @nd_mapping: container of dpa-resource-root + labels
>>   * @nd_label: target pmem namespace label to evaluate
>> + *
>> + * Returns: the created &struct device on success or -errno on error
> 
> NIT: should this be ERR_PTR(-errno) on error?

Oh, for sure. Thanks for catching that.

> Generally good to me though.
> 
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> 
>>   */
>>  static struct device *create_namespace_pmem(struct nd_region *nd_region,
>>  					    struct nd_mapping *nd_mapping,

-- 
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html