Received-SPF: pass (google.com: domain of linux-kernel+bounces-9191-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: SeongJae Park <sj@kernel.org>
To: Tanzir Hasan <tanzirh@google.com>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev,
	linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Nick Desaulniers <nnn@google.com>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] mm/damon/vaddr: changed asm-generic/mman-common.h to linux/mman.h
Date: Thu, 21 Dec 2023 23:49:47 +0000
Message-Id: <20231221234947.59458-1-sj@kernel.org>
In-Reply-To: <20231221-asmgenericvaddr-v1-1-742b170c914e@google.com>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi Tanzir,


On Thu, 21 Dec 2023 23:11:01 +0000 Tanzir Hasan <tanzirh@google.com> wrote:

> asm-generic/mman-common.h can be replaced by linux/mman.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
> 
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>

Thank you for this patch :)

Maybe we could add below Fixes: line?  I guess stable@ is intentionally not
added and that makes sense, but please let me know if you think differently.

Fixes: 6dea8add4d28 ("mm/damon/vaddr: support DAMON-based Operation Schemes")

Other than that, looks good to me.

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]