Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp486399rdb; Thu, 21 Dec 2023 15:52:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IG8ivWkTVBI/Dj4W5OGzIyGg8GSXi6WJzt5blZejoMYXEBxZpOvv00Y1CYxNb16eGu6gJOA X-Received: by 2002:a17:906:113:b0:a26:8825:f74c with SMTP id 19-20020a170906011300b00a268825f74cmr233434eje.30.1703202754234; Thu, 21 Dec 2023 15:52:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703202754; cv=none; d=google.com; s=arc-20160816; b=MQFe2Q6VGhmOKQ5HmgGqbi+mcyOl2S0h4geQU77NlydVaxwSVVBlEJmmjluNJimb94 2aJ+b5nr2CkWeobaBhRoxRxwZ7wRfE+bHyHruX2etWhJboenp0ZWlAYEmFg637HIfoPP Gua5XwsIh7hxoD8olzot6rbtcvIwupAswQFxpqIp91Yh+GJXFVV0nAKgBjTgABIxDagY bmBv1mVXZG/YooAxaRqjGVQyAaWNF4TdmfcGHOdKYzXJ6wUv2RmsW8EceLjIAkX/im8c +T2GsuOuRTHat02WVa5Vt7vywbX7OyCbyo8Bbqm8qnBwTjofIs6JeHPnYuWkoEE43w4T HRzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=f4uDw1WRa5SG6czjbnHQWjQZqqBhTvomA48xZ5HM1C0=; fh=Lqp8JPt9uKAXf7BUvL/8CdoLIBfrTuDmPwqZz5fY1ME=; b=rCivL1Q3lCxOMCbR/XBvD7iNsLZVdvMQpdERjGiYOQ9TqdO2GSFeQ/AihXxy8l/w3t K6Ey8yGjM7jaannzU8+yQRzPQIQvbrE2HljMcUE4BoJr4BcZiXSofVIyACkrzgHxbb9n Ox1iBIt/E3OySfSth+y6kdvSODDCebWAk8ILscd7526DJ9bJSfLAOoFzZakB183j1EqZ XaaNsgwdYjL6umxWCEhrmu7JHIRrnGchVb20niMvjO+N1i5F4q3bZ7+GwcKrT9LqBt3G M3f4qsfhwyCQioD/xbOOOVWTspZ2oQTAEELx7T3TdahNISbhgJAdLlzUT/Wftto1blXf lPFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JGYQOHbT; spf=pass (google.com: domain of linux-kernel+bounces-9193-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9193-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id p18-20020a170906605200b00a2549daae96si1282571ejj.895.2023.12.21.15.52.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 15:52:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-9193-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=JGYQOHbT; spf=pass (google.com: domain of linux-kernel+bounces-9193-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9193-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F3C121F2530F for ; Thu, 21 Dec 2023 23:52:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BCDB779947; Thu, 21 Dec 2023 23:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JGYQOHbT" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9547779496 for ; Thu, 21 Dec 2023 23:52:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-5e7bb1e0db8so13127227b3.0 for ; Thu, 21 Dec 2023 15:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1703202746; x=1703807546; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f4uDw1WRa5SG6czjbnHQWjQZqqBhTvomA48xZ5HM1C0=; b=JGYQOHbTu5Gxz60wEAoJB654AtQ8EeAk4+j6KhBmg1QHmoRQykAgBS4pAI6KhlK9yx /5wMO3ua50bhBqZGBzZcw72fd0xF8YJg05FTo+/sB7c3cMJZBuoQ4idgRr8F73KhiuSS 7gleeIOqQW1qoWd3/xqyl3JcuKBUySOtzOpF4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703202746; x=1703807546; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f4uDw1WRa5SG6czjbnHQWjQZqqBhTvomA48xZ5HM1C0=; b=PjWU1V8oZF2zMJLAjfxm+biXsZ1F/Ir/Zl/pzLjv7ca8b3WNwQvNc63jILbr6PkbZW O2YaYUCnIQz3T+5316qXg3Y8cROUPQUvU36MFTTU1MA2z8N+/ghkeveLGmRqxQkIXeyI qHNS2h3skst75PaMxeFj4urAlzfoji5HW9Y9vGQexzK6cWZt3Ds/8j0zs3iHCbNYL0Sd mcNYBuYV8oYdOuHIS7CjitqyqcNwKGFQaXe2Mzbf9e90Hjyf5FIH575V/Jecz2w6t9yx /K+qnErCkks13Rp441w0qzigqq/Sj47mjt3dssEouTeNkiEWo/RLWvEDl5egkpHL6aXs s4Rw== X-Gm-Message-State: AOJu0Yz4CnNtW7Jt6PThaRbLxPnuvp49KnYMhGb+nIcWWhwhTPrHycOz ak7cMcGYZdV86hPIDQYi1oOPbqGVqkc54Kq0khHrSImvHP7L X-Received: by 2002:a81:6f04:0:b0:5d7:1940:53d0 with SMTP id k4-20020a816f04000000b005d7194053d0mr557320ywc.72.1703202746631; Thu, 21 Dec 2023 15:52:26 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231220235459.2965548-1-markhas@chromium.org> <20231220165423.v2.20.I38ac58ab04985a404ed6551eb5813fa7841ef410@changeid> In-Reply-To: From: Mark Hasemeyer Date: Thu, 21 Dec 2023 16:52:15 -0700 Message-ID: Subject: Re: [PATCH v2 20/22] device property: Modify fwnode irq_get() to use resource To: Sakari Ailus Cc: LKML , AngeloGioacchino Del Regno , Krzysztof Kozlowski , Tzung-Bi Shih , Raul Rangel , Konrad Dybcio , Andy Shevchenko , Rob Herring , Sudeep Holla , Andy Shevchenko , Daniel Scally , Frank Rowand , Greg Kroah-Hartman , Heikki Krogerus , Len Brown , "Rafael J. Wysocki" , Rob Herring , devicetree@vger.kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" > Both acpi_irq_get() and of_irq_to_resourece() use EXPORT_SYMBOL_GPL() > instead. I don't see why fwnode_irq_get_resource() shouldn't do the same. > > With this changed, > > Reviewed-by: Sakari Ailus > > In fact this should have always been the case for fwnode_irq_get(). I > wouldn't mind changing that, too, in a separate patch. Sure. It looks like fwnode_iomap(), fwnode_irq_get(), fwnode_irq_get_byname(), and fwnode_graph_parse_endpoint() could all be updated. I'll add another patch with these changes unless there's a reason some of those functions shouldn't be GPL'd?