Received-SPF: pass (google.com: domain of linux-kernel+bounces-9263-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
Subject: RE: [PATCH v7 1/9] iommu: Add cache_invalidate_user op
Thread-Topic: [PATCH v7 1/9] iommu: Add cache_invalidate_user op
Thread-Index: AQHaNCP0IeMzW8Cr3UyiyyXlg+qo4rC0kdQA
Date: Fri, 22 Dec 2023 02:30:38 +0000
Message-ID: <BN9PR11MB5276CE7AE7E2FDA1D8A045298C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231221153948.119007-1-yi.l.liu@intel.com>
 <20231221153948.119007-2-yi.l.liu@intel.com>
In-Reply-To: <20231221153948.119007-2-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zQVFt/ngODD9OLvd6UDBgeKyoy2vw2t2+wqJfzJXkK6L/3kaAA8w2uuJ53t9?=
 =?us-ascii?Q?MXHhF+MJPcdFNvlAt5jwDe3QMvkKEL5wTieDYXFsOk1vi8uSLXpdF5o5yBb/?=
 =?us-ascii?Q?SNnzL7sungahGVDfVM3cyGqTBj8MoGfHGtshpgapLsXBoN9YvocqmnxeptyS?=
 =?us-ascii?Q?HdK3dRRkYBJZD0RHPppg1g+EITc/ZVmOG399rmZ1KJqswCqwvt9llmbynIl3?=
 =?us-ascii?Q?kUmXMW2JPmxJbW1IW/RJlH/iT3kJK6VQrAmp/5TSTG7uVhau/nVgLX2TtAMp?=
 =?us-ascii?Q?kVAlYoKX08BtWpIaQV/QxlcCbD6c1sKrjzCice5/4L+w+2F9sa3YTvhtDvSw?=
 =?us-ascii?Q?URBsr+GVC1tkqH1jBfSXYMdciW3FjOz+QT/NrcdlML815Hxsjjlasd3Hr1tg?=
 =?us-ascii?Q?p/GAoPJcL/g41Gtmhv+NLpR4I3P1QN3Hq8TlavEeXaYIF296qWJ80dVTyk07?=
 =?us-ascii?Q?gqCIYHLHx7DARJpt37qD8DXA++L7U8q4kV4t2yNURrxS4aK8PySuZHCgKdA3?=
 =?us-ascii?Q?laYxZjY3DBsxhte5O0OQ4jAdATf0I2yTDqP4exdG3c3IhH+oXEHcB1W964on?=
 =?us-ascii?Q?moYJyn5JaGAMVx7o52NWrRqGh+omrBk0xPY4GbCixcntT/Bl1YQU3HsCAClj?=
 =?us-ascii?Q?sCQVp9t7kW4gpSGyClAma9HklFQRjaEeBprPxVHUO1C/NzvfLu98Tu188X//?=
 =?us-ascii?Q?MiB92GHtj4b6kcGtwkVdUB3Jw9dbhlVD/jV83R+lVjJIkUSRX9SXLKBjbEDI?=
 =?us-ascii?Q?YBT/lXmst64iKiSrKFMZSpEDIquWG90nJihKtgaXCy89xpIlxOkZiEjUbVTZ?=
 =?us-ascii?Q?eAKW1Lt0TbT/dsFijJUGhFfaaWMDWjWlN3uM17TJJ7TIy1CU2E410Ypl5SWr?=
 =?us-ascii?Q?Jx1AweKSej7gNKBEqthpwnEGFAiGxtxklIgV5S/VRGjdrgmZg8h4TdXMd5cr?=
 =?us-ascii?Q?JkRB4xH0KRXJfu7fq0tobWTl0uRkiF40wYeMB0zTsdIqpPrTq2gMDe3R//b6?=
 =?us-ascii?Q?Uzd6QEut8fl0sbhHNj9ArqOwtPdHim+DUtF1W1q5ICx6h0CmHAyUH5aAFOKC?=
 =?us-ascii?Q?35Fdflu6QCaZiKcWprclQRX3M8FkmwJr6U6/YsuyLIK8QMjvysxrAVh7HB1J?=
 =?us-ascii?Q?A9bIMGC873rGe5zK7hzHSMv0qDhCQ3k3BUShP90/9batIjVjTDHWyPVk2hjQ?=
 =?us-ascii?Q?naXgyaDwnE7xqC9CcLT9lpLMb/FXGBzzdw8vfB8vEFVDFWjyym/ELkxUbp65?=
 =?us-ascii?Q?Q55wElufMoj2IaXP/JXtTiIqdiwHrq5Gehg3PC75SC7npgm6XOjU634MV52r?=
 =?us-ascii?Q?2XEYyDgYhXp1uAbv98mAB7gEpQKCgLZLpKBOWAuzSZS1RBChP6uN/Uyw2KUL?=
 =?us-ascii?Q?em/lY0EQgnBUGrLXVI7xe1BuhiDJgnWcINt+VmJxhBwoQaQh0BmzkkcfrgOX?=
 =?us-ascii?Q?UOyHxHQWa7e+nzvOh3u1l83IZULZf5pf/qlBTGLJP7Ap84n2JONxAjYhnkr6?=
 =?us-ascii?Q?hfV6ZSzBWPrZ6JBbDyk1qhlrfbpcS/Cuj1v8BaiNI2HPz6v+4JihozTqD71A?=
 =?us-ascii?Q?EHDVzVmvgPKWvHpdlhX6gsWmhdrFW0HslToUpElU?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2602e25-d1e8-4fd7-2e7c-08dc0295fc7a
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2023 02:30:38.8790
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 77olGAPO1bS/xdDuxGP/9ZexDUIvxujioWM7Ge12G2Sgb2ZC2aaBXmos/7g/k35S47o31H4YC/cTbURTxUFS9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7350
X-OriginatorOrg: intel.com

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, December 21, 2023 11:40 PM
>=20
> From: Lu Baolu <baolu.lu@linux.intel.com>
>=20
> The updates of the PTEs in the nested page table will be propagated to th=
e
> hardware caches on both IOMMU (IOTLB) and devices (DevTLB/ATC).

this is incorrect. the scope of this cmd is driver specific.

>=20
> Add a new domain op cache_invalidate_user for the userspace to flush the
> hardware caches for a nested domain through iommufd. No wrapper for it,
> as it's only supposed to be used by iommufd. Then, pass in invalidation
> requests in form of a user data array conatining a number of invalidation
> data entries.
>=20
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>  include/linux/iommu.h | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>=20
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 6291aa7b079b..5c4a17f13761 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -284,6 +284,24 @@ struct iommu_user_data {
>  	size_t len;
>  };
>=20
> +/**
> + * struct iommu_user_data_array - iommu driver specific user space data
> array
> + * @type: The data type of all the entries in the user buffer array
> + * @uptr: Pointer to the user buffer array for copy_from_user()

remove 'for copy_from_user();

> + * @entry_len: The fixed-width length of a entry in the array, in bytes

s/a/an/

> + * @entry_num: The number of total entries in the array
> + *
> + * A array having a @entry_num number of @entry_len sized entries, each

the first sentence is redundant.

> entry is
> + * user space data, an uAPI defined in include/uapi/linux/iommufd.h wher=
e
> @type
> + * is also defined as enum iommu_xyz_data_type.

I'd just say:

"The user buffer includes an array of requests with format defined=20
in include/uapi/linux/iommufd.h"