Received-SPF: pass (google.com: domain of linux-kernel+bounces-9295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
Subject: RE: [PATCH v7 4/9] iommufd/selftest: Add
 mock_domain_cache_invalidate_user support
Thread-Topic: [PATCH v7 4/9] iommufd/selftest: Add
 mock_domain_cache_invalidate_user support
Thread-Index: AQHaNCP2IX56eLXUyEyhwzd2QU9HVLC0qCWw
Date: Fri, 22 Dec 2023 03:39:40 +0000
Message-ID: <BN9PR11MB527659B1FD68C7FADEBD04548C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231221153948.119007-1-yi.l.liu@intel.com>
 <20231221153948.119007-5-yi.l.liu@intel.com>
In-Reply-To: <20231221153948.119007-5-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1huprOwxwpq9+3N027Pv0TrOrozn4/JYwFjnlrPF6birI9UdiW6MoolWYdlw?=
 =?us-ascii?Q?6DLWtz3+yQeiDNJjTBO5aEI1MXoEDwj0oArNeXzD3rT9KrxIn/UinPZUxq62?=
 =?us-ascii?Q?MHIxI+Ixb1ViDX6d2XK8Al9f3Yg4I5jPsAWZRZjRPxXrxwIaRK87WEWknUC7?=
 =?us-ascii?Q?B4vKt9IcajONtt7jZY8fGvC9K3U7kr9mjHTtha3iLoubej+9rUqnO0azZUkI?=
 =?us-ascii?Q?iIZjoAI/FwZqzOobLO5Qhx/f8CAnnlCX3lcfqZfn4bUm+vj+BxMQVdUcKCxW?=
 =?us-ascii?Q?mG4JCrfoggjWXpM1KqIO1LUe0UE1q3oc/Kjvqlsb9gcCkFMxeThtd6wW5H4G?=
 =?us-ascii?Q?ZrnIlVwE7bgcQQFRoRnioSTmwPAAlHy/jgB0S++imhkn9Zi2/EDcL22j1xJ1?=
 =?us-ascii?Q?9Hyou6UIv4U1oI+tP21ThYPpLH50+c+GdI7qtJw1ttEnL925E3rqn16EHxY1?=
 =?us-ascii?Q?PzC1aTAjhBPRSa9upb0Phni1YKm4kA7XyL//nPcKw1fiWeVi1X3P87VlHyr9?=
 =?us-ascii?Q?aAeTsBz+tUhM6l+Em0rCcy4ruXOJ1WBmklLd4njOMnOlUuAbnw+fcEHLjfVH?=
 =?us-ascii?Q?SYdskcJwr2l6ag2zaQ7IEIF2U4QX3ao02fyrLl/gSwosfrkWpBWsag3UH77n?=
 =?us-ascii?Q?+t3z/CTq8qldVoMLgYbGtw2KQAVMPB+e2ptZ7jECdpeQjV0V6A1xvlQhSqjv?=
 =?us-ascii?Q?A82i9SeyR6yCMPDizvAbKu6/9iLsL2OCmyLnAB0mYgthsDH1D4dpj943Rx8z?=
 =?us-ascii?Q?kEU4VVswvyHjeCrDFcSIgR8Wcb4vqwukhtqmEtbCphP/WB6FBvMF9KvBrFCx?=
 =?us-ascii?Q?J+4McQEbfZaa8KmGagX3Sci2USSUpQKBIc1Z5IdtcKYohABL/KESYDSnagFi?=
 =?us-ascii?Q?6zLJlDJJiN1SsgH0IOXidKIRB44UsNbfhpdV1gzXsQREywIQxKWfN2+7raeY?=
 =?us-ascii?Q?F98KiAB+lnqMfdnW4VMf79/3n/3kAzJX9RWHhtWrsA+DQ9fQXQjiuIZNo/R4?=
 =?us-ascii?Q?+dveFsHdDb+BdpA61K1zofOVa+WfXrQZn4I0O8+5O0ATA3pN6rEoA2SdLDSV?=
 =?us-ascii?Q?4/TQQ8vZvz9CISCczWKyGj2kYN6Y9OTXAjBfww68vE8oOQI5jzFYzBKtEJL4?=
 =?us-ascii?Q?6jgP2kjRtH4lCiXU3/e7pJEMBh8DRwG29lo5I9P0s2xO+6VuQBtDqhGuFekP?=
 =?us-ascii?Q?GLu87GMBJ9iGtacc29bZnV4vE8IXC8E5KD1PBdqKKSKzjUuhN4MINgax42YD?=
 =?us-ascii?Q?sV1iaNgnNGOQ36bI6/lEpMYOIT7iUWPtKfzJkVdKaL8LC0GX17ZdLb5jh/iE?=
 =?us-ascii?Q?WBM1ZGmZ0tjKD88WL+qUMHuRKq2Tg7zHLkv1bha1K3X8I09NT+1rQmAzKyw6?=
 =?us-ascii?Q?GAd9ZaylfR5gu/EyGk6PL+lRzzdRdk1t4I9n9/Ig46uCbaZgSeMkxz259emQ?=
 =?us-ascii?Q?v11a0SekpmES6vpJyuLfrsGm4S08QeLiniDWpD1JdoAEHeelfomXElBJQXTO?=
 =?us-ascii?Q?0xgyqLkSlXjjYkeuT+Jsd88Zf16AZz+TeO5kR1MU4n85NHe9E+BgZlslmGRT?=
 =?us-ascii?Q?Dv06kDXes+QZVP8MS7TFI7Ymo2irRSk4n58Y7DLr?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 693fe661-b3d4-46e1-57ab-08dc029fa163
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2023 03:39:41.0174
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BJT4Tz2YybDiDxJG2s4kkW9WffQ3L9wgFsVAkv8ilHKdgkRV/jYWUxYcsnToG6fq4nX0fTxKFp8lDh3uohmz1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4837
X-OriginatorOrg: intel.com

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, December 21, 2023 11:40 PM
> +
> +
> +		if ((inv.flags & IOMMU_TEST_INVALIDATE_FLAG_ALL) &&
> +		    (inv.flags &
> IOMMU_TEST_INVALIDATE_FLAG_TRIGGER_ERROR)) {
> +			rc =3D -EINVAL;
> +			break;
> +		}
> +

a  nit. is there a reason why the two flags can not be set together?

in concept a mock iommu error could occur in either invalidate-one
or invalidate-all.

otherwise,

Reviewed-by: Kevin Tian <kevin.tian@intel.com>