Received-SPF: pass (google.com: domain of linux-kernel+bounces-9299-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <f6302d8e-fd5f-45e1-8148-e5812c61f5c0@intel.com>
Date: Fri, 22 Dec 2023 11:56:07 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v7 9/9] iommu/vt-d: Add iotlb flush for nested domain
To: Yi Liu <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "Tian, Kevin" <kevin.tian@intel.com>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
References: <20231221153948.119007-1-yi.l.liu@intel.com>
 <20231221153948.119007-10-yi.l.liu@intel.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <20231221153948.119007-10-yi.l.liu@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eitVdlB2RlYzRjAzUnVtSjRBZklqRElmTEhKdzRUNkQ4VEMzZVRRak1pUE1z?=
 =?utf-8?B?cjBPNzlZNVhneW84UjVvdjB3VnRudmdOMCtwRmJadTdHMHdVeUljVllkVi9N?=
 =?utf-8?B?THJrakg3bXJ0UmQ0WWlPK1pDL3IzVkR1bm5rc1NoM1RTSmw1aEpkei91b1FO?=
 =?utf-8?B?TmhHODVZTG81K0N5YjN3K25hSkR6TEdDZGJKV1JWNnUzSzZmdHh3Z0Zjb0Ro?=
 =?utf-8?B?amZWNHNxT1huaXNXWHkvLzhOVERaU1RucDhpYXdnTmhLWjEyUng1TThWMERa?=
 =?utf-8?B?WkxrMzlNRGlIZWxXNmN0d0hVVjhra3pTeUVtRUpBdUlCeGxKKzJRekYxQytv?=
 =?utf-8?B?aE1nWXBwQXFvL1lTSi81M3ZHa0xLTlRIYjgvU2ljZXZiV3RZVWwwR2FYRlQ0?=
 =?utf-8?B?aWY1VnYyRWd3S0paMHpuT1VNQ3RWS21RMEpTc1Y0azZrL09XNkhacExVTHhZ?=
 =?utf-8?B?M0ViajI3OVFIVmNhRE1WZ3RMOXh5NWdFRDUwOXd6YnZLRStkaDlrYS96MldH?=
 =?utf-8?B?RkpDSHg1d2I4NHB0MHZmSC92N2hQUWpabnljZUJEeE1pL0dud0YzTkRpSnV0?=
 =?utf-8?B?Y3NNMjMxVGJCT3ZpbS9HWTQvUUtCSHBUcEJYSUpqdTdnaFpnSm1KdDBKejhu?=
 =?utf-8?B?TnNsc3ViQTluS0JVUkNvazFvRTBSb2FQVlF0OXFPNjc4dG4xUHVpYjd4MGJV?=
 =?utf-8?B?czdncUJQRUREeFB1Y1o3ZUg2NU01UVlVSTNLOCt6Z3RGNnVZNEh0dzVyQ1Z5?=
 =?utf-8?B?TUcxUHYvelM0Vlhsd09ZRVRtOVVZOURmVXFRRk9lSVJHTVRCY0p2UGtIc2Y0?=
 =?utf-8?B?T0xabXdZOHBleC9Pb0Uvckh2cVdQME1IWVY0NkxkQmFaT2FqUkxPNzVhak9E?=
 =?utf-8?B?T0J6dGRMeG9MYWQyNmdVejBmMnNkOG8wTGQ5N0ptempSamdPUFhMczJWM0Ny?=
 =?utf-8?B?eEJueEVaVGcvaUZlOW1iMmx5dUM4WEp4ZnUvcW9HNXpnbVZpTnlPUVhOUmdW?=
 =?utf-8?B?OXVFVjVHamd0UjVJMnFnUUtyMkVrcGQxeDhZa2UwdFpiRDdueFBYQlpZSG5T?=
 =?utf-8?B?UFA5TUx4K1YvY1ROcWdQWU9laGsvUFBsSDR4MEp0bFIvQmpmMmJpUWVZL0dy?=
 =?utf-8?B?RVdpQWMrdVNrMEJlMnN5UC91U2Q4RU94Q3lPU1FZSmNIbW1Md05lWlBTMnJT?=
 =?utf-8?B?azI2bmtta3NlbVh3RUZZc1RqeDBwNnRTSEFXTWdRU1llUkdpWi9SYzgwWG4y?=
 =?utf-8?B?MnlGdHRsM25uNGVobm9YanJ0SWhhdUJIZ2poL1QyUUFiSFQ2QllGTVBCeTJy?=
 =?utf-8?B?OGQ2U2ZTaWVTS1V4NTUyeS9NRTlsR0tVYlpTczdTaS83WEcxQVg2cExxdmNZ?=
 =?utf-8?B?UWd4eUZKQ25kL1VuVktyamw3ZkppNmNYNTBSemV4emE2aDAwemRMRXJ1SnZl?=
 =?utf-8?B?NDMwNSswMWhMMDRyVThzNnRaSEUzcytOOEd2ODA4OVZiRkswa1AwTXAyZCs4?=
 =?utf-8?B?MFhUVmRmL3hMZUxwSE1wbGc5KzQxcjU5anhlcXg3TEFUMUEvSE5RM1NjaTZ1?=
 =?utf-8?B?aTBBMnFzZXdFa0srRFErT1FFUHFiZHhzcFgrcUxKbDVWLytuSVlPTERmbVYv?=
 =?utf-8?B?QkdWcmVSbENlcGRpTzdEOGlMZVpNZzNMNUlUVFJFMmFnV3lmRjRKQm9taWV1?=
 =?utf-8?B?R1p6b3dkOEJwNUR1WDI5OTNucVFMaVUzVXk3YTU0aXJsVm9nOUc0SGw0SFdC?=
 =?utf-8?B?dkZKZ3l4SlgwM0RacXZheWFmOGZseldUcmZPanFZWlBZVzRmSUpxRXZRNVBV?=
 =?utf-8?B?ZTdPZHFJU0xPSlRmYnpsanhMQURWL0FXMWJGZEIrVHM0NWxzR3RRdjJMOC9T?=
 =?utf-8?B?L1FsNjcySC91bmVtSFYxc3pMWXhRdWp5U05GM21vTHNyR3BSQUE1cnhLUXB0?=
 =?utf-8?B?eFdlQlZ6ajRBbFNDc0ZXZHhRd3I5VEZWbTh3bGdBdDhLRzEwZHduQ0NQd2sy?=
 =?utf-8?B?NHQranpQOEFqWHJVK1dPTjNzNnY5RHYxeEc2RnNnOE1pcyt6d3N5dFRuQ1Jz?=
 =?utf-8?B?aldNMEZEMUhiTTJxU0VTT2YwZUU2VFhKcnNQL3piUVZZeXdhTHNLQXROSW02?=
 =?utf-8?B?STJjQ2RlRlFPSEJiaEtSZkZoUGtlbVk4MExUZ3R4STVwaGlpNWpWRUlUelVE?=
 =?utf-8?B?bVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 216ce2f9-e851-4194-12e0-08dc02a1f6d1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 03:56:23.7382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3pwHSY8IsLVySvaOd18Udln3K+WrJzC7XUu/ozbPX0jQJJmKg2I3XGHP6W2dW5liUbd0Qrqm8dvhKOdtk4ocsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5048
X-OriginatorOrg: intel.com

On 12/21/2023 11:39 PM, Yi Liu wrote:
> From: Lu Baolu <baolu.lu@linux.intel.com>
>
> This implements the .cache_invalidate_user() callback to support iotlb
> flush for nested domain.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Co-developed-by: Yi Liu <yi.l.liu@intel.com>
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> ---
>   drivers/iommu/intel/nested.c | 116 +++++++++++++++++++++++++++++++++++
>   1 file changed, 116 insertions(+)
>
> diff --git a/drivers/iommu/intel/nested.c b/drivers/iommu/intel/nested.c
> index b5a5563ab32c..c665e2647045 100644
> --- a/drivers/iommu/intel/nested.c
> +++ b/drivers/iommu/intel/nested.c
> @@ -73,9 +73,125 @@ static void intel_nested_domain_free(struct iommu_domain *domain)
>   	kfree(to_dmar_domain(domain));
>   }
>   
> +static void nested_flush_pasid_iotlb(struct intel_iommu *iommu,
> +				     struct dmar_domain *domain, u64 addr,
> +				     unsigned long npages, bool ih)
> +{
> +	u16 did = domain_id_iommu(domain, iommu);
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&domain->lock, flags);
> +	if (!list_empty(&domain->devices))
> +		qi_flush_piotlb(iommu, did, IOMMU_NO_PASID, addr,
> +				npages, ih, NULL);
> +	spin_unlock_irqrestore(&domain->lock, flags);
> +}
> +
> +static void nested_flush_dev_iotlb(struct dmar_domain *domain, u64 addr,
> +				   unsigned mask, u32 *fault)
> +{
> +	struct device_domain_info *info;
> +	unsigned long flags;
> +	u16 sid, qdep;
> +
> +	spin_lock_irqsave(&domain->lock, flags);
> +	list_for_each_entry(info, &domain->devices, link) {
> +		if (!info->ats_enabled)
> +			continue;
> +		sid = info->bus << 8 | info->devfn;
> +		qdep = info->ats_qdep;
> +		qi_flush_dev_iotlb(info->iommu, sid, info->pfsid,
> +				   qdep, addr, mask, fault);
> +		quirk_extra_dev_tlb_flush(info, addr, mask,
> +					  IOMMU_NO_PASID, qdep);
> +	}
> +	spin_unlock_irqrestore(&domain->lock, flags);
> +}
> +
> +static void intel_nested_flush_cache(struct dmar_domain *domain, u64 addr,
> +				     unsigned long npages, u32 *error)
> +{
> +	struct iommu_domain_info *info;
> +	unsigned long i;
> +	unsigned mask;
> +	u32 fault = 0;
> +
> +	if (npages == U64_MAX)
> +		mask = 64 - VTD_PAGE_SHIFT;
> +	else
> +		mask = ilog2(__roundup_pow_of_two(npages));
> +
> +	xa_for_each(&domain->iommu_array, i, info) {
> +		nested_flush_pasid_iotlb(info->iommu, domain, addr, npages, 0);
> +
> +		if (domain->has_iotlb_device)
> +			continue;

Shouldn't this be if (!domain->has_iotlb_device)?
> +
> +		nested_flush_dev_iotlb(domain, addr, mask, &fault);
> +		if (fault & (DMA_FSTS_ITE | DMA_FSTS_ICE))
> +			break;
> +	}
> +
> +	if (fault & DMA_FSTS_ICE)
> +		*error |= IOMMU_HWPT_INVALIDATE_VTD_S1_ICE;
> +	if (fault & DMA_FSTS_ITE)
> +		*error |= IOMMU_HWPT_INVALIDATE_VTD_S1_ITE;
> +}
> +
> +static int intel_nested_cache_invalidate_user(struct iommu_domain *domain,
> +					      struct iommu_user_data_array *array)
> +{
> +	struct dmar_domain *dmar_domain = to_dmar_domain(domain);
> +	struct iommu_hwpt_vtd_s1_invalidate inv_entry;
> +	u32 processed = 0;
> +	int ret = 0;
> +	u32 index;
> +
> +	if (array->type != IOMMU_HWPT_INVALIDATE_DATA_VTD_S1) {
> +		ret = -EINVAL;
> +		goto out;
> +	}
> +
> +	for (index = 0; index < array->entry_num; index++) {
> +		ret = iommu_copy_struct_from_user_array(&inv_entry, array,
> +							IOMMU_HWPT_INVALIDATE_DATA_VTD_S1,
> +							index, inv_error);
> +		if (ret)
> +			break;
> +
> +		if (inv_entry.flags & ~IOMMU_VTD_INV_FLAGS_LEAF) {
> +			ret = -EOPNOTSUPP;
> +			break;
> +		}
> +
> +		if (!IS_ALIGNED(inv_entry.addr, VTD_PAGE_SIZE) ||
> +		    ((inv_entry.npages == U64_MAX) && inv_entry.addr)) {
> +			ret = -EINVAL;
> +			break;
> +		}
> +
> +		inv_entry.inv_error = 0;
> +		intel_nested_flush_cache(dmar_domain, inv_entry.addr,
> +					 inv_entry.npages, &inv_entry.inv_error);
> +
> +		ret = iommu_respond_struct_to_user_array(array, index,
> +							 (void *)&inv_entry,
> +							 sizeof(inv_entry));
> +		if (ret)
> +			break;
> +
> +		processed++;
> +	}
> +
> +out:
> +	array->entry_num = processed;
> +	return ret;
> +}
> +
>   static const struct iommu_domain_ops intel_nested_domain_ops = {
>   	.attach_dev		= intel_nested_attach_dev,
>   	.free			= intel_nested_domain_free,
> +	.cache_invalidate_user	= intel_nested_cache_invalidate_user,
>   };
>   
>   struct iommu_domain *intel_nested_domain_alloc(struct iommu_domain *parent,