Received-SPF: pass (google.com: domain of linux-kernel+bounces-9309-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Liu, Yi L" <yi.l.liu@intel.com>, "joro@8bytes.org" <joro@8bytes.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "robin.murphy@arm.com" <robin.murphy@arm.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC: "cohuck@redhat.com" <cohuck@redhat.com>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "mjrosato@linux.ibm.com"
	<mjrosato@linux.ibm.com>, "chao.p.peng@linux.intel.com"
	<chao.p.peng@linux.intel.com>, "yi.y.sun@linux.intel.com"
	<yi.y.sun@linux.intel.com>, "peterx@redhat.com" <peterx@redhat.com>,
	"jasowang@redhat.com" <jasowang@redhat.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "lulu@redhat.com" <lulu@redhat.com>,
	"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>, "Duan,
 Zhenzhong" <zhenzhong.duan@intel.com>, "joao.m.martins@oracle.com"
	<joao.m.martins@oracle.com>, "Zeng, Xin" <xin.zeng@intel.com>, "Zhao, Yan Y"
	<yan.y.zhao@intel.com>, "j.granados@samsung.com" <j.granados@samsung.com>
Subject: RE: [PATCH v7 7/9] iommu/vt-d: Allow qi_submit_sync() to return the
 QI faults
Thread-Topic: [PATCH v7 7/9] iommu/vt-d: Allow qi_submit_sync() to return the
 QI faults
Thread-Index: AQHaNCP7GmW4equSLUGDinfwDm7MnLC0tG4A
Date: Fri, 22 Dec 2023 04:23:23 +0000
Message-ID: <BN9PR11MB5276468811C5113427D4CA6F8C94A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231221153948.119007-1-yi.l.liu@intel.com>
 <20231221153948.119007-8-yi.l.liu@intel.com>
In-Reply-To: <20231221153948.119007-8-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YDZkUyFvPZCL/KDFoisxtgVTl49YEVQqhti+NmHRTdobdmCmbNyKfVmiMi72?=
 =?us-ascii?Q?cZiZwdEd97pdLKbnYfUXpOJExg8gfIHrFk0xC4SgQY240LuXESON2TflzteV?=
 =?us-ascii?Q?jpyqLq4nUmOPll/jTj/UOxOHA0uvop9BwFH4pwtKNxtKpE80xSo7CLS3O5LW?=
 =?us-ascii?Q?FLQ69DaCXNZL7x3JGOpGHvJHMK8FnXxZ2JH/+TzTy7F+INq3NnrCkuyK3wf/?=
 =?us-ascii?Q?iwoIrnbTfddGpgV5ZUttNch6wCqaF9SuurdxDIYtff+c8AKVFEgh8Hml7Q8Y?=
 =?us-ascii?Q?4XrwmKpsm1M0e51uJ4pqlvis+94APrMSPC9zL1xPoBMGQuWhELAWqw0F8iy3?=
 =?us-ascii?Q?L0yy9KNHN6DKtxqyRGT0syh81iwapPPDxzodyvYuzBL7zDX0lbeJ0yEz+SpU?=
 =?us-ascii?Q?ZFB6oSQxK/+s/4RRWo4SRYZ6ejpGt+0gLYihWDq+oUd2+3KJJ6Chxx9jcufH?=
 =?us-ascii?Q?lurKVyyP0np1kTujtTZq6IQWISQj6RExCPdh+GKF4AfV3AtF9T/gZdtlsAuJ?=
 =?us-ascii?Q?OAXBq68Vt/LqBg6EjyD0JwzRQbBMde6kkcva12hCjuyUbuFLBMYs2CFP070X?=
 =?us-ascii?Q?den1FnQYkJE+xcewKbLVzY7N5TtJ4nE99/5kIstABp6UWIYqJ04ToC4t3rpe?=
 =?us-ascii?Q?SMrJ1fYYtUxtL/alTv/RvBqjXQkpfKjb/rU323raNpI6w+8ZTn784AuHyC4f?=
 =?us-ascii?Q?IabjfRbqgKo2DWfnbZyxYHDQaceCP7nFlmUTP9CigP1EKdpejdIAYIN6ypWO?=
 =?us-ascii?Q?axd5QRU+7a4lkZh1dTK7wgdLrI5Ds+v9YoDLaLR2rmc5N1ACHMwhgkqeCB0P?=
 =?us-ascii?Q?8LDAw2/a8KKSQ8Yu50ZAo0pt2fsvcjYkh9jidsQ3UP8InKWrlBn9fDucVQmP?=
 =?us-ascii?Q?rn6/JQkPWht4Yv87rnsZQFAVxkjpLcTWRSX/AsrHk+5jbvOR+ecXBy+RR23w?=
 =?us-ascii?Q?42fACpYq2EfsjFP0zT3alwdvrDfw8P03Ly53yi9HOSpt2YypNYYdzTRmdeOT?=
 =?us-ascii?Q?k+bn7M8hNkbcdzhBM4Ih1CS0wEZTWx3WhKzPKdS80GKBav0g36x5tMGGC9fq?=
 =?us-ascii?Q?LfGKrf632/R/z7uD9gDbLIuAx5LfzeTBMeGqYGh2e0jH/QEc4pTjXm+eZIVz?=
 =?us-ascii?Q?wa5BQ1HlNqLLIPOcyNVhYfeKsRJAAtT25+/W+u5r8b/4BAEua+Z6236069h1?=
 =?us-ascii?Q?pKIG8JO8EGoNc2ENBo3nItZuKvKdL8BwZH+jMonF8YpwTF61mBcuLqmh7mZ/?=
 =?us-ascii?Q?3QDY7sq/UzZXPxdYE8XOhkzXdifnoc/tTxff5IWbFhQ5Gv7HzTk2HHr+Omu3?=
 =?us-ascii?Q?wZGDF/bQVEcOOKniWsp7NKf1MH/5ZIjBoVr5ysm4j05SmMZ4gTQCh+hzUKem?=
 =?us-ascii?Q?4f/NFE9dj6qbABq5rUCnx3fgBMx38kYAGa7+jSpeUho7ydshPFB+Jqt7IQgP?=
 =?us-ascii?Q?yXTMq7hoSETYFTc521PiKmI4V8U1qF8ki263uFIX+pa7rsdlPl8go9Iqnoh2?=
 =?us-ascii?Q?FucNY+o12Q0gVnjZ18lNu8wiOZdzqBlJIPXk7Jate99z6tKMWk0gkpv6CQUx?=
 =?us-ascii?Q?nCKuszOc8Sh1bsqOnm8pfNYNzIN80Y8AlOH+ZF5M?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7648c05c-90e5-4c4e-e44d-08dc02a5bc92
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2023 04:23:23.5846
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gCMQHH1Re0kQZ5eRp7ecMR74KVQAFXrn4raMo6tkgLAEIz2dmksz4Umg1ZpUyXAmzNRqgsxBNTu3D4/iczuqJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4859
X-OriginatorOrg: intel.com

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, December 21, 2023 11:40 PM
>
> +	fault &=3D DMA_FSTS_IQE | DMA_FSTS_ITE | DMA_FSTS_ICE;
> +	if (fault) {
> +		if (fsts)
> +			*fsts |=3D fault;

do we expect the fault to be accumulated? otherwise it's clearer to
just do direct assignment instead of asking for the caller to clear
the variable before invocation.

the rest looks good:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>