Received-SPF: pass (google.com: domain of linux-kernel+bounces-9362-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 21 Dec 2023 21:14:52 -0800 (PST)
From: David Rientjes <rientjes@google.com>
To: Yu Zhao <yuzhao@google.com>
cc: Henry Huang <henry.hj@antgroup.com>, yuanchu@google.com, 
    akpm@linux-foundation.org, 
    =?UTF-8?B?6LCI6Ym06ZSL?= <henry.tjf@antgroup.com>, 
    linux-kernel@vger.kernel.org, linux-mm@kvack.org, 
    =?UTF-8?B?5pyx6L6JKOiMtuawtCk=?= <teawater@antgroup.com>
Subject: Re: [RFC v2] mm: Multi-Gen LRU: fix use mm/page_idle/bitmap
In-Reply-To: <CAOUHufZwXBs4x7GeawrjZNEwTBdV=mf-DYrZuF4j=10URHwQTw@mail.gmail.com>
Message-ID: <931f2e6d-30a1-5f10-e879-65cb11c89b85@google.com>
References: <CAJj2-QGqDWGVHEwU+=8+ywEAQtK9QKGZCOhkyEgp8LEWbXDggQ@mail.gmail.com> <20231222024458.12441-1-henry.hj@antgroup.com> <CAOUHufZwXBs4x7GeawrjZNEwTBdV=mf-DYrZuF4j=10URHwQTw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="2003067076-520779642-1703222093=:711362"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--2003067076-520779642-1703222093=:711362
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Thu, 21 Dec 2023, Yu Zhao wrote:

> > Thanks for replyting.
> >
> > On Fri, Dec 22, 2023 at 07:16 AM Yuanchu Xie wrote:
> > > How does the shared memory get charged to the cgroups?
> > > Does it all go to cgroup A or B exclusively, or do some pages get
> > > charged to each one?
> >
> > Some pages get charged to cgroup A, and the other get charged to cgroup B.
> 
> Just a side note:
> We can potentially "fix" this, but it doesn't mean this is a good
> practice. In fact, I think this is an anti-pattern to memcgs:
> resources should be preferably isolated between memcgs, or if a
> resource has to be shared between memcgs, it should be charged in a
> predetermined way, not randomly to one of the memcgs sharing it.
> 

Very interesting thread, a few questions for Henry to understand the 
situation better:

 - is the lack of predeterministic charging a problem for you?  Are you
   initially faulting it in a manner that charges it to the "right" memcg
   and the refault of it after periodic reclaim can causing the charge to
   appear "randomly," i.e. to whichever process happened to access it 
   next?

 - are pages ever shared between different memcg hierarchies?  You 
   mentioned sharing between processes in A and A/B, but I'm wondering
   if there is sharing between two different memcg hierarchies where root
   is the only common ancestor?

 - do you anticipate a shorter scan period at some point?  Proactively
   reclaiming all memory colder than one hour is a long time :)  Are you
   concerned at all about the cost of doing your current idle bit 
   harvesting approach becoming too expensive if you significantly reduce
   the scan period?

 - is proactive reclaim being driven by writing to memory.reclaim, by
   enforcing a smaller memory.high, or something else?

Looking forward to learning more about your particular issue.
--2003067076-520779642-1703222093=:711362--