Received-SPF: pass (google.com: domain of linux-kernel+bounces-9434-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: lizhe.67@bytedance.com
To: dianders@chromium.org
Cc: akpm@linux-foundation.org,
	john.ogness@linutronix.de,
	kernelfans@gmail.com,
	lecopzer.chen@mediatek.com,
	linux-kernel@vger.kernel.org,
	lizhe.67@bytedance.com,
	pmladek@suse.com
Subject: Re: [PATCH 2/4] watchdog/softlockup: Use printk_cpu_sync_get_irqsave() to serialize reporting
Date: Fri, 22 Dec 2023 15:13:41 +0800
Message-ID: <20231222071341.37228-1-lizhe.67@bytedance.com>
In-Reply-To: <20231220131534.2.Ia5906525d440d8e8383cde31b7c61c2aadc8f907@changeid>
References: <20231220131534.2.Ia5906525d440d8e8383cde31b7c61c2aadc8f907@changeid>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

On Wed, 20 Dec 2023 13:15:35 -0800, dianders@chromium.org wrote: 

>diff --git a/kernel/watchdog.c b/kernel/watchdog.c
>index b4fd2f12137f..526041a1100a 100644
>--- a/kernel/watchdog.c
>+++ b/kernel/watchdog.c
>@@ -454,7 +454,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
> 	struct pt_regs *regs = get_irq_regs();
> 	int duration;
> 	int softlockup_all_cpu_backtrace = sysctl_softlockup_all_cpu_backtrace;
>-	static DEFINE_SPINLOCK(watchdog_output_lock);
>+	unsigned long flags;
> 
> 	if (!watchdog_enabled)
> 		return HRTIMER_NORESTART;
>@@ -521,7 +521,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
> 		/* Start period for the next softlockup warning. */
> 		update_report_ts();
> 
>-		spin_lock(&watchdog_output_lock);
>+		printk_cpu_sync_get_irqsave(flags);
> 		pr_emerg("BUG: soft lockup - CPU#%d stuck for %us! [%s:%d]\n",
> 			smp_processor_id(), duration,
> 			current->comm, task_pid_nr(current));
>@@ -531,7 +531,7 @@ static enum hrtimer_restart watchdog_timer_fn(struct hrtimer *hrtimer)
> 			show_regs(regs);
> 		else
> 			dump_stack();
>-		spin_unlock(&watchdog_output_lock);
>+		printk_cpu_sync_put_irqrestore(flags);
> 
> 		if (softlockup_all_cpu_backtrace) {
> 			trigger_allbutcpu_cpu_backtrace(smp_processor_id());
>-- 

Reviewed-by: Li Zhe <lizhe.67@bytedance.com>