Received-SPF: pass (google.com: domain of linux-kernel+bounces-9483-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 22 Dec 2023 16:13:42 +0800
From: Oliver Sang <oliver.sang@intel.com>
To: David Hildenbrand <david@redhat.com>
CC: Andrew Morton <akpm@linux-foundation.org>, Matthew Wilcox
	<willy@infradead.org>, <oe-lkp@lists.linux.dev>, <lkp@intel.com>, "Linux
 Memory Management List" <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<oliver.sang@intel.com>
Subject: Re: [linux-next:master] [mm] bbcbf2a3f0: kernel_BUG_at_mm/memory.c
Message-ID: <ZYVFNvyG9uX2Q9do@xsang-OptiPlex-9020>
References: <202312192319.fa8f5709-oliver.sang@intel.com>
 <20231220141135.cb4241442b657104f0aeae34@linux-foundation.org>
 <ZYQgGmYNfF8j4JqL@xsang-OptiPlex-9020>
 <e0e7d631-0af4-46fc-b606-78de07ebb88a@redhat.com>
 <20231221135833.92b8b2a97b28ad0545977f6c@linux-foundation.org>
 <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <6a8f2110-fa91-4c10-9eae-88315309a6e3@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8dewVbaUFxCXMNi2IPvV8hv+ghBB0p1tSaBxkAxT78wfawWb0KzDwu9mUT8C?=
 =?us-ascii?Q?VX/dC5K+o0W6MW7sE6dQVa/e7Vln1FU6zZLdi8tMaRbLA+9U10hQveRjJljA?=
 =?us-ascii?Q?OByyZ/nUFulTk6fJzKSsMQxtqAd6BrJkJhU5Ykq3AtDV9PMSkUT+eylDQVjo?=
 =?us-ascii?Q?Gmr3wwivTce4/0Miys9ZWeW1J+ftqD+6Xz/09CDaU+ElwN4n2I9ASveDwIY/?=
 =?us-ascii?Q?bryOqZ8u/cniuR8o439FLS0EsvFvJ18zPIvPNErzxEwaN4AqMgolg/ClSnLc?=
 =?us-ascii?Q?+t3tw8NjtutswiKtURGVWspmWOWDVAK/hccjgBAznkSUv/mwjhQPWW2BTZZp?=
 =?us-ascii?Q?953HSGxdEwrPCxIZzhxEL7Jf8DdNGhcBqECvrZkQODl3D5/2n8KnYLGuWb1w?=
 =?us-ascii?Q?dnBzTAlifwC73pYpxcqh3rnIl7IFosag4NLku6d/8kU39G407Px8qePlGfzC?=
 =?us-ascii?Q?atrZCd2YWD0uIJBRMi9fqtsJf21qs3HBDsUPHlbRVhUgQkpreuvtMHZ/c33B?=
 =?us-ascii?Q?6QLOaXOenQTj/CxeTLudqdQ7EwA63W+2B1BiC28mLvQ9nEmmFjGKmWjluIOV?=
 =?us-ascii?Q?WC+qew2wkFg3fb60gfY1CJzOzSrM0zZHoqxCdMSFRc54bDjSpItpAJbtjWs8?=
 =?us-ascii?Q?SqPgKIOVv4Q/MEPyklLzi+/NXWY6M09o2OUXMSE+JpgX6I1Ad5yrUdiwSx3m?=
 =?us-ascii?Q?Ysxa4CrLeQKWArNJ2e068faxCNykXYwcXS/KwkYRBqA02ki4FIE9bxfJ2mNZ?=
 =?us-ascii?Q?3CP/K3GT3DOLgIx9c03SG3Xxkuda7oSEAIf1SfpZC9G0UBPXeGy40LSiuxXZ?=
 =?us-ascii?Q?JgGhCejDUr+wOS5EsvZXluGECWhhFCcs1H5SKejgkHsvc3srnEE285p/yWyH?=
 =?us-ascii?Q?OOqXgymlOGScfc3jZaHsEa/kenGHIq7DX9ccQyxp5UIIX9l6O7mY2xWjj6f1?=
 =?us-ascii?Q?OV7z4Gp6+3t49mlUZ7XfC1gn51IBkzd7ND57gzwVgBEQ1aSyU7QN5w8jth98?=
 =?us-ascii?Q?C60+g1bjIZsl30q721WZfulh7tYaj4+sy+oNm1xhbUq/Ng+JvaiW1uPyvBTp?=
 =?us-ascii?Q?JdWUC+Dl7FYVU+G9++gldn0UOq+5WBhxLqvlVPx/7HE1EstWO3T75a9uXhTQ?=
 =?us-ascii?Q?f/hK7xxWgqlwzBXGry60uZuHW0MCEdE/FBNdKsjKtFncEQmH7lzAt4CL+eae?=
 =?us-ascii?Q?31WMLO8RBETvWme1fgnStmfUvOLgNtEnIvhy1ZKBIWEdAyokAj7Cr+AiIVYy?=
 =?us-ascii?Q?YNU3H8Y1YROy6K32+0hQmL+3QGQeSxihcmWAIH5LU1RCnvsP8PKQ8G+E+ia/?=
 =?us-ascii?Q?+A+Ew9d8fHXSV+i1OdGtNJy6GfqajUCoC0yKYBMZpjEm292iw0LP+CKjJu5W?=
 =?us-ascii?Q?9NaGU7WXvw8e6yX8eGvAMTNOnCP0JuCyLi4DG7IBr1wlyo6KZAoJgmkQP02J?=
 =?us-ascii?Q?isr10nJA83c8hk+uVEGPxKB+9X8tX8jTBPY7VXY7uP+4tOZnAll7iwWzMC5l?=
 =?us-ascii?Q?sCFGVMvL/JTGsClE/fVTLwdgjJnSqc41h4jjR8M4R4JZVIia6PGUHriqqtls?=
 =?us-ascii?Q?kVi7uVVQ/jPU2WBePQhAk2Tql5Mb6gvIPjCDdb3hC0Qx0Q1b9DoWu+LRp667?=
 =?us-ascii?Q?uw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 945b15b6-0283-46db-16d3-08dc02c5ee07
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2023 08:13:50.6299
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fkqmldEUBsyuwkXBXY7ddc1BeTSa895r0dkVIK7bbq/FNEQXsHH57f87/yfQvZZCl8YVTcqTfRWcSk2/pl07Dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6703
X-OriginatorOrg: intel.com

hi, David,

On Thu, Dec 21, 2023 at 11:07:21PM +0100, David Hildenbrand wrote:
> On 21.12.23 22:58, Andrew Morton wrote:
> > On Thu, 21 Dec 2023 12:32:04 +0100 David Hildenbrand <david@redhat.com> wrote:
> > 
> > > On 21.12.23 12:23, Oliver Sang wrote:
> > > > hi, Andrew Morton,
> > > > 
> > > > On Wed, Dec 20, 2023 at 02:11:35PM -0800, Andrew Morton wrote:
> > > > > On Tue, 19 Dec 2023 23:46:50 +0800 kernel test robot <oliver.sang@intel.com> wrote:
> > > > > 
> > > > > > 
> > > > > > 
> > > > > > Hello,
> > > > > > 
> > > > > > kernel test robot noticed "kernel_BUG_at_mm/memory.c" on:
> > > > > > 
> > > > > > commit: bbcbf2a3f05f74f9d268eab57abbdce6a65a94ad ("mm: convert ksm_might_need_to_copy() to work on folios")
> > > > > 
> > > > > I assume this is a bisection result, so it's quite repeatable?
> > > > 
> > > > yes, we bisect to this commit, it's quite repeatable:
> > > > 
> > > > ddd06bb63d9793ce bbcbf2a3f05f74f9d268eab57ab
> > > > ---------------- ---------------------------
> > > >          fail:runs  %reproduction    fail:runs
> > > >              |             |             |
> > > >              :6          100%           6:6     dmesg.Kernel_panic-not_syncing:Fatal_exception
> > > >              :6          100%           6:6     dmesg.RIP:do_swap_page
> > > >              :6          100%           6:6     dmesg.invalid_opcode:#[##]
> > > >              :6          100%           6:6     dmesg.kernel_BUG_at_mm/memory.c
> > > > 
> > > > 
> > > 
> > > Can you try with the snipped I sent? Please let me know if you need a
> > > full patch for testing purposes.
> > 
> > I think a full patch would be better, please.
> > 

we cannot reproduce the issue reported previously after applying below patch.
Thanks

> 
> From b82e309096abde6c0f24bba50a281e8d3855c132 Mon Sep 17 00:00:00 2001
> From: David Hildenbrand <david@redhat.com>
> Date: Thu, 21 Dec 2023 23:04:30 +0100
> Subject: [PATCH] Fixup: mm: convert ksm_might_need_to_copy() to work on folios
> 
> We must only adjust the page if the folio changed. Otherwise, if we
> had a large folio in the swapcache and the folio didn't change, we'd
> suddenly change the page to-be-mapped.
> 
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202312192319.fa8f5709-oliver.sang@intel.com
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  mm/memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 149f779910fd5..2f9668d357f5c 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3952,7 +3952,8 @@ vm_fault_t do_swap_page(struct vm_fault *vmf)
>  			folio = swapcache;
>  			goto out_page;
>  		}
> -		page = folio_page(folio, 0);
> +		if (folio != swapcache)
> +			page = folio_page(folio, 0);
>  		/*
>  		 * If we want to map a page that's in the swapcache writable, we
> -- 
> 2.43.0
> 
> 
> -- 
> Cheers,
> 
> David / dhildenb
>