Received-SPF: pass (google.com: domain of linux-kernel+bounces-9520-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 22 Dec 2023 09:52:59 +0100
From: Nam Cao <namcao@linutronix.de>
To: Ryan England <rcengland@gmail.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>, Florian Schilhabel
 <florian.c.schilhabel@googlemail.com>, Greg Kroah-Hartman
 <gregkh@linuxfoundation.org>, linux-staging@lists.linux.dev,
 linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH v2] staging: rtl8712: fix open parentheses alignment
Message-ID: <20231222095259.75f145cf@namcao>
In-Reply-To: <ZYSemFbzTlgLROMc@kernel.ryanengland.xyz>
References: <ZYSemFbzTlgLROMc@kernel.ryanengland.xyz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 21 Dec 2023 20:22:48 +0000 Ryan England <rcengland@gmail.com> wrote:

> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Ryan England <rcengland@gmail.com>
> ---
> Made corrections give the 100 line limit. Resending v2 as no change was
> made other than including this comment below ---. Thank you for the
> correction. Here's to learning with every submission.
> 
>  drivers/staging/rtl8712/os_intfs.c            |   3 +-
>  drivers/staging/rtl8712/rtl8712_efuse.c       |   9 +-
>  drivers/staging/rtl8712/rtl8712_recv.c        |   3 +-
>  drivers/staging/rtl8712/rtl8712_xmit.c        |  60 +++---
>  drivers/staging/rtl8712/rtl871x_cmd.c         | 159 +++++---------
>  drivers/staging/rtl8712/rtl871x_cmd.h         |  37 ++--
>  drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 203 +++++++-----------
>  7 files changed, 173 insertions(+), 301 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c
> index b18e6d9c832b..7554613fe7e1 100644
> --- a/drivers/staging/rtl8712/os_intfs.c
> +++ b/drivers/staging/rtl8712/os_intfs.c
> @@ -221,8 +221,7 @@ struct net_device *r8712_init_netdev(void)
>  
>  static u32 start_drv_threads(struct _adapter *padapter)
>  {
> -	padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s",
> -					  padapter->pnetdev->name);
> +	padapter->cmd_thread = kthread_run(r8712_cmd_thread, padapter, "%s", padapter->pnetdev->name);

Your description claims to fix "CHECK: Alignment should match open
parenthesis", but this one is already aligned, isn't it?

Note that, because you CAN you 100 characters, does not mean you MUST use 100
characters.

Best regards,
Nam