Received-SPF: pass (google.com: domain of linux-kernel+bounces-9595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 22 Dec 2023 11:30:47 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Sean Young <sean@mess.org>, Thierry Reding <thierry.reding@gmail.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>, 
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11] pwm: bcm2835: Allow PWM driver to be used in atomic
 context
Message-ID: <fuku3b5ur6y4k4refd3vmeoenzjo6mwe3b3gtel34rhhhtvnsa@w4uktgbqsc3w>
References: <20231220142426.1275052-1-sean@mess.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="wbbmgda3zxkfauio"
Content-Disposition: inline
In-Reply-To: <20231220142426.1275052-1-sean@mess.org>


--wbbmgda3zxkfauio
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Sean,

On Wed, Dec 20, 2023 at 02:24:25PM +0000, Sean Young wrote:
> @@ -151,8 +153,26 @@ static int bcm2835_pwm_probe(struct platform_device =
*pdev)
>  		return dev_err_probe(&pdev->dev, PTR_ERR(pc->clk),
>  				     "clock not found\n");
> =20
> +	ret =3D clk_rate_exclusive_get(pc->clk);
> +	if (ret)
> +		return dev_err_probe(&pdev->dev, ret,
> +				     "fail to get exclusive rate\n");
> +
> +	ret =3D devm_add_action_or_reset(&pdev->dev, devm_clk_rate_exclusive_pu=
t,
> +				       pc->clk);
> +	if (ret) {
> +		clk_rate_exclusive_put(pc->clk);

That clk_rate_exclusive_put() is wrong. If devm_add_action_or_reset()
fails that is already cared for.

Given that Thierry already applied this patch, getting this fixed in a
timely manner would be good.

> +		return ret;
> +	}
> +
> +	pc->rate =3D clk_get_rate(pc->clk);
> +	if (!pc->rate)
> +		return dev_err_probe(&pdev->dev, -EINVAL,
> +				     "failed to get clock rate\n");
> +
>  	pc->chip.dev =3D &pdev->dev;
>  	pc->chip.ops =3D &bcm2835_pwm_ops;
> +	pc->chip.atomic =3D true;
>  	pc->chip.npwm =3D 2;
> =20
>  	platform_set_drvdata(pdev, pc);

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--wbbmgda3zxkfauio
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmWFZVYACgkQj4D7WH0S
/k5AiAf+MDAha9sI61i2bW4wF4su3juJvzsZFHOeICwGN4crhKlvqBxAhUJryM5N
kfuRk/OpTWZ4ZT5dot57QGW3OlGqiYhiaOrsLJAxpAGTtn4D7frZm+DxTo9nWdl/
AQPxivTRLMCDr2fWYZmp99lQFVsEqso/D/NjwVxuhR/JQKman7XEiLiqHR+2P7Je
6DzcsfG8Y5NQI5JP9vLrngiT6wUGhwRAnJ9r5b9xYzHx/t/p6SW+VwRiCT1LrmXo
nXsPvFDA+G5nA4WAY9IeiR7Bi3sFTfrdk4yoeY11We2QcFsYPkQ+tZ+sEguuVwC6
VFtnj7oZOFbti7VwHGVwmI/EmT7a4g==
=Fh16
-----END PGP SIGNATURE-----

--wbbmgda3zxkfauio--