Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp714724rdb; Fri, 22 Dec 2023 02:56:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IH3kSEWtgcsjW3XUcHYkhYGm21AsPeUrLdkHW33iVBi6km30lC63bFeZKgtgeEjahEI6M3D X-Received: by 2002:a17:90a:aa87:b0:28b:c85d:dcba with SMTP id l7-20020a17090aaa8700b0028bc85ddcbamr907121pjq.21.1703242607784; Fri, 22 Dec 2023 02:56:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703242607; cv=none; d=google.com; s=arc-20160816; b=a3KKxDyHthVPVnJSfvOA/vMoAtcSTJz6K2WkyvfEfNgj3H9e6kWvNvD9GMYnOqR0Aw PizVzFxXFNjrTvl/WFr+vNr+teGEEJYjCuSrF2MTuvHdUwuaspsGUDjx1z+oigvXf8yI lV2VYMn/8OtVzCwCvgi6TlyWUjKYLVurWruOCal9nMZW/F/FwF+TIIyERMvzrmi8QQ/j ZWLf6505P6QbTml/ZK8Yu4HEyJizETT/+Tg+etdJuQZRK29p8a1G/JOHHuaGrEhBHMg9 odGu0jLPilcg/8EtMCWhwyyDLaQ12rNMgSRJ29WgCsvw0wV7AUpZNqpCHu42+tr8m+d5 RTzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=42WeL1Wwv9OhYxbWDhdgA2geYTw0nZxAQ5Gy6tBSiVg=; fh=HrL+LWGuCYsSV4v9eh2QYRIE1ZTJ2RHoH3ALgNtqXyM=; b=thJYEmNd30YXhgdkCyzd11z7FuYI60/Ok0B8BZS3WrVEk9RJPgBy6reZ5ilLcAZtw7 58g+3pSSshhf672lN+167ykoRU4pjLSoroJU5cz+NUSXftYrtOqnLldXaHxxE3GgUHgy v4sD2tWvrF3DgwlswXCEUeYRL4l+qAPFiQ1cc0i0ezGWYibsgMk+0r7OdifsY+SGT6qu emSQv3qIOMCGpGLG+2f7c42KJOZA7O3oRhvLfO9Zks8Bv9nxErvmqwe3H8ekf3LxMg26 Q3VRSgIqcyQB476mzmUeNhp3xDgfa2tHqrsENBsiOXhaTPEEzyK5hsUIjNAZEezJnNgc qW9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-9622-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9622-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id i7-20020a17090ad34700b0028acd2b862fsi3272208pjx.19.2023.12.22.02.56.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 02:56:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-9622-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-9622-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9622-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1FCBD287536 for ; Fri, 22 Dec 2023 10:56:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DEC98156D3; Fri, 22 Dec 2023 10:56:41 +0000 (UTC) X-Original-To: linux-kernel@vger.kernel.org Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E79B14A86 for ; Fri, 22 Dec 2023 10:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGdCj-0005fg-LG; Fri, 22 Dec 2023 11:56:33 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rGdCi-000jdA-4V; Fri, 22 Dec 2023 11:56:33 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rGdCi-001cvs-UV; Fri, 22 Dec 2023 11:56:32 +0100 Date: Fri, 22 Dec 2023 11:56:32 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Sean Young Cc: Thierry Reding , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] pwm: bcm2835: Duplicate call to clk_rate_exclusive_put in error path Message-ID: References: <20231222104651.167821-1-sean@mess.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ymvhpr45gntygozu" Content-Disposition: inline In-Reply-To: <20231222104651.167821-1-sean@mess.org> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org --ymvhpr45gntygozu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Sean, thanks for the quick fix. I'd do s/Duplicate/Deduplicate/ in the Subject (+ maybe s/clk_rate_exclusive_put/clk_rate_exclusive_put()/) Apart from that: Fixes: fcc760729359 ("pwm: bcm2835: Allow PWM driver to be used in atomic c= ontext") Reviewed-by: Uwe Kleine-K=F6nig Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --ymvhpr45gntygozu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmWFa18ACgkQj4D7WH0S /k7Xbgf/a1YUNux/6jBZFIIhabIw0fHf+Lk++m/rjPAVFXCfWWkZS+V9C+JZDUNu Nd7N8cJAxGdqzGyDpga6r3bah1a/27ecveoW3bYMPE1GhvlM4SZ6D7qRVq8iuTyP s4knMtScW2mwkwblJJxfWKuGky3VjksZlRlA0lnz+VInkP1YYkwnaFVMxkwBp/0v 8Q/wjyjMZ9+rKa5CmIYAWEu8m/3kFJrI0G5yh7Y7UESQMY3Bl0Xk0mQhdt9+I/T7 UIjZM2cxCkS4Yrmbt9OzEaFHw1ed/TNZVy3PO30SFynuOBp7f2Lf0ha6LndmxT9z svsD5o137K4hxbG2pL/2s2/mJt53iA== =DdMv -----END PGP SIGNATURE----- --ymvhpr45gntygozu--