Received-SPF: pass (google.com: domain of linux-kernel+bounces-9671-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231222082711.454374-1-leobras@redhat.com>
In-Reply-To: <20231222082711.454374-1-leobras@redhat.com>
From: Guo Ren <guoren@kernel.org>
Date: Fri, 22 Dec 2023 19:48:36 +0800
Message-ID: <CAJF2gTShV+xBjHwQKGEQG-JgEUVa6S8egZNcN7xt_2rPucph9Q@mail.gmail.com>
Subject: Re: [RFC PATCH 1/1] riscv: Improve arch_get_mmap_end() macro
To: Leonardo Bras <leobras@redhat.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, 
	Albert Ou <aou@eecs.berkeley.edu>, =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@rivosinc.com>, 
	Conor Dooley <conor.dooley@microchip.com>, Vincent Chen <vincent.chen@sifive.com>, 
	Andy Chiu <andy.chiu@sifive.com>, Charlie Jenkins <charlie@rivosinc.com>, 
	=?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <cleger@rivosinc.com>, 
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 22, 2023 at 4:27=E2=80=AFPM Leonardo Bras <leobras@redhat.com> =
wrote:
>
> This macro caused me some confusion, which took some reviewer's time to
> make it clear, so I propose adding a short comment in code to avoid
> confusion in the future.
>
> Also, added some improvements to the macro, such as removing the
> assumption of VA_USER_SV57 being the largest address space.
>
> Signed-off-by: Leonardo Bras <leobras@redhat.com>
> ---
>  arch/riscv/include/asm/processor.h | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/include/asm/processor.h b/arch/riscv/include/asm/=
processor.h
> index f19f861cda549..2278e2a8362af 100644
> --- a/arch/riscv/include/asm/processor.h
> +++ b/arch/riscv/include/asm/processor.h
> @@ -18,15 +18,21 @@
>  #define DEFAULT_MAP_WINDOW     (UL(1) << (MMAP_VA_BITS - 1))
>  #define STACK_TOP_MAX          TASK_SIZE_64
>
> +/*
> + * addr is a hint to the maximum userspace address that mmap should prov=
ide, so
> + * this macro needs to return the largest address space available so tha=
t
> + * mmap_end < addr, being mmap_end the top of that address space.
> + * See Documentation/arch/riscv/vm-layout.rst for more details.
> + */
>  #define arch_get_mmap_end(addr, len, flags)                    \
>  ({                                                             \
>         unsigned long mmap_end;                                 \
>         typeof(addr) _addr =3D (addr);                            \
>         if ((_addr) =3D=3D 0 || (IS_ENABLED(CONFIG_COMPAT) && is_compat_t=
ask())) \
>                 mmap_end =3D STACK_TOP_MAX;                       \
> -       else if ((_addr) >=3D VA_USER_SV57)                       \
> -               mmap_end =3D STACK_TOP_MAX;                       \
> -       else if ((((_addr) >=3D VA_USER_SV48)) && (VA_BITS >=3D VA_BITS_S=
V48)) \
> +       else if (((_addr) >=3D VA_USER_SV57) && (VA_BITS >=3D VA_BITS_SV5=
7)) \
> +               mmap_end =3D VA_USER_SV57;                        \
It's clearer.

LGTM.
Reviewed-by: Guo Ren <guoren@kernel.org>

> +       else if (((_addr) >=3D VA_USER_SV48) && (VA_BITS >=3D VA_BITS_SV4=
8)) \
>                 mmap_end =3D VA_USER_SV48;                        \
>         else                                                    \
>                 mmap_end =3D VA_USER_SV39;                        \
> --
> 2.43.0
>


--=20
Best Regards
 Guo Ren