Received-SPF: pass (google.com: domain of linux-kernel+bounces-9673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 22 Dec 2023 08:50:56 -0300
From: Antonio Terceiro <antonio.terceiro@linaro.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: uevent: use shared makefile library
Message-ID: <ZYV4ICTvandgWE4I@linaro.org>
References: <20231221204908.341677-2-antonio.terceiro@linaro.org>
 <f38374bd-bb1f-451e-9d34-9c38029ffd15@linuxfoundation.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="VtLPA9UNJt+q8agv"
Content-Disposition: inline
In-Reply-To: <f38374bd-bb1f-451e-9d34-9c38029ffd15@linuxfoundation.org>


--VtLPA9UNJt+q8agv
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 21, 2023 at 02:44:52PM -0700, Shuah Khan wrote:
> On 12/21/23 13:49, Antonio Terceiro wrote:
> > This makes the uevent selftests build not write to the source tree
> > unconditionally, as that breaks out of tree builds when the source tree
> > is read-only. It also avoids leaving a git repository in a dirty state
> > after a build.
> >=20
>=20
> Why can't you do that using make O=3D directive.

That's what I meant by out of tree builds. When using O=3D, the uevent
selftests build still writes to the source directory. Maybe my wording
in the commit message is not clear enough, I will try to improve it.

> > v2: drop spurious extra SPDX-License-Identifier
> >=20
> > Signed-off-by: Antonio Terceiro <antonio.terceiro@linaro.org>
> > ---
> >   tools/testing/selftests/uevent/Makefile | 15 +++------------
> >   1 file changed, 3 insertions(+), 12 deletions(-)
> >=20
> > diff --git a/tools/testing/selftests/uevent/Makefile b/tools/testing/se=
lftests/uevent/Makefile
> > index f7baa9aa2932..872969f42694 100644
> > --- a/tools/testing/selftests/uevent/Makefile
> > +++ b/tools/testing/selftests/uevent/Makefile
> > @@ -1,17 +1,8 @@
> >   # SPDX-License-Identifier: GPL-2.0
> >   all:
> > -include ../lib.mk
> > -
> > -.PHONY: all clean
> > -
> > -BINARIES :=3D uevent_filtering
> > -CFLAGS +=3D -Wl,-no-as-needed -Wall
> > +CFLAGS +=3D -Wl,-no-as-needed -Wall $(KHDR_INCLUDES)
> > -uevent_filtering: uevent_filtering.c ../kselftest.h ../kselftest_harne=
ss.h
> > -	$(CC) $(CFLAGS) $< -o $@
> > +TEST_GEN_PROGS =3D uevent_filtering
> > -TEST_PROGS +=3D $(BINARIES)
> > -EXTRA_CLEAN :=3D $(BINARIES)
> > -
> > -all: $(BINARIES)
> > +include ../lib.mk
>=20
> This change doesn't get the intended result of not writing to
> source tree. Binaries will still be written to the source
> tree unless O=3D is specified.

It does in my tests. Maybe I am missing something.

mainline without the patch:

----------------8<----------------8<----------------8<-----------------
$ make -s defconfig O=3D/tmp/output && make -s kselftest-all TARGETS=3Dueve=
nt O=3D/tmp/output
make[4]: Entrando no diret=F3rio '/home/terceiro/src/linaro/linux/tools/tes=
ting/selftests/uevent'

make[4]: Nada a ser feito para 'all'.
make[4]: Saindo do diret=F3rio '/home/terceiro/src/linaro/linux/tools/testi=
ng/selftests/uevent'

$ git status --ignored
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	tools/testing/selftests/uevent/uevent_filtering

nothing added to commit but untracked files present (use "git add" to track)
$ git clean -dxf
Removing tools/testing/selftests/uevent/uevent_filtering
----------------8<----------------8<----------------8<-----------------

mainline with the patch:

----------------8<----------------8<----------------8<-----------------
$ git branch -m kselftest-uvent kselftest-uvent-o
$ rm -rf /tmp/output/
$ make -s defconfig O=3D/tmp/output && make -s kselftest-all TARGETS=3Dueve=
nt O=3D/tmp/output
make[4]: Entrando no diret=F3rio '/home/terceiro/src/linaro/linux/tools/tes=
ting/selftests/uevent'

gcc -Wl,-no-as-needed -Wall -isystem /tmp/output/usr/include     uevent_fil=
tering.c  -o /tmp/output/kselftest/uevent/uevent_filtering
make[4]: Saindo do diret=F3rio '/home/terceiro/src/linaro/linux/tools/testi=
ng/selftests/uevent'

$ git status --ignored
On branch kselftest-uvent-o
nothing to commit, working tree clean
$ git clean -dxf
$
----------------8<----------------8<----------------8<-----------------

--VtLPA9UNJt+q8agv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEst7mYDbECCn80PEM/A2xu81GC94FAmWFeBoACgkQ/A2xu81G
C94m0Q//WKZqcUvOON9R0vYG+fWY3pF617BKqujoKftM8Glhtq1bQob8x7z3P7u/
FvFvuG7VhkkUtUmOsKFSWghJRnSGDQiKzFnmwWO3U48rsFsuWIohk58kGTDRacoU
gfYXHLhe7yRNGtHfZXh+s7XSNxaX3QZG1YVstMmb4WJwAqXN6WaKIuXcPTwAl7rO
G1SPD+kxUDc+jpAx9j81o6Syy5F3Cuj8hqQEjJrk/rD6QhgCxNtWwNM1OnxnJZRc
pGzu23Ta7y6JGEe0UfwGn/HbhhXL3TJXVvIgzlMb3eY3zPVRhjVT3T6mUyWjSCV5
wfpl2YrpSTp9Iay+booAZTrM+V5dUgFIj2kYGlxRlAYWwGxYr0LKPORMQ+FJQcla
H5L0exfaZDGmfv3H6BHH0YdmkyzK8o6T2BDCD+1VR+n1BlxgY7QPUfD9BwiS7aQ2
S2XttPwX7IvmnP7oRlT5aqudeooRadjhxcVLTQpvrXumq8EUgEmTa/GISyEx22Ct
a08kZMNWP5TN02G65swLfDLDmLgVvZdeFPbnoqjwbrCLnqaClhhqOd0Hvti1E653
y9AdomoOjtD28E6M+YFmcaZfMm9PjexWP8yQS2j0Qu5M31OtTjm4remReV2BfpYB
+g0KgpoW7bh11mQ3m2jKY620aeD1U1+1f/2YCPa26xND5FkqU6U=
=Khk4
-----END PGP SIGNATURE-----

--VtLPA9UNJt+q8agv--