Received-SPF: pass (google.com: domain of linux-kernel+bounces-9677-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 22 Dec 2023 11:54:54 +0000
From: Mark Brown <broonie@kernel.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: lgirdwood@gmail.com,
	Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	linux-pwm@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Dmitry Rokosov <ddrokosov@sberdevices.ru>
Subject: Re: [RFC PATCH v1] regulator: pwm-regulator: Fix continuous
 get_voltage for disabled PWM
Message-ID: <e32e0ccd-0e7c-4d74-aa2c-0b8155d97698@sirena.org.uk>
References: <20231221211222.1380658-1-martin.blumenstingl@googlemail.com>
 <0c99b575-5cf2-4bd6-8cfd-af19f5fd58da@sirena.org.uk>
 <CAFBinCDJnVzE2sMwu52MQGTKW7dtCuUoj63ZZHhJPJO0+dZDkg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ege4RUChGIoDBWw+"
Content-Disposition: inline
In-Reply-To: <CAFBinCDJnVzE2sMwu52MQGTKW7dtCuUoj63ZZHhJPJO0+dZDkg@mail.gmail.com>


--ege4RUChGIoDBWw+
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 21, 2023 at 11:42:29PM +0100, Martin Blumenstingl wrote:
> On Thu, Dec 21, 2023 at 10:45=E2=80=AFPM Mark Brown <broonie@kernel.org> =
wrote:

> > Hrm.  Perhaps the regulator should figure out that it's on with a
> > minimum voltage of 1.14V in this case - AIUI that broadly corresponds to
> > your change except for the fact that it doesn't recognise that there's
> > actually an output in this case since it assumes that disabling the PWM
> > disables the output which isn't the case with this hardware.  We'd need
> > to know more about the PWM in that case though I think.

> If you have any specific questions then feel free to ask.
> Generally it's a very simple PWM controller:
> - when disabled the output is LOW
> - when enabled the output matches the requested period and duty cycle
> as best as possible (depending on the available input clocks)

We would need to know more at runtime to do the correct thing I think.

--ege4RUChGIoDBWw+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWFeQ0ACgkQJNaLcl1U
h9BNywgAgAfg176tAU+aqJ+Jp2hFmi4zZ/c3euJEMcr+4MM60eFhd6+i3b9uZsja
ZgEGxvrF4wFzku+4Kkv2Qip7VS5XaAIc/ewN+vzteFnL2ExWwx3FjIi8vgtTi/5Q
FfOHVvo2US7qt+pfwrCfEMMv4vgWfHfz557RYnnkiiY08sVaOprSFkMtFuxVLNWo
YrTHjUUzQv/ComapN/ZSVCjVY96cs4K/0ZiRqys6Xauh2sJBvlOtEvSPPlVxh30S
ErxN1OwlflViYeqHSoNYIR1lzOEpKanAGRx6FGDQaOsK4ES7JEShiaw0gUYL+8cE
TiL63LyYDuOhE2DJuWaetMBvLGo1qg==
=vyyB
-----END PGP SIGNATURE-----

--ege4RUChGIoDBWw+--