Received-SPF: pass (google.com: domain of linux-kernel+bounces-9739-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 22 Dec 2023 13:03:56 +0000
From: Mark Brown <broonie@kernel.org>
To: Xingyu Wu <xingyu.wu@starfivetech.com>
Cc: Conor Dooley <conor@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>,
	Claudiu Beznea <Claudiu.Beznea@microchip.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	Walker Chen <walker.chen@starfivetech.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-sound@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: ASoC: Add Cadence I2S controller for
 StarFive JH8100 SoC
Message-ID: <229ffec0-3a8d-4ce8-a4bb-ef6ece639ad8@sirena.org.uk>
References: <20231221033223.73201-1-xingyu.wu@starfivetech.com>
 <20231221033223.73201-2-xingyu.wu@starfivetech.com>
 <20231221-saddlebag-tricolor-d02a17d66795@spud>
 <f1210b31-25af-4cbd-b73e-2a72aa6c41bf@sirena.org.uk>
 <11c932a8-5596-4186-9c9d-ec8ca5a6ea35@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="w+SYfEWNEZ7TqPiO"
Content-Disposition: inline
In-Reply-To: <11c932a8-5596-4186-9c9d-ec8ca5a6ea35@starfivetech.com>


--w+SYfEWNEZ7TqPiO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Dec 22, 2023 at 05:55:14PM +0800, Xingyu Wu wrote:

> The Cadence I2S can support 8 channels. But on the JH8100 SoC, two
> instances of this just provide 4 channels to use, one just provides 2
> channels, and the other one can provide 8 channels. Should I use the
> property name of 'jh8100,i2s-max-channels' instead for some special
> instances on the JH8100 SoC?

No, your current name is fine if the binding is generic for all Cadence
users.  I do think it would be good to have a separate compatible for
these two channel instances, if there's been one customisation there may
well have been others.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

--w+SYfEWNEZ7TqPiO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWFiTsACgkQJNaLcl1U
h9At3gf9HMiV97V67JGVkqTyZ1zrmOry8r0gKK8wtSM1JZMTyh+tLXWfvH3z5QF+
7R4AzB7A+oYf8tMW7lTlkWL2SFXaWHXL57EgRuWJ72f9/pSQeOVsCdyPb/SlTDho
DXCYHa/88/UPXJeQmvV7spyAvPbMcgid6rThjtPUXPhIH1TzhuwOTDf4jbBRScwe
bpwsDzd4Tp31yJSGHJ+fmCWfCY5aMBg32/4a9PUmkgLtFzNXbs2T4d4nz3TQxIQW
yGSB0T5OfmrTi/l8UZX0OicD4M5P6EF6YPSq/t1tz/h3n7Dr44zdeI6eOrbIv3BR
7ini0mK6YD9+oBUCxvPHtKrUS0fHCA==
=sDbc
-----END PGP SIGNATURE-----

--w+SYfEWNEZ7TqPiO--