Received-SPF: pass (google.com: domain of linux-kernel+bounces-9742-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 22 Dec 2023 13:12:15 +0000
From: Mark Brown <broonie@kernel.org>
To: Gergo Koteles <soyer@irl.hu>
Cc: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
	Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/tas2781: do not use regcache
Message-ID: <59d1b8c5-d57f-4e0c-a083-2afa1151823b@sirena.org.uk>
References: <491aeed0e2eecc3b704ec856f815db21bad3ba0e.1703202126.git.soyer@irl.hu>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XgMk3W0ruc1CbKKK"
Content-Disposition: inline
In-Reply-To: <491aeed0e2eecc3b704ec856f815db21bad3ba0e.1703202126.git.soyer@irl.hu>


--XgMk3W0ruc1CbKKK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 22, 2023 at 12:48:56AM +0100, Gergo Koteles wrote:
> There are two problems with using regcache in this module.
>=20
> The amplifier has 3 addressing levels (BOOK, PAGE, REG). The firmware
> contains blocks that must be written to BOOK 0x8C. The regcache doesn't
> know anything about BOOK, so regcache_sync writes invalid values to the
> actual BOOK.

Acked-by: Mark Brown <broonie@kernel.org>

--XgMk3W0ruc1CbKKK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWFiy8ACgkQJNaLcl1U
h9BUmggAhajnsdiUj4Nk7Jcnz2WIP3eRE2vHqZPTJhYsfkBd7u3Yn9DMdoH0goPc
UcxQT53S55+f6UNFGS6NcrDs+h3iM0i5PIfrfCSMCdIuYs+87yGJhITecY/cT828
JYN7tDEHav3SrMdpbEqtEFpSUhyaoRkxCN3l/e4RP5Szi4uYGtqcxAXP7xR5HjsJ
fHwyDCYucrE5cBDKUCkhInxWVP5X2pxrTN9KbgRYuc3TTKW05q4AeRKObrHGuDlc
8kIoxdeyzC8Kp30037CJdJftbR+Zolyy4s3WGpMugFSuJvizSVqh/pIS1Y/cA5Mo
IWOo4LBa+sesOuYFbs2nUbhdTB5sLw==
=Z9xT
-----END PGP SIGNATURE-----

--XgMk3W0ruc1CbKKK--