Received-SPF: pass (google.com: domain of linux-kernel+bounces-9746-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <a93867af-80e6-ab91-6a13-cdf94aa7f80c@quicinc.com>
Date: Fri, 22 Dec 2023 18:54:59 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH 1/2] arm64: dts: qcom: qcm6490-idp: Enable various
 remoteprocs
Content-Language: en-US
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>
CC: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Bjorn Andersson
	<andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231220114225.26567-1-quic_kbajaj@quicinc.com>
 <20231220114225.26567-2-quic_kbajaj@quicinc.com>
 <d7ae374a-7269-4992-ad44-18b2516cad42@linaro.org>
 <CAA8EJppYuXpqKpTcUda1LBFfBmm40-VpC+3heJqoL82kS=+erA@mail.gmail.com>
 <519138d9-2434-4357-abec-f400b87755c6@linaro.org>
 <CAA8EJpoEwU_S05EdO+sXekE355d5vAQCO+Vt3iH9yibhqOhH_A@mail.gmail.com>
From: Komal Bajaj <quic_kbajaj@quicinc.com>
In-Reply-To: <CAA8EJpoEwU_S05EdO+sXekE355d5vAQCO+Vt3iH9yibhqOhH_A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 12/20/2023 6:04 PM, Dmitry Baryshkov wrote:
> On Wed, 20 Dec 2023 at 14:29, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> On 20.12.2023 13:18, Dmitry Baryshkov wrote:
>>> On Wed, 20 Dec 2023 at 13:46, Krzysztof Kozlowski
>>> <krzysztof.kozlowski@linaro.org> wrote:
>>>>
>>>> On 20/12/2023 12:42, Komal Bajaj wrote:
>>>>> Enable the ADSP, CDSP, MPSS and WPSS that are found on the SoC.
>>>>>
>>>>> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
>>>>> ---
>>>>>   arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 20 ++++++++++++++++++++
>>>>>   1 file changed, 20 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>>>> index 03e97e27d16d..ad78efa9197d 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>>>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
>>>>> @@ -419,6 +419,26 @@ &qupv3_id_0 {
>>>>>        status = "okay";
>>>>>   };
>>>>>
>>>>> +&remoteproc_adsp {
>>>>> +     firmware-name = "qcom/qcm6490/adsp.mdt";
>>>>
>>>> Why MDT not MBN?
>>>
>>> I agree here. NAK until this is .mbn. Please follow the example of
>>> other boards when you write patches.
>>>
>>>>
>>>> I don't see these files in linux-firmware and your cover letter did not
>>>> explain anything around their submission. What's the status on that part?
>>>
>>> This isn't usually required, is it? I mean, the firmware can come from
>>> linux-firmware, from the device partition or in any other way. With
>>> the FW_LOADER_USER_HELPER this becomes just the key string used to
>>> identify firmware to be loaded.
>> I think Krzysztof referenced the fact that the Qualcomm-made boards
>> usually came with redistributable firmware.
>>
>> As far as my 5 cents go, not submitting the files to linux-firmware.git
>> only harms the user experience, so I'd always advocate for it, whenever
>> that is actually possible.
> 
> Me too. I think this is work in progress on the Qualcomm side, see the
> discussion at https://github.com/Linaro/meta-qcom/pull/551 .
> 

I was searching for MBN files pushed for SM8550 at 
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/, 
but could not find it. Am I missing something?

Are we maintaining it somewhere else asking just out of curiosity and 
learning and do similar for QCM/QCS6490.

Thanks
Komal