Received-SPF: pass (google.com: domain of linux-kernel+bounces-9755-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 22 Dec 2023 15:30:16 +0200
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Igor Mammedov <imammedo@redhat.com>, Lukas Wunner <lukas@wunner.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] resource: Use typedef for alignf callback
Message-ID: <ZYWPaGc4rjymcm75@smile.fi.intel.com>
References: <20231222122901.49538-1-ilpo.jarvinen@linux.intel.com>
 <20231222122901.49538-5-ilpo.jarvinen@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231222122901.49538-5-ilpo.jarvinen@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Dec 22, 2023 at 02:28:58PM +0200, Ilpo J?rvinen wrote:
> To make it simpler to declare resource constraint alignf callbacks, add
> typedef for it and document it.

Suggested-by?

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

> +/**
> + * resource_alignf - Resource alignment callback
> + * @data:	Private data used by the callback
> + * @res:	Resource candidate range (an empty resource slot)
> + * @size:	The minimum size of the empty slot
> + * @align:	Alignment from the constraints
> + *
> + * Callback allows calculating resource placement and alignment beyond min,
> + * max, and align fields in the struct resource_constraint.
> + *
> + * Return: Start address for the resource.
> + */
> +typedef resource_size_t (*resource_alignf)(void *data,
> +					   const struct resource *res,
> +					   resource_size_t size,
> +					   resource_size_t align);

Never saw typedef kernel-doc before, so hopefully this will be rendered
just fine.

-- 
With Best Regards,
Andy Shevchenko