Received-SPF: pass (google.com: domain of linux-kernel+bounces-9756-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 22 Dec 2023 15:34:24 +0200
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Igor Mammedov <imammedo@redhat.com>, Lukas Wunner <lukas@wunner.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] resource: Handle simple alignment inside
 __find_empty_resource_slot()
Message-ID: <ZYWQYNlYynPRdecK@smile.fi.intel.com>
References: <20231222122901.49538-1-ilpo.jarvinen@linux.intel.com>
 <20231222122901.49538-6-ilpo.jarvinen@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231222122901.49538-6-ilpo.jarvinen@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Dec 22, 2023 at 02:28:59PM +0200, Ilpo J?rvinen wrote:
> allocate_resource() accepts alignf callback to perform custom alignment

s/alignf callback/->alignf() callback/

?

> beyond constraint->align. If alignf is NULL, simple_align_resource() is
> used which only returns avail->start (no change).
> 
> Using avail->start directly is natural and can be done with a
> conditional in __find_empty_resource_slot() instead which avoids
> unnecessarily using callback. It makes the code inside
> __find_empty_resource_slot() more obvious and removes the need for the
> caller to provide constraint->alignf unnecessarily.
> 
> This is preparation for exporting find_empty_resource_slot().

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

>  		if (avail.start >= tmp.start) {
>  			alloc.flags = avail.flags;
> -			alloc.start = constraint->alignf(constraint->alignf_data, &avail,
> -					size, constraint->align);
> +			if (alignf) {
> +				alloc.start = alignf(constraint->alignf_data,

> +						     &avail, size,
> +						     constraint->align);

Maybe one line? It used to be a longer line in the old code.

> +			} else {
> +				alloc.start = avail.start;
> +			}

-- 
With Best Regards,
Andy Shevchenko