Received-SPF: pass (google.com: domain of linux-kernel+bounces-9779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 22 Dec 2023 15:26:39 +0100
From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Nicolas Schier <nicolas@fjasle.eu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] kbuild: deb-pkg: hard-code Build-Depends
Message-ID: <ZYWcn3QUrndoiHN9@buildd.core.avm.de>
Mail-Followup-To: Masahiro Yamada <masahiroy@kernel.org>,
	linux-kbuild@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org
References: <20231219181957.1449958-1-masahiroy@kernel.org>
 <20231219181957.1449958-2-masahiroy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231219181957.1449958-2-masahiroy@kernel.org>
Organization: AVM GmbH

On Wed, Dec 20, 2023 at 03:19:56AM +0900, Masahiro Yamada wrote:
> The condition to require libelf-dev:native is stale because objtool is
> now enabled by CONFIG_OBJTOOL instead of CONFIG_UNWINDER_ORC. Not only
> objtool but also resolve_btfids requires libelf-dev:native; therefore,
> CONFIG_DEBUG_INFO_BTF should be checked as well.
> 
> Similarly, CONFIG_SYSTEM_TRUSTED_KEYRING is not the only case that
> requires libssl-dev:native.
> 
> Perhaps, the following code would provide better coverage, but it is
> hard to maintain (and may still be imperfect).
> 
>   if is_enabled CONFIG_OBJTOOL || is_enabled CONFIG_DEBUG_INFO_BTF; then
>           build_depends="${build_depends}, libelf-dev:native"
>   fi
> 
>   if is_enabled CONFIG_SYSTEM_TRUSTED_KEYRING ||
>      is_enabled CONFIG_SYSTEM_REVOCATION_LIST ||
>      is_enabled CONFIG_MODULE_SIG_FORMAT; then
>           build_depends="${build_depends}, libssl-dev:native"
>   fi
> 
> Let's hard-code the build dependency.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Reviewed-by: Nicolas Schier <n.schier@avm.de>