Received-SPF: pass (google.com: domain of linux-kernel+bounces-9807-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 22 Dec 2023 10:03:03 -0500
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: =?UTF-8?B?SsO2cm4tVGhvcmJlbiBIaW56?= <jthinz@mailbox.tu-berlin.de>, 
 netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org
Cc: =?UTF-8?B?SsO2cm4tVGhvcmJlbiBIaW56?= <jthinz@mailbox.tu-berlin.de>, 
 "David S. Miller" <davem@davemloft.net>, 
 Eric Dumazet <edumazet@google.com>, 
 Jakub Kicinski <kuba@kernel.org>, 
 Paolo Abeni <pabeni@redhat.com>, 
 Willem de Bruijn <willemb@google.com>, 
 Deepa Dinamani <deepa.kernel@gmail.com>
Message-ID: <6585a52790fd0_d4884294ea@willemb.c.googlers.com.notmuch>
In-Reply-To: <20231221231901.67003-1-jthinz@mailbox.tu-berlin.de>
References: <20231221231901.67003-1-jthinz@mailbox.tu-berlin.de>
Subject: Re: [PATCH net] net: Implement missing
 getsockopt(SO_TIMESTAMPING_NEW)
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable

J=C3=B6rn-Thorben Hinz wrote:
> Commit 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW") added the new
> socket option SO_TIMESTAMPING_NEW. Setting the option is handled in
> sk_setsockopt(), querying it was not handled in sk_getsockopt(), though=
.
> =

> Following remarks on an earlier submission of this patch, keep the old
> behavior of getsockopt(SO_TIMESTAMPING_OLD) which returns the active
> flags even if they actually have been set through SO_TIMESTAMPING_NEW.
> =

> The new getsockopt(SO_TIMESTAMPING_NEW) is stricter, returning flags
> only if they have been set through the same option.
> =

> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Link: https://lore.kernel.org/lkml/20230703175048.151683-1-jthinz@mailb=
ox.tu-berlin.de/
> Link: https://lore.kernel.org/netdev/0d7cddc9-03fa-43db-a579-14f3e82261=
5b@app.fastmail.com/
> Signed-off-by: J=C3=B6rn-Thorben Hinz <jthinz@mailbox.tu-berlin.de>

Reviewed-by: Willem de Bruijn <willemb@google.com>=