Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp866725rdb; Fri, 22 Dec 2023 07:21:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IH30AuwMvpUExHjxmo69iFzxOIi2ZMwQ9CnIw60uofao5QQ+dPWdNxc14ZBctzANpvLjzjR X-Received: by 2002:ac2:46f6:0:b0:50e:4af6:1f91 with SMTP id q22-20020ac246f6000000b0050e4af61f91mr787729lfo.37.1703258475081; Fri, 22 Dec 2023 07:21:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1703258475; cv=none; d=google.com; s=arc-20160816; b=LyNBWfhovCSUgNOQ3YduqMQ3cKQkBOBadsUy6tT5ScDIO89b4SybcRmP0sTO3Tcf3/ 0LVs9X6Ve1Kf7trejb8KjrIGSaqJ02ZX97/POE0ibfv5HDkoQnrZtk6pjH/7qY/CReSP i4QJSeTlbTJEgxeSJegvczwKAkSvfKunH+HrJ8vzMcLc/qgYWxyxUginv1SD5BWNjGlt 51NC3A9clFjCYgphEMlVtoNRS81vNxcNF6kHD3MWstypviCJs7tBqdB86Xio4m+ut/Bg 7mI41V1weMvb9vawRB/CSjkQT6bDnB+B++d/esCA+RmvNC+gryZVbs344uOjys4buH4B h4Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=vSRtoBhWiymkrUriREDGEOquZtVYvqi7wp6gqOzPpq0=; fh=fUFzgJc1/kgUfq6BPN/bCy6q7r4YjH7SPfVUiUwIe+0=; b=MZFS+k+jtyASQoSs5IFf/MGV9s5nKzczF+HcHBC6Q8y/5SKf+K9mb3rTc7KbRD2X1L SythMNo4BKPB4RbfOgwcLQlpVdSCPvN7jIXazvqIOhN7UqcCZtE1Oi1u6rVqw1nd8T9P Y0RiyZuTVSV4Dn4NzTKPAvpWvB5desyx5tIqaAOrPeqoUrIo63JrXu4TWaDrqg92tXVU FigPZzFEMsFGY5JJQW5KPJ3MSFIcfKNvx/hccRhIfwxx+/zsjqUQMlUUaV80v90Q+8ye 5qiLA3Dn8Au2iS8OjTldw4Bfqlx0IRkE6TUGdIJ+GgNGsjXCBZVOUf9mW7pSZYEY5jFd odIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=EwhMMlXL; spf=pass (google.com: domain of linux-kernel+bounces-9829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9829-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id y6-20020a056402358600b00554752ccda0si144156edc.42.2023.12.22.07.21.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Dec 2023 07:21:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-9829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=EwhMMlXL; spf=pass (google.com: domain of linux-kernel+bounces-9829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-9829-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BF8451F270F1 for ; Fri, 22 Dec 2023 15:14:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52E893173F; Fri, 22 Dec 2023 15:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="EwhMMlXL" X-Original-To: linux-kernel@vger.kernel.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6202630CFB; Fri, 22 Dec 2023 15:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=vSRtoBhWiymkrUriREDGEOquZtVYvqi7wp6gqOzPpq0=; b=EwhMMlXLFZbb/tlh1Ap0vPdrcR QeXKb5dVMvla5R8BdZFAmfwJTIijr0Gqh4grvfBE2kVQ74iY2pchwGk1U6PBfvQLlseP3Joxij14M f6DDtw8jvufT1eQ0dD6EnwdEEfmngoOSFwXb3tcNOHge1rxqDek23e1IBIgaxlzAOjCOrrDyZ1Pm9 6bpZHxF0yNGAKL1BWEHRC7Ee16sHdUCn73JAe5XO5P7gvg/24bmDnR1HUJ/8m8hxdxp+ALaoGDdjh CrJ0gy89UfK4aZ28Lih1VvI2b3nUn8Yje//rK3yG35lU++vIYwhUFSmTiW8uFt5D70kn6sI9l1clv MGfNkVlA==; Received: from 2a02-8389-2341-5b80-39d3-4735-9a3c-88d8.cable.dynamic.v6.surfer.at ([2a02:8389:2341:5b80:39d3:4735:9a3c:88d8] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rGh9B-006Bdj-10; Fri, 22 Dec 2023 15:09:09 +0000 From: Christoph Hellwig To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Jan Kara , David Howells , Brian Foster , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Chinner , Jan Kara Subject: [PATCH 17/17] writeback: update the kerneldoc comment for tag_pages_for_writeback Date: Fri, 22 Dec 2023 16:08:27 +0100 Message-Id: <20231222150827.1329938-18-hch@lst.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231222150827.1329938-1-hch@lst.de> References: <20231222150827.1329938-1-hch@lst.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Don't refer to write_cache_pages, which now is just a wrapper for the writeback iterator. Signed-off-by: Christoph Hellwig Acked-by: Dave Chinner Reviewed-by: Jan Kara --- mm/page-writeback.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 1ff444d5e4317a..0546741856d70d 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c @@ -2325,18 +2325,18 @@ void __init page_writeback_init(void) } /** - * tag_pages_for_writeback - tag pages to be written by write_cache_pages + * tag_pages_for_writeback - tag pages to be written by writeback * @mapping: address space structure to write * @start: starting page index * @end: ending page index (inclusive) * * This function scans the page range from @start to @end (inclusive) and tags - * all pages that have DIRTY tag set with a special TOWRITE tag. The idea is - * that write_cache_pages (or whoever calls this function) will then use - * TOWRITE tag to identify pages eligible for writeback. This mechanism is - * used to avoid livelocking of writeback by a process steadily creating new - * dirty pages in the file (thus it is important for this function to be quick - * so that it can tag pages faster than a dirtying process can create them). + * all pages that have DIRTY tag set with a special TOWRITE tag. The caller + * can then use the TOWRITE tag to identify pages eligible for writeback. + * This mechanism is used to avoid livelocking of writeback by a process + * steadily creating new dirty pages in the file (thus it is important for this + * function to be quick so that it can tag pages faster than a dirtying process + * can create them). */ void tag_pages_for_writeback(struct address_space *mapping, pgoff_t start, pgoff_t end) -- 2.39.2