Received-SPF: pass (google.com: domain of linux-kernel+bounces-9838-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 22 Dec 2023 15:27:36 +0000
From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Petre Rodan <petre.rodan@subdimension.ro>, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	Conor Dooley <conor+dt@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: pressure: honeywell,mprls0025pa
Message-ID: <20231222-thread-secret-d8b49c896249@spud>
References: <20231219130230.32584-1-petre.rodan@subdimension.ro>
 <20231219130230.32584-2-petre.rodan@subdimension.ro>
 <20231220151645.16ada807@jic23-huawei>
 <ZYMjhfAbWfw9vUdd@sunspire>
 <20231221110417.0bd5b002@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Ba29eN3gYKwLHH9V"
Content-Disposition: inline
In-Reply-To: <20231221110417.0bd5b002@jic23-huawei>


--Ba29eN3gYKwLHH9V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 21, 2023 at 11:04:17AM +0000, Jonathan Cameron wrote:
> On Wed, 20 Dec 2023 19:25:25 +0200
> Petre Rodan <petre.rodan@subdimension.ro> wrote:
>=20
> > hi Jonathan,
> >=20
> > On Wed, Dec 20, 2023 at 03:16:45PM +0000, Jonathan Cameron wrote:
> > > On Tue, 19 Dec 2023 15:02:20 +0200
> > > Petre Rodan <petre.rodan@subdimension.ro> wrote: =20
> > > >    honeywell,pmin-pascal:
> > > >      description:
> > > >        Minimum pressure value the sensor can measure in pascal.
> > > > +      To be specified only if honeywell,pressure-triplet is set to=
 "NA". =20
> > > That just added a backwards compatibility break.  It would be fine
> > > if there was a default: NA for honeywell,pressure-triplet or a check =
that either
> > > one or the other was supplied (which I'd prefer).  Thus old bindings =
will work
> > > and new ones also supported. =20
> >=20
> > ok, I see your reasoning. but in this second scenario that you prefer h=
ow can we
> > propery define the 'required:' block? an equivalent to
> >=20
> > required:
> >   - compatible
> >   - reg
> >   - (honeywell,pmin-pascal && honeywell,pmax-pascal) || honeywell,press=
ure-triplet
> >   - honeywell,transfer-function
>=20
> Yes, it would end up something like that.  There are exclusive or example=
s in tree.
> I think something like dac/adi,ad3552r.yaml
>  should work.
>=20
> oneOf:
>   - required:
>       - honeywell,pmin-pascal
>       - honeywell,pmax-pascal
>   - required:
>       - honeywell,pressure-triplet
>=20
> but you will want to try all the cases to make sure that works (my abilit=
y to
> figure these ones out is tricky).
>=20
> + you ideally want to exclude them all being set which is fiddlier.
>=20
> Some similar examples but they are based on a value in the property. I'm =
not
> sure how you check for it just being defined.
>=20
> Something along lines of.
>=20
> allOf:
>   - if:
>       properties:
>         honeywell,pressure-triplet
>     then:
>       properties:
>         honeywell,pmin-pascal: false
>         honeywell,pmax-pascal: false
>=20
> Might work?  I always end up trawling the kernel to find a similar exampl=
e for cases but
> can't find anything closer right now.

I hate to admit it, but I'm not great at expressing these in the minimum
forms either, but I think you're missing a "required" from here, in place
of the "properties":
allOf:
  - if:
      required:
        - honeywell,pressure-triplet
    then:
      properties:
        honeywell,pmin-pascal: false
        honeywell,pmax-pascal: false

Cheers,
Conor.

--Ba29eN3gYKwLHH9V
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZYWq6AAKCRB4tDGHoIJi
0sGFAQCS3lpqDDVpd0E7HfIT4+N4EHkkAJryhPfoBZyl0+bDSgEA5odFWMtIApkV
9fU4oaAh5VlqUtiwBtY1OCUWX+omLQ4=
=2QDc
-----END PGP SIGNATURE-----

--Ba29eN3gYKwLHH9V--