Received-SPF: pass (google.com: domain of linux-kernel+bounces-9847-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Dan Moulding <dan@danm.net>
To: bagasdotme@gmail.com
Cc: alexhenrie24@gmail.com,
	dan@danm.net,
	davem@davemloft.net,
	dsahern@kernel.org,
	edumazet@google.com,
	kuba@kernel.org,
	linux-kernel@vger.kernel.org,
	pabeni@redhat.com,
	regressions@lists.linux.dev
Subject: Re: [REGRESSION] net/ipv6/addrconf: Temporary addresses with short lifetimes generating when they shouldn't, causing applications to fail
Date: Fri, 22 Dec 2023 08:37:03 -0700
Message-ID: <20231222153703.11268-1-dan@danm.net>
In-Reply-To: <ZYWNr_4P-je2uVDe@archie.me>
References: <ZYWNr_4P-je2uVDe@archie.me>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

> > I bisected it to commit 629df6701c8a ("net: ipv6/addrconf: clamp
> > preferred_lft to the minimum required"). Upon reviewing that change, I
> > see that it has changed when generation of temporary addresses will be
> > allowed. I believe that change might have inadvertently caused the
> > kernel to violate RFC 4941 and might need to be reverted.
>
> Can you verify that by actually reverting 629df6701c8a91 on top of net
> tree?

Yes, after bisecting it to that commit, I did revert it on top of
v6.7-rc6 and verified that the problem goes away. It doesn't start
accumulating addresses once every second. Instead the single temporary
address that was generated for the deprecated prefix is still there,
with a preferred lifetime of 0, like I'd expect, and no new addresses
get generated. The application-level problems are also gone (Chromium
loads pages without issue, and avahi-daemon hasn't jumped to 100%
CPU).

I'm now running it this way on several machines and everything is
looking good again.

-- Dan